From: Jakub Jelinek <jakub@redhat.com>
To: Jason Merrill <jason@redhat.com>, gcc-patches@gcc.gnu.org
Subject: [PATCH] c++: Avoid informs without a warning [PR109278]
Date: Sat, 25 Mar 2023 11:08:05 +0100 [thread overview]
Message-ID: <ZB7IBe1ytkKihzTP@tucnak> (raw)
Message-ID: <20230325100805.cHyrx2Xqzirw6BnR4rObsoKW9QZxpyXrWx4HRijPUJY@z> (raw)
Hi!
On the following testcase we emit notes in
maybe_inform_about_fndecl_for_bogus_argument_init
despite no warning/error being printed before it.
This is for the extended floating point type conversions where pedwarn
is used, and complained is used there for 2 different purposes,
one is whether an unspecific error should be emitted if we haven't
complained otherwise, and one whether
maybe_inform_about_fndecl_for_bogus_argument_init should be called.
For the 2 pedwarns, currently it sets complained to true regardless of
whether pedwarn succeeded, which results in the undesirable notes printed
with -w. If complained is initialized to result of pedwarn, we would
emit an error later on.
So, the following patch makes complained a tristate, the additional
error isn't printed if complained != 0, and
maybe_inform_about_fndecl_for_bogus_argument_init is called only if
complained == 1, so if pedwarn returns false, we can use complained = -1
to tell later code not to emit an error and not to call
maybe_inform_about_fndecl_for_bogus_argument_init.
Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?
2023-03-25 Jakub Jelinek <jakub@redhat.com>
PR c++/109278
* call.cc (convert_like_internal): If pedwarn for extended float
type conversions doesn't report anything, avoid calling
maybe_inform_about_fndecl_for_bogus_argument_init.
* g++.dg/cpp23/ext-floating15.C: New test.
--- gcc/cp/call.cc.jj 2023-03-23 15:24:33.074801422 +0100
+++ gcc/cp/call.cc 2023-03-24 22:29:06.328140170 +0100
@@ -8296,7 +8296,7 @@ convert_like_internal (conversion *convs
|| SCALAR_TYPE_P (totype))
&& convs->kind != ck_base)
{
- bool complained = false;
+ int complained = 0;
conversion *t = convs;
/* Give a helpful error if this is bad because of excess braces. */
@@ -8328,14 +8328,18 @@ convert_like_internal (conversion *convs
totype))
{
case 2:
- pedwarn (loc, 0, "converting to %qH from %qI with greater "
- "conversion rank", totype, TREE_TYPE (expr));
- complained = true;
+ if (pedwarn (loc, 0, "converting to %qH from %qI with greater "
+ "conversion rank", totype, TREE_TYPE (expr)))
+ complained = 1;
+ else if (!complained)
+ complained = -1;
break;
case 3:
- pedwarn (loc, 0, "converting to %qH from %qI with unordered "
- "conversion ranks", totype, TREE_TYPE (expr));
- complained = true;
+ if (pedwarn (loc, 0, "converting to %qH from %qI with unordered "
+ "conversion ranks", totype, TREE_TYPE (expr)))
+ complained = 1;
+ else if (!complained)
+ complained = -1;
break;
default:
break;
@@ -8389,7 +8393,7 @@ convert_like_internal (conversion *convs
"invalid conversion from %qH to %qI",
TREE_TYPE (expr), totype);
}
- if (complained)
+ if (complained == 1)
maybe_inform_about_fndecl_for_bogus_argument_init (fn, argnum);
return cp_convert (totype, expr, complain);
--- gcc/testsuite/g++.dg/cpp23/ext-floating15.C.jj 2023-03-24 22:38:40.358890548 +0100
+++ gcc/testsuite/g++.dg/cpp23/ext-floating15.C 2023-03-24 22:38:18.484204916 +0100
@@ -0,0 +1,11 @@
+// PR c++/109278
+// { dg-do compile { target float128 } }
+// { dg-options "-w" }
+
+void foo (long double); // { dg-bogus "initializing argument 1 of" }
+
+void
+bar (_Float128 x)
+{
+ foo (x);
+}
Jakub
next reply other threads:[~2023-03-25 11:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-25 10:10 Jakub Jelinek [this message]
2023-03-25 10:08 ` Jakub Jelinek
2023-03-29 20:35 ` Jason Merrill
2023-03-29 20:57 ` Jakub Jelinek
2023-03-30 2:53 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZB7IBe1ytkKihzTP@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).