public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH v5] gcc: Drop obsolete INCLUDE_PTHREAD_H
@ 2023-04-02 21:33 Sam James
  2023-04-18 19:28 ` Jeff Law
  0 siblings, 1 reply; 3+ messages in thread
From: Sam James @ 2023-04-02 21:33 UTC (permalink / raw)
  To: gcc-patches
  Cc: Kito Cheng, Palmer Dabbelt, Andrew Waterman, Jim Wilson,
	Ju-Zhe Zhong, Jeff Law, Sam James

INCLUDE_PTHREAD_H was added for r13-1350-g49d508065bdd36 for a calloc poisoning
issue like r13-6662-g0e6f87835ccabf.

When working on r13-6662-g0e6f87835ccabf, we realised that INCLUDE_PTHREAD_H
became unused as of r13-4164-g0a62889c7a155f (which was originally added
for r13-1350-g49d508065bdd36 for a similar musl issue).

I originally tried to use INCLUDE_PTHREAD_H in r13-6662-g0e6f87835ccabf even though
it was the wrong solution, so let's drop it given it's both:
1. now obsolete;
2. a bit confusing.

Nothing is using this to guard inclusion of pthread.h and it only ever had
one consumer in the tree which is now gone.

gcc/ChangeLog:
	* system.h: Drop unused INCLUDE_PTHREAD_H.

Thanks-to: Andrew Pinski <pinskia@gmail.com>
Signed-off-by: Sam James <sam@gentoo.org>
---
 gcc/system.h | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/gcc/system.h b/gcc/system.h
index cf45db3f97e..3fdad7abf1e 100644
--- a/gcc/system.h
+++ b/gcc/system.h
@@ -761,10 +761,6 @@ extern int vsnprintf (char *, size_t, const char *, va_list);
 #endif
 #endif
 
-#ifdef INCLUDE_PTHREAD_H
-#include <pthread.h>
-#endif
-
 #ifdef INCLUDE_ISL
 #ifdef HAVE_isl
 #include <isl/options.h>
-- 
2.40.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v5] gcc: Drop obsolete INCLUDE_PTHREAD_H
  2023-04-02 21:33 [PATCH v5] gcc: Drop obsolete INCLUDE_PTHREAD_H Sam James
@ 2023-04-18 19:28 ` Jeff Law
  2023-04-19  2:18   ` Sam James
  0 siblings, 1 reply; 3+ messages in thread
From: Jeff Law @ 2023-04-18 19:28 UTC (permalink / raw)
  To: Sam James, gcc-patches
  Cc: Kito Cheng, Palmer Dabbelt, Andrew Waterman, Jim Wilson, Ju-Zhe Zhong



On 4/2/23 15:33, Sam James wrote:
> gcc/ChangeLog:
> 	* system.h: Drop unused INCLUDE_PTHREAD_H.
THanks.  I've pushed this to the trunk.
jeff

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v5] gcc: Drop obsolete INCLUDE_PTHREAD_H
  2023-04-18 19:28 ` Jeff Law
@ 2023-04-19  2:18   ` Sam James
  0 siblings, 0 replies; 3+ messages in thread
From: Sam James @ 2023-04-19  2:18 UTC (permalink / raw)
  To: Jeff Law
  Cc: gcc-patches, Kito Cheng, Palmer Dabbelt, Andrew Waterman,
	Jim Wilson, Ju-Zhe Zhong

[-- Attachment #1: Type: text/plain, Size: 219 bytes --]


Jeff Law <jeffreyalaw@gmail.com> writes:

> On 4/2/23 15:33, Sam James wrote:
>> gcc/ChangeLog:
>> 	* system.h: Drop unused INCLUDE_PTHREAD_H.
> THanks.  I've pushed this to the trunk.

Cheers Jeff!

> jeff

best,
sam

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 377 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-04-19  2:18 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-02 21:33 [PATCH v5] gcc: Drop obsolete INCLUDE_PTHREAD_H Sam James
2023-04-18 19:28 ` Jeff Law
2023-04-19  2:18   ` Sam James

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).