* [PATCH V5] Testsuite: Fix a redefinition bug for the fd-4.c
@ 2023-04-12 13:18 shiyulong
2023-04-28 21:51 ` Jeff Law
0 siblings, 1 reply; 2+ messages in thread
From: shiyulong @ 2023-04-12 13:18 UTC (permalink / raw)
To: gcc-patches
Cc: palmer, kito.cheng, jim.wilson.gcc, wuwei2016, jiawei, shihua,
dje.gcc, mirimmad, pinskia, jeffreyalaw, dmalcolm, yulong
From: yulong <shiyulong@iscas.ac.cn>
This patch fix a redefinition bug.
There are have a definition about mode_t in the fd-4.c, but it duplicates the definition in types.h that be included by stdio.h.
Thanks to Jeff Law for reviewing the previous version.
gcc/testsuite/ChangeLog:
* gcc.dg/analyzer/fd-4.c: delete the definition of mode_t.
---
gcc/testsuite/gcc.dg/analyzer/fd-4.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/gcc/testsuite/gcc.dg/analyzer/fd-4.c b/gcc/testsuite/gcc.dg/analyzer/fd-4.c
index 994bad84342..9ec015679e9 100644
--- a/gcc/testsuite/gcc.dg/analyzer/fd-4.c
+++ b/gcc/testsuite/gcc.dg/analyzer/fd-4.c
@@ -13,11 +13,6 @@ int read (int fd, void *buf, int nbytes);
#define O_WRONLY 1
#define O_RDWR 2
-typedef enum {
- S_IRWXU
- // etc
-} mode_t;
-
int creat (const char *, mode_t mode);
void
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH V5] Testsuite: Fix a redefinition bug for the fd-4.c
2023-04-12 13:18 [PATCH V5] Testsuite: Fix a redefinition bug for the fd-4.c shiyulong
@ 2023-04-28 21:51 ` Jeff Law
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Law @ 2023-04-28 21:51 UTC (permalink / raw)
To: shiyulong, gcc-patches
Cc: palmer, kito.cheng, jim.wilson.gcc, wuwei2016, jiawei, shihua,
dje.gcc, mirimmad, pinskia, dmalcolm
On 4/12/23 07:18, shiyulong@iscas.ac.cn wrote:
> From: yulong <shiyulong@iscas.ac.cn>
>
> This patch fix a redefinition bug.
> There are have a definition about mode_t in the fd-4.c, but it duplicates the definition in types.h that be included by stdio.h.
> Thanks to Jeff Law for reviewing the previous version.
>
> gcc/testsuite/ChangeLog:
>
> * gcc.dg/analyzer/fd-4.c: delete the definition of mode_t.
This appears to be exactly the same as the prior version. Ultimately
David Malcolm needs to make a decision on whether or not to accept this
patch as it's a patc for the analyzer's testsuite.
David -- comments?
jeff
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-28 21:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-12 13:18 [PATCH V5] Testsuite: Fix a redefinition bug for the fd-4.c shiyulong
2023-04-28 21:51 ` Jeff Law
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).