* [PATCH] RISC-V: Update RVV integer compare simplification comments
@ 2023-05-08 8:54 pan2.li
2023-05-08 22:05 ` Jeff Law
0 siblings, 1 reply; 3+ messages in thread
From: pan2.li @ 2023-05-08 8:54 UTC (permalink / raw)
To: gcc-patches; +Cc: juzhe.zhong, kito.cheng, pan2.li, yanzhang.wang
From: Pan Li <pan2.li@intel.com>
The VMSET simplification RVV integer comparision has merged already.
This patch would like to update the comments for the cases that the
define_split will act on.
Signed-off-by: Pan Li <pan2.li@intel.com>
gcc/ChangeLog:
* config/riscv/vector.md: Add comments for simplifying to vmset.
Signed-off-by: Pan Li <pan2.li@intel.com>
---
gcc/config/riscv/vector.md | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/gcc/config/riscv/vector.md b/gcc/config/riscv/vector.md
index 9ccc0d6a513..9904d4ca5e2 100644
--- a/gcc/config/riscv/vector.md
+++ b/gcc/config/riscv/vector.md
@@ -8159,13 +8159,20 @@ (define_insn "@pred_indexed_<order>store<V64T:mode><V64I:mode>"
;; -----------------------------------------------------------------------------
;; ---- Integer Compare Instructions Simplification
;; -----------------------------------------------------------------------------
-;; Simplify to VMCLR.m Includes:
+;; Simplify OP(V, V) Instructions to VMCLR.m Includes:
;; - 1. VMSNE
;; - 2. VMSLT
;; - 3. VMSLTU
;; - 4. VMSGT
;; - 5. VMSGTU
;; -----------------------------------------------------------------------------
+;; Simplify OP(V, V) Instructions to VMSET.m Includes:
+;; - 1. VMSEQ
+;; - 2. VMSLE
+;; - 3. VMSLEU
+;; - 4. VMSGE
+;; - 5. VMSGEU
+;; -----------------------------------------------------------------------------
(define_split
[(set (match_operand:VB 0 "register_operand")
(if_then_else:VB
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] RISC-V: Update RVV integer compare simplification comments
2023-05-08 8:54 [PATCH] RISC-V: Update RVV integer compare simplification comments pan2.li
@ 2023-05-08 22:05 ` Jeff Law
2023-05-11 2:33 ` Li, Pan2
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Law @ 2023-05-08 22:05 UTC (permalink / raw)
To: pan2.li, gcc-patches; +Cc: juzhe.zhong, kito.cheng, yanzhang.wang
On 5/8/23 02:54, Pan Li via Gcc-patches wrote:
> From: Pan Li <pan2.li@intel.com>
>
> The VMSET simplification RVV integer comparision has merged already.
> This patch would like to update the comments for the cases that the
> define_split will act on.
>
> Signed-off-by: Pan Li <pan2.li@intel.com>
>
> gcc/ChangeLog:
>
> * config/riscv/vector.md: Add comments for simplifying to vmset.
OK. Thanks.
jeff
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] RISC-V: Update RVV integer compare simplification comments
2023-05-08 22:05 ` Jeff Law
@ 2023-05-11 2:33 ` Li, Pan2
0 siblings, 0 replies; 3+ messages in thread
From: Li, Pan2 @ 2023-05-11 2:33 UTC (permalink / raw)
To: Jeff Law, gcc-patches; +Cc: juzhe.zhong, kito.cheng, Wang, Yanzhang
Hi Jeff,
Thanks a lot. If no more comments, I can commit it to trunk later, 😊.
Pan
-----Original Message-----
From: Jeff Law <jeffreyalaw@gmail.com>
Sent: Tuesday, May 9, 2023 6:06 AM
To: Li, Pan2 <pan2.li@intel.com>; gcc-patches@gcc.gnu.org
Cc: juzhe.zhong@rivai.ai; kito.cheng@sifive.com; Wang, Yanzhang <yanzhang.wang@intel.com>
Subject: Re: [PATCH] RISC-V: Update RVV integer compare simplification comments
On 5/8/23 02:54, Pan Li via Gcc-patches wrote:
> From: Pan Li <pan2.li@intel.com>
>
> The VMSET simplification RVV integer comparision has merged already.
> This patch would like to update the comments for the cases that the
> define_split will act on.
>
> Signed-off-by: Pan Li <pan2.li@intel.com>
>
> gcc/ChangeLog:
>
> * config/riscv/vector.md: Add comments for simplifying to vmset.
OK. Thanks.
jeff
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-05-11 2:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-08 8:54 [PATCH] RISC-V: Update RVV integer compare simplification comments pan2.li
2023-05-08 22:05 ` Jeff Law
2023-05-11 2:33 ` Li, Pan2
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).