From: Qing Zhao <qing.zhao@oracle.com>
To: joseph@codesourcery.com, richard.guenther@gmail.com,
jakub@redhat.com, gcc-patches@gcc.gnu.org
Cc: keescook@chromium.org, siddhesh@gotplt.org, uecker@tugraz.at,
Qing Zhao <qing.zhao@oracle.com>
Subject: [V7][PATCH 0/2]Accept and Handle the case when a structure including a FAM nested in another structure
Date: Fri, 19 May 2023 20:49:46 +0000 [thread overview]
Message-ID: <20230519204948.237791-1-qing.zhao@oracle.com> (raw)
Hi,
This is the 7th version of the patch, which rebased on the latest trunk.
This is an important patch needed by Linux Kernel security project.
We already have an extensive discussion on this issue and I have went
through 6 revisions of the patches based on the discussion and resolved
all the comments and suggestions raised during the discussion;
compared to the 6th version, the major change are:
1. update the documentation to replace the mentioning of GCC14 with
GCC15.
2. update the documentation to replace the following wording:
"A structure or a union with a C99 flexible array member"
with:
"A structure containing a C99 flexible array member, or a union containing
such a structure,"
All others are the same as 6th version.
the 6th version are here:
https://gcc.gnu.org/pipermail/gcc-patches/2023-April/616312.html
https://gcc.gnu.org/pipermail/gcc-patches/2023-April/616313.html
https://gcc.gnu.org/pipermail/gcc-patches/2023-April/616314.html
Kees has tested the 6th version of the patch with Linux kernel, and everything
is good. relsolved many false positives for bounds checking.
Notes for the review history of these patches (2 patches)
1.The patch 1/2: Handle component_ref to a structre/union field including
flexible array member [PR101832]
The C front-end part has been approved by Joseph.
For the middle-end, most of the change has been reviewed by Richard
(and modified based on his comments and suggestions), except the change
in tree-object-size.cc.
2.The patch 2/2: Update documentation to clarify a GCC extension
This is basically a C FE and documentation change, I have updated it based
on previous comments and suggestions.
Joseph, could you review it to see whether this version is ready to go?
bootstrapped and regression tested on aarch64 and x86.
Okay for commit?
thanks a lot.
Qing
(for more details on the review history, I listed other important notes
below:
A. Richard Biener has reviewed the middle-end part of the first patch
and raised some comments for the 4th version:
https://gcc.gnu.org/pipermail/gcc-patches/2023-March/613643.html
I updated it with his suggestion and Sandra’s comments as 5th version:
https://gcc.gnu.org/pipermail/gcc-patches/2023-March/614100.html
B. The comments for the 5th version:
https://gcc.gnu.org/pipermail/gcc-patches/2023-March/614511.html
(In this one, Joseph approved the C FE change of the first patch).
https://gcc.gnu.org/pipermail/gcc-patches/2023-March/614514.html
(In this one, Joseph raised two comments on the documentation wordings
for the 2nd patch. And I updated based on his comment in the 6th version)
)
next reply other threads:[~2023-05-19 20:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-19 20:49 Qing Zhao [this message]
2023-05-19 20:49 ` [V7][PATCH 1/2] Handle component_ref to a structre/union field including flexible array member [PR101832] Qing Zhao
2023-05-19 23:11 ` Bernhard Reutner-Fischer
2023-05-24 14:09 ` Qing Zhao
2023-05-25 5:41 ` Bernhard Reutner-Fischer
2023-05-25 15:21 ` Qing Zhao
2023-05-19 20:49 ` [V7][PATCH 2/2] Update documentation to clarify a GCC extension [PR77650] Qing Zhao
2023-05-19 21:12 ` Joseph Myers
2023-05-24 13:05 ` Qing Zhao
2023-05-24 16:57 ` Qing Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230519204948.237791-1-qing.zhao@oracle.com \
--to=qing.zhao@oracle.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=joseph@codesourcery.com \
--cc=keescook@chromium.org \
--cc=richard.guenther@gmail.com \
--cc=siddhesh@gotplt.org \
--cc=uecker@tugraz.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).