From: Qing Zhao <qing.zhao@oracle.com>
To: joseph@codesourcery.com, richard.guenther@gmail.com,
jakub@redhat.com, gcc-patches@gcc.gnu.org
Cc: keescook@chromium.org, siddhesh@gotplt.org, uecker@tugraz.at,
isanbard@gmail.com, Qing Zhao <qing.zhao@oracle.com>
Subject: [V1][PATCH 3/3] Use the element_count attribute information in bound sanitizer[PR108896]
Date: Thu, 25 May 2023 16:14:50 +0000 [thread overview]
Message-ID: <20230525161450.3704901-4-qing.zhao@oracle.com> (raw)
In-Reply-To: <20230525161450.3704901-1-qing.zhao@oracle.com>
2023-05-17 Qing Zhao <qing.zhao@oracle.com>
gcc/c-family/ChangeLog:
PR C/108896
* c-ubsan.cc (ubsan_instrument_bounds): Use element_count attribute
information.
gcc/testsuite/ChangeLog:
PR C/108896
* gcc.dg/ubsan/flex-array-element-count-bounds.c: New test.
---
gcc/c-family/c-ubsan.cc | 16 +++++++
.../ubsan/flex-array-element-count-bounds.c | 46 +++++++++++++++++++
2 files changed, 62 insertions(+)
create mode 100644 gcc/testsuite/gcc.dg/ubsan/flex-array-element-count-bounds.c
diff --git a/gcc/c-family/c-ubsan.cc b/gcc/c-family/c-ubsan.cc
index cfb7cbf389c..04eb05b2c24 100644
--- a/gcc/c-family/c-ubsan.cc
+++ b/gcc/c-family/c-ubsan.cc
@@ -362,6 +362,10 @@ ubsan_instrument_bounds (location_t loc, tree array, tree *index,
{
tree type = TREE_TYPE (array);
tree domain = TYPE_DOMAIN (type);
+ /* whether the array ref is a flexible array member with valid element_count
+ attribute. */
+ bool fam_has_count_attr = false;
+ tree element_count = NULL_TREE;
if (domain == NULL_TREE)
return NULL_TREE;
@@ -375,6 +379,17 @@ ubsan_instrument_bounds (location_t loc, tree array, tree *index,
&& COMPLETE_TYPE_P (type)
&& integer_zerop (TYPE_SIZE (type)))
bound = build_int_cst (TREE_TYPE (TYPE_MIN_VALUE (domain)), -1);
+ /* If the array ref is to flexible array member field which has
+ element_count attribute. We can use the information from the
+ attribute as the bound to instrument the reference. */
+ else if ((element_count = component_ref_get_element_count (array))
+ != NULL_TREE)
+ {
+ fam_has_count_attr = true;
+ bound = fold_build2 (MINUS_EXPR, TREE_TYPE (element_count),
+ element_count,
+ build_int_cst (TREE_TYPE (element_count), 1));
+ }
else
return NULL_TREE;
}
@@ -387,6 +402,7 @@ ubsan_instrument_bounds (location_t loc, tree array, tree *index,
-fsanitize=bounds-strict. */
tree base = get_base_address (array);
if (!sanitize_flags_p (SANITIZE_BOUNDS_STRICT)
+ && !fam_has_count_attr
&& TREE_CODE (array) == COMPONENT_REF
&& base && (INDIRECT_REF_P (base) || TREE_CODE (base) == MEM_REF))
{
diff --git a/gcc/testsuite/gcc.dg/ubsan/flex-array-element-count-bounds.c b/gcc/testsuite/gcc.dg/ubsan/flex-array-element-count-bounds.c
new file mode 100644
index 00000000000..be5ee352144
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/ubsan/flex-array-element-count-bounds.c
@@ -0,0 +1,46 @@
+/* test the attribute element_count and its usage in
+ bounds sanitizer. */
+/* { dg-do run } */
+/* { dg-options "-fsanitize=bounds" } */
+
+#include <stdlib.h>
+
+struct flex {
+ int b;
+ int c[];
+} *array_flex;
+
+struct annotated {
+ int b;
+ int c[] __attribute__ ((element_count ("b")));
+} *array_annotated;
+
+void __attribute__((__noinline__)) setup (int normal_count, int annotated_count)
+{
+ array_flex
+ = (struct flex *)malloc (sizeof (struct flex)
+ + normal_count * sizeof (int));
+ array_flex->b = normal_count;
+
+ array_annotated
+ = (struct annotated *)malloc (sizeof (struct annotated)
+ + annotated_count * sizeof (int));
+ array_annotated->b = annotated_count;
+
+ return;
+}
+
+void __attribute__((__noinline__)) test (int normal_index, int annotated_index)
+{
+ array_flex->c[normal_index] = 1;
+ array_annotated->c[annotated_index] = 2;
+}
+
+int main(int argc, char *argv[])
+{
+ setup (10,10);
+ test (10,10);
+ return 0;
+}
+
+/* { dg-output "36:21: runtime error: index 10 out of bounds for type" } */
--
2.31.1
next prev parent reply other threads:[~2023-05-25 16:15 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-25 16:14 [V1][PATCH 0/3] New attribute "element_count" to annotate bounds for C99 FAM(PR108896) Qing Zhao
2023-05-25 16:14 ` [V1][PATCH 1/3] Provide element_count attribute to flexible array member field (PR108896) Qing Zhao
2023-05-25 21:02 ` Joseph Myers
2023-05-26 13:32 ` Qing Zhao
2023-05-26 18:15 ` Joseph Myers
2023-05-26 19:09 ` Qing Zhao
2023-06-07 19:59 ` Qing Zhao
2023-06-07 20:53 ` Joseph Myers
2023-06-07 21:32 ` Qing Zhao
2023-06-07 22:05 ` Joseph Myers
2023-06-08 13:06 ` Qing Zhao
2023-06-15 15:09 ` Qing Zhao
2023-06-15 16:55 ` Joseph Myers
2023-06-15 19:54 ` Qing Zhao
2023-06-15 22:48 ` Joseph Myers
2023-06-16 15:01 ` Qing Zhao
2023-06-16 7:21 ` Martin Uecker
2023-06-16 15:14 ` Qing Zhao
2023-06-16 16:21 ` Joseph Myers
2023-06-16 17:07 ` Martin Uecker
2023-06-16 20:20 ` Qing Zhao
2023-06-16 21:35 ` Joseph Myers
2023-06-20 19:40 ` Qing Zhao
2023-06-27 15:44 ` Qing Zhao
2023-05-25 16:14 ` [V1][PATCH 2/3] Use the element_count atribute info in builtin object size [PR108896] Qing Zhao
2023-05-27 10:20 ` Martin Uecker
2023-05-30 16:08 ` Qing Zhao
2023-05-25 16:14 ` Qing Zhao [this message]
2023-05-26 16:12 ` [V1][PATCH 0/3] New attribute "element_count" to annotate bounds for C99 FAM(PR108896) Kees Cook
2023-05-30 21:44 ` Qing Zhao
2023-05-26 20:40 ` Kees Cook
2023-05-30 15:43 ` Qing Zhao
2023-07-06 18:56 ` Qing Zhao
2023-07-06 21:10 ` Martin Uecker
2023-07-07 15:47 ` Qing Zhao
2023-07-07 20:21 ` Qing Zhao
2023-07-13 20:31 ` Kees Cook
2023-07-17 21:17 ` Qing Zhao
2023-07-17 23:40 ` Kees Cook
2023-07-18 15:37 ` Qing Zhao
2023-07-18 16:03 ` Martin Uecker
2023-07-18 16:25 ` Qing Zhao
2023-07-18 16:50 ` Martin Uecker
2023-07-18 18:53 ` Qing Zhao
2023-07-19 8:41 ` Martin Uecker
2023-07-19 16:16 ` Qing Zhao
2023-07-19 18:52 ` Qing Zhao
2023-07-31 20:14 ` Qing Zhao
2023-08-01 22:45 ` Kees Cook
2023-08-02 6:25 ` Martin Uecker
2023-08-02 15:02 ` Qing Zhao
2023-08-02 15:09 ` Qing Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230525161450.3704901-4-qing.zhao@oracle.com \
--to=qing.zhao@oracle.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=isanbard@gmail.com \
--cc=jakub@redhat.com \
--cc=joseph@codesourcery.com \
--cc=keescook@chromium.org \
--cc=richard.guenther@gmail.com \
--cc=siddhesh@gotplt.org \
--cc=uecker@tugraz.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).