From: Jiufu Guo <guojiufu@linux.ibm.com>
To: gcc-patches@gcc.gnu.org
Cc: rguenther@suse.de, jeffreyalaw@gmail.com,
richard.sandiford@arm.com, segher@kernel.crashing.org,
dje.gcc@gmail.com, linkw@gcc.gnu.org, bergner@linux.ibm.com,
guojiufu@linux.ibm.com
Subject: [PATCH] Make sure SCALAR_INT_MODE_P before invoke try_const_anchors
Date: Fri, 9 Jun 2023 13:28:47 +0800 [thread overview]
Message-ID: <20230609052847.2128612-1-guojiufu@linux.ibm.com> (raw)
Hi,
As checking the code, there is a "gcc_assert (SCALAR_INT_MODE_P (mode))"
in "try_const_anchors".
This assert seems correct because the function try_const_anchors cares
about integer values currently, and modes other than SCALAR_INT_MODE_P
are not needed to support.
This patch makes sure SCALAR_INT_MODE_P when calling try_const_anchors.
This patch is raised when drafting below one.
https://gcc.gnu.org/pipermail/gcc-patches/2022-October/603530.html.
With that patch, "{[%1:DI]=0;} stack_tie" with BLKmode runs into
try_const_anchors, and hits the assert/ice.
Boostrap and regtest pass on ppc64{,le} and x86_64.
Is this ok for trunk?
BR,
Jeff (Jiufu Guo)
gcc/ChangeLog:
* cse.cc (cse_insn): Add SCALAR_INT_MODE_P condition.
---
gcc/cse.cc | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/gcc/cse.cc b/gcc/cse.cc
index 2bb63ac4105..f213fa0faf7 100644
*** a/gcc/cse.cc
--- b/gcc/cse.cc
***************
*** 5003,5009 ****
if (targetm.const_anchor
&& !src_related
&& src_const
! && GET_CODE (src_const) == CONST_INT)
{
src_related = try_const_anchors (src_const, mode);
src_related_is_const_anchor = src_related != NULL_RTX;
- -
--- 5003,5010 ----
if (targetm.const_anchor
&& !src_related
&& src_const
! && GET_CODE (src_const) == CONST_INT
! && SCALAR_INT_MODE_P (mode))
{
src_related = try_const_anchors (src_const, mode);
src_related_is_const_anchor = src_related != NULL_RTX;
2.39.3
next reply other threads:[~2023-06-09 5:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 5:28 Jiufu Guo [this message]
2023-06-09 8:00 ` Richard Biener
2023-06-09 8:24 ` guojiufu
2023-06-09 8:33 ` Richard Sandiford
2023-06-09 8:51 ` Richard Biener
2023-06-09 9:10 ` Jiufu Guo
2023-06-09 10:57 ` Richard Biener
2023-06-09 12:43 ` Jiufu Guo
2023-06-09 12:52 ` Richard Biener
2023-06-12 5:44 ` Jiufu Guo
2023-06-12 8:02 ` Richard Biener
2023-06-12 11:20 ` Jiufu Guo
2023-06-12 20:54 ` Jeff Law
2023-06-13 2:34 ` Jiufu Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230609052847.2128612-1-guojiufu@linux.ibm.com \
--to=guojiufu@linux.ibm.com \
--cc=bergner@linux.ibm.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
--cc=linkw@gcc.gnu.org \
--cc=rguenther@suse.de \
--cc=richard.sandiford@arm.com \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).