From: "Pali Rohár" <pali@kernel.org>
To: Jonathan Yong <10walls@gmail.com>
Cc: LIU Hao <lh_mouse@126.com>,
gcc-patches@gcc.gnu.org, Jacek Caban <jacek@codeweavers.com>,
NightStrike <nightstrike@gmail.com>
Subject: Re: [PATCH] Add MinGW option -mcrtdll= for choosing C RunTime DLL library
Date: Tue, 13 Jun 2023 08:29:04 +0200 [thread overview]
Message-ID: <20230613062904.nh3tpyw4l2x7tkjd@pali> (raw)
In-Reply-To: <6d1db80b-703f-52e1-5860-8dd32572914f@gmail.com>
On Monday 12 June 2023 23:13:00 Jonathan Yong wrote:
> On 6/12/23 01:26, LIU Hao wrote:
> > 在 2023/6/12 07:08, Jonathan Yong 写道:
> > > +preprocessor is done. MinGW import library @code{msvcrt} is just a
> > > +symlink (or file copy) to the other MinGW CRT import library
> >
> > I suggest a change to this line:
> >
> > symlink to (or a copy of) another MinGW CRT import library
> >
> >
> > Also, as discussed earlier, linking against a CRT version different from
> > the value of `__MSVCRT_VERSION__` in _mingw.h is not officially
> > supported and should be warned. So maybe we can append a paragraph to
> > the documentation:
> >
> > Generally speaking, changing the CRT DLL requires recompiling
> > the entire MinGW CRT. This option is for experimental and testing
> > purposes only.
> >
> >
> >
>
> Pali, mind updating the patch?
>
Of course, just I'm not sure where to put the new paragraph. At the
beginning? Or after the text? What do you think?
next prev parent reply other threads:[~2023-06-13 6:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-27 10:14 Pali Rohár
2023-06-11 23:08 ` Jonathan Yong
2023-06-12 1:26 ` LIU Hao
2023-06-12 23:13 ` Jonathan Yong
2023-06-13 6:29 ` Pali Rohár [this message]
2023-06-13 8:40 ` LIU Hao
2023-06-14 16:09 ` [PATCH v2] " Pali Rohár
2023-06-16 13:18 ` Jonathan Yong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230613062904.nh3tpyw4l2x7tkjd@pali \
--to=pali@kernel.org \
--cc=10walls@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jacek@codeweavers.com \
--cc=lh_mouse@126.com \
--cc=nightstrike@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).