* [COMMITTED] bpf: fix generation of neg and neg32 BPF instructions
@ 2023-07-26 10:10 Jose E. Marchesi
0 siblings, 0 replies; only message in thread
From: Jose E. Marchesi @ 2023-07-26 10:10 UTC (permalink / raw)
To: gcc-patches
This patch fixes GCC to generate correct neg and neg32 instructions,
which do not take a source register operand. A couple of new tests
are added.
Tested in bpf-unknown-none.
gcc/ChangeLog
2023-07-26 Jose E. Marchesi <jose.marchesi@oracle.com>
* config/bpf/bpf.md: Fix neg{SI,DI}2 insn.
gcc/testsuite/ChangeLog
2023-07-26 Jose E. Marchesi <jose.marchesi@oracle.com>
* gcc.target/bpf/neg-1.c: New test.
* gcc.target/bpf/neg-pseudoc-1.c: Likewise.
---
gcc/config/bpf/bpf.md | 4 ++--
gcc/testsuite/gcc.target/bpf/neg-1.c | 14 ++++++++++++++
gcc/testsuite/gcc.target/bpf/neg-pseudoc-1.c | 14 ++++++++++++++
3 files changed, 30 insertions(+), 2 deletions(-)
create mode 100644 gcc/testsuite/gcc.target/bpf/neg-1.c
create mode 100644 gcc/testsuite/gcc.target/bpf/neg-pseudoc-1.c
diff --git a/gcc/config/bpf/bpf.md b/gcc/config/bpf/bpf.md
index 579a8213b09..1b5e1900d4f 100644
--- a/gcc/config/bpf/bpf.md
+++ b/gcc/config/bpf/bpf.md
@@ -142,9 +142,9 @@ (define_insn "sub<AM:mode>3"
;;; Negation
(define_insn "neg<AM:mode>2"
[(set (match_operand:AM 0 "register_operand" "=r,r")
- (neg:AM (match_operand:AM 1 "reg_or_imm_operand" " r,I")))]
+ (neg:AM (match_operand:AM 1 "reg_or_imm_operand" " 0,I")))]
""
- "{neg<msuffix>\t%0,%1|%w0 = -%w1}"
+ "{neg<msuffix>\t%0|%w0 = -%w1}"
[(set_attr "type" "<mtype>")])
;;; Multiplication
diff --git a/gcc/testsuite/gcc.target/bpf/neg-1.c b/gcc/testsuite/gcc.target/bpf/neg-1.c
new file mode 100644
index 00000000000..9ffb956859d
--- /dev/null
+++ b/gcc/testsuite/gcc.target/bpf/neg-1.c
@@ -0,0 +1,14 @@
+/* Check negr and negr32 instructions. */
+
+/* { dg-do compile } */
+/* { dg-options "-malu32" } */
+
+long foo (long a, long b, int x, int y)
+{
+ a = -b;
+ x = -y;
+ return a + x;
+}
+
+/* { dg-final { scan-assembler "neg\t%r.\n" } } */
+/* { dg-final { scan-assembler "neg32\t%r.\n" } } */
diff --git a/gcc/testsuite/gcc.target/bpf/neg-pseudoc-1.c b/gcc/testsuite/gcc.target/bpf/neg-pseudoc-1.c
new file mode 100644
index 00000000000..a4fb687f04a
--- /dev/null
+++ b/gcc/testsuite/gcc.target/bpf/neg-pseudoc-1.c
@@ -0,0 +1,14 @@
+/* Check negr and negr32 instructions (pseudoc asm dialect.) */
+
+/* { dg-do compile } */
+/* { dg-options "-malu32 -masm=pseudoc" } */
+
+long foo (long a, long b, int x, int y)
+{
+ a = -b;
+ x = -y;
+ return a + x;
+}
+
+/* { dg-final { scan-assembler {\t(r.) = -\1\n} } } */
+/* { dg-final { scan-assembler {\t(w.) = -\1\n} } } */
--
2.30.2
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-07-26 10:10 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-26 10:10 [COMMITTED] bpf: fix generation of neg and neg32 BPF instructions Jose E. Marchesi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).