* [COMMITTED] ada: Spurious error on class-wide preconditions
@ 2023-08-07 11:16 Marc Poulhiès
0 siblings, 0 replies; only message in thread
From: Marc Poulhiès @ 2023-08-07 11:16 UTC (permalink / raw)
To: gcc-patches; +Cc: Javier Miranda
From: Javier Miranda <miranda@adacore.com>
The compiler reports an spurious error when a class-wide precondition
expression has a class-wide type conversion.
gcc/ada/
* sem_res.adb (Resolve_Type_Conversion): Do not warn on conversion
to class-wide type on internally build helpers of class-wide
preconditions.
Tested on x86_64-pc-linux-gnu, committed on master.
---
gcc/ada/sem_res.adb | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/gcc/ada/sem_res.adb b/gcc/ada/sem_res.adb
index d3a0192fb09..ac0c60f5f22 100644
--- a/gcc/ada/sem_res.adb
+++ b/gcc/ada/sem_res.adb
@@ -12455,6 +12455,18 @@ package body Sem_Res is
elsif Orig_T = Base_Type (Standard_Long_Long_Integer) then
null;
+ -- Do not warn on conversion to class-wide type on helpers of
+ -- class-wide preconditions because in this context the warning
+ -- would be spurious (since the class-wide precondition has been
+ -- installed in the return statement of the helper, which has a
+ -- class-wide formal type instead of a regular tagged type).
+
+ elsif Is_Class_Wide_Type (Orig_T)
+ and then Is_Subprogram_Or_Generic_Subprogram (Current_Scope)
+ and then Present (Class_Preconditions_Subprogram (Current_Scope))
+ then
+ null;
+
-- Here we give the redundant conversion warning. If it is an
-- entity, give the name of the entity in the message. If not,
-- just mention the expression.
--
2.40.0
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-08-07 11:16 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-07 11:16 [COMMITTED] ada: Spurious error on class-wide preconditions Marc Poulhiès
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).