* [PATCH] arm: [MVE intrinsics] fix binary_acca_int32 and binary_acca_int64 shapes
@ 2023-08-14 18:01 Christophe Lyon
2023-08-22 10:01 ` Kyrylo Tkachov
0 siblings, 1 reply; 2+ messages in thread
From: Christophe Lyon @ 2023-08-14 18:01 UTC (permalink / raw)
To: gcc-patches, Kyrylo.Tkachov, richard.earnshaw, richard.sandiford
Cc: Christophe Lyon
Fix these two shapes, where we were failing to check the last
non-predicate parameter.
2023-08-14 Christophe Lyon <christophe.lyon@linaro.org>
gcc/
* config/arm/arm-mve-builtins-shapes.cc (binary_acca_int32): Fix loop bound.
(binary_acca_int64): Likewise.
---
gcc/config/arm/arm-mve-builtins-shapes.cc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gcc/config/arm/arm-mve-builtins-shapes.cc b/gcc/config/arm/arm-mve-builtins-shapes.cc
index 6d477a84330..1633084608e 100644
--- a/gcc/config/arm/arm-mve-builtins-shapes.cc
+++ b/gcc/config/arm/arm-mve-builtins-shapes.cc
@@ -455,7 +455,7 @@ struct binary_acca_int32_def : public overloaded_base<0>
|| (type = r.infer_vector_type (1)) == NUM_TYPE_SUFFIXES)
return error_mark_node;
- unsigned int last_arg = i;
+ unsigned int last_arg = i + 1;
for (i = 1; i < last_arg; i++)
if (!r.require_matching_vector_type (i, type))
return error_mark_node;
@@ -492,7 +492,7 @@ struct binary_acca_int64_def : public overloaded_base<0>
|| (type = r.infer_vector_type (1)) == NUM_TYPE_SUFFIXES)
return error_mark_node;
- unsigned int last_arg = i;
+ unsigned int last_arg = i + 1;
for (i = 1; i < last_arg; i++)
if (!r.require_matching_vector_type (i, type))
return error_mark_node;
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* RE: [PATCH] arm: [MVE intrinsics] fix binary_acca_int32 and binary_acca_int64 shapes
2023-08-14 18:01 [PATCH] arm: [MVE intrinsics] fix binary_acca_int32 and binary_acca_int64 shapes Christophe Lyon
@ 2023-08-22 10:01 ` Kyrylo Tkachov
0 siblings, 0 replies; 2+ messages in thread
From: Kyrylo Tkachov @ 2023-08-22 10:01 UTC (permalink / raw)
To: Christophe Lyon, gcc-patches, Richard Earnshaw, Richard Sandiford
Hi Christophe,
> -----Original Message-----
> From: Christophe Lyon <christophe.lyon@linaro.org>
> Sent: Monday, August 14, 2023 7:01 PM
> To: gcc-patches@gcc.gnu.org; Kyrylo Tkachov <Kyrylo.Tkachov@arm.com>;
> Richard Earnshaw <Richard.Earnshaw@arm.com>; Richard Sandiford
> <Richard.Sandiford@arm.com>
> Cc: Christophe Lyon <christophe.lyon@linaro.org>
> Subject: [PATCH] arm: [MVE intrinsics] fix binary_acca_int32 and
> binary_acca_int64 shapes
>
> Fix these two shapes, where we were failing to check the last
> non-predicate parameter.
Ok.
Thanks,
Kyrill
>
> 2023-08-14 Christophe Lyon <christophe.lyon@linaro.org>
>
> gcc/
> * config/arm/arm-mve-builtins-shapes.cc (binary_acca_int32): Fix
> loop bound.
> (binary_acca_int64): Likewise.
> ---
> gcc/config/arm/arm-mve-builtins-shapes.cc | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gcc/config/arm/arm-mve-builtins-shapes.cc b/gcc/config/arm/arm-
> mve-builtins-shapes.cc
> index 6d477a84330..1633084608e 100644
> --- a/gcc/config/arm/arm-mve-builtins-shapes.cc
> +++ b/gcc/config/arm/arm-mve-builtins-shapes.cc
> @@ -455,7 +455,7 @@ struct binary_acca_int32_def : public
> overloaded_base<0>
> || (type = r.infer_vector_type (1)) == NUM_TYPE_SUFFIXES)
> return error_mark_node;
>
> - unsigned int last_arg = i;
> + unsigned int last_arg = i + 1;
> for (i = 1; i < last_arg; i++)
> if (!r.require_matching_vector_type (i, type))
> return error_mark_node;
> @@ -492,7 +492,7 @@ struct binary_acca_int64_def : public
> overloaded_base<0>
> || (type = r.infer_vector_type (1)) == NUM_TYPE_SUFFIXES)
> return error_mark_node;
>
> - unsigned int last_arg = i;
> + unsigned int last_arg = i + 1;
> for (i = 1; i < last_arg; i++)
> if (!r.require_matching_vector_type (i, type))
> return error_mark_node;
> --
> 2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-08-22 10:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-14 18:01 [PATCH] arm: [MVE intrinsics] fix binary_acca_int32 and binary_acca_int64 shapes Christophe Lyon
2023-08-22 10:01 ` Kyrylo Tkachov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).