public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH] arm: [MVE intrinsics] Remove dead check for float type in parse_element_type
@ 2023-08-14 18:10 Christophe Lyon
  2023-08-22 10:02 ` Kyrylo Tkachov
  0 siblings, 1 reply; 2+ messages in thread
From: Christophe Lyon @ 2023-08-14 18:10 UTC (permalink / raw)
  To: gcc-patches, Kyrylo.Tkachov, richard.earnshaw, richard.sandiford
  Cc: Christophe Lyon

Fix a likely copy/paste error, where we check if ch == 'f' after we
checked it's either 's' or 'u'.

2023-08-14  Christophe Lyon  <christophe.lyon@linaro.org>

	gcc/
	* config/arm/arm-mve-builtins-shapes.cc (parse_element_type):
	Remove dead check.
---
 gcc/config/arm/arm-mve-builtins-shapes.cc | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gcc/config/arm/arm-mve-builtins-shapes.cc b/gcc/config/arm/arm-mve-builtins-shapes.cc
index 1633084608e..23eb9d0e69b 100644
--- a/gcc/config/arm/arm-mve-builtins-shapes.cc
+++ b/gcc/config/arm/arm-mve-builtins-shapes.cc
@@ -80,8 +80,7 @@ parse_element_type (const function_instance &instance, const char *&format)
 
   if (ch == 's' || ch == 'u')
     {
-      type_class_index tclass = (ch == 'f' ? TYPE_float
-				 : ch == 's' ? TYPE_signed
+      type_class_index tclass = (ch == 's' ? TYPE_signed
 				 : TYPE_unsigned);
       char *end;
       unsigned int bits = strtol (format, &end, 10);
-- 
2.34.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* RE: [PATCH] arm: [MVE intrinsics] Remove dead check for float type in parse_element_type
  2023-08-14 18:10 [PATCH] arm: [MVE intrinsics] Remove dead check for float type in parse_element_type Christophe Lyon
@ 2023-08-22 10:02 ` Kyrylo Tkachov
  0 siblings, 0 replies; 2+ messages in thread
From: Kyrylo Tkachov @ 2023-08-22 10:02 UTC (permalink / raw)
  To: Christophe Lyon, gcc-patches, Richard Earnshaw, Richard Sandiford



> -----Original Message-----
> From: Christophe Lyon <christophe.lyon@linaro.org>
> Sent: Monday, August 14, 2023 7:10 PM
> To: gcc-patches@gcc.gnu.org; Kyrylo Tkachov <Kyrylo.Tkachov@arm.com>;
> Richard Earnshaw <Richard.Earnshaw@arm.com>; Richard Sandiford
> <Richard.Sandiford@arm.com>
> Cc: Christophe Lyon <christophe.lyon@linaro.org>
> Subject: [PATCH] arm: [MVE intrinsics] Remove dead check for float type in
> parse_element_type
> 
> Fix a likely copy/paste error, where we check if ch == 'f' after we
> checked it's either 's' or 'u'.

Ok.
Thanks,
Kyrill

> 
> 2023-08-14  Christophe Lyon  <christophe.lyon@linaro.org>
> 
> 	gcc/
> 	* config/arm/arm-mve-builtins-shapes.cc (parse_element_type):
> 	Remove dead check.
> ---
>  gcc/config/arm/arm-mve-builtins-shapes.cc | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/gcc/config/arm/arm-mve-builtins-shapes.cc b/gcc/config/arm/arm-
> mve-builtins-shapes.cc
> index 1633084608e..23eb9d0e69b 100644
> --- a/gcc/config/arm/arm-mve-builtins-shapes.cc
> +++ b/gcc/config/arm/arm-mve-builtins-shapes.cc
> @@ -80,8 +80,7 @@ parse_element_type (const function_instance
> &instance, const char *&format)
> 
>    if (ch == 's' || ch == 'u')
>      {
> -      type_class_index tclass = (ch == 'f' ? TYPE_float
> -				 : ch == 's' ? TYPE_signed
> +      type_class_index tclass = (ch == 's' ? TYPE_signed
>  				 : TYPE_unsigned);
>        char *end;
>        unsigned int bits = strtol (format, &end, 10);
> --
> 2.34.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-08-22 10:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-14 18:10 [PATCH] arm: [MVE intrinsics] Remove dead check for float type in parse_element_type Christophe Lyon
2023-08-22 10:02 ` Kyrylo Tkachov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).