* [PATCH] testsuite: Fix gcc.target/arm/mve/mve_vadcq_vsbcq_fpscr_overwrite.c
@ 2023-09-08 8:43 Christophe Lyon
2023-09-14 9:13 ` Christophe Lyon
2023-10-24 14:00 ` Richard Earnshaw
0 siblings, 2 replies; 5+ messages in thread
From: Christophe Lyon @ 2023-09-08 8:43 UTC (permalink / raw)
To: gcc-patches, Kyrylo.Tkachov, richard.earnshaw, stam.markianos-wright
Cc: Christophe Lyon
The test was declaring 'int *carry;' and wrote to '*carry' without
initializing 'carry' first, leading to an attempt to write at address
zero, and a crash.
Fix by declaring 'int carry;' and passing '&carrry' instead of 'carry'
as parameter.
2023-09-08 Christophe Lyon <christophe.lyon@linaro.org>
gcc/testsuite/
* gcc.target/arm/mve/mve_vadcq_vsbcq_fpscr_overwrite.c: Fix.
---
.../arm/mve/mve_vadcq_vsbcq_fpscr_overwrite.c | 34 +++++++++----------
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/gcc/testsuite/gcc.target/arm/mve/mve_vadcq_vsbcq_fpscr_overwrite.c b/gcc/testsuite/gcc.target/arm/mve/mve_vadcq_vsbcq_fpscr_overwrite.c
index a8c6cce67c8..931c9d2f30b 100644
--- a/gcc/testsuite/gcc.target/arm/mve/mve_vadcq_vsbcq_fpscr_overwrite.c
+++ b/gcc/testsuite/gcc.target/arm/mve/mve_vadcq_vsbcq_fpscr_overwrite.c
@@ -7,7 +7,7 @@
volatile int32x4_t c1;
volatile uint32x4_t c2;
-int *carry;
+int carry;
int
main ()
@@ -21,45 +21,45 @@ main ()
uint32x4_t inactive2 = vcreateq_u32 (0, 0);
mve_pred16_t p = 0xFFFF;
- (*carry) = 0xFFFFFFFF;
+ carry = 0xFFFFFFFF;
__builtin_arm_set_fpscr_nzcvqc (0);
- c1 = vadcq (a1, b1, carry);
+ c1 = vadcq (a1, b1, &carry);
if (__builtin_arm_get_fpscr_nzcvqc () & !0x20000000)
__builtin_abort ();
- (*carry) = 0xFFFFFFFF;
+ carry = 0xFFFFFFFF;
__builtin_arm_set_fpscr_nzcvqc (0);
- c2 = vadcq (a2, b2, carry);
+ c2 = vadcq (a2, b2, &carry);
if (__builtin_arm_get_fpscr_nzcvqc () & !0x20000000)
__builtin_abort ();
- (*carry) = 0xFFFFFFFF;
+ carry = 0xFFFFFFFF;
__builtin_arm_set_fpscr_nzcvqc (0);
- c1 = vsbcq (a1, b1, carry);
+ c1 = vsbcq (a1, b1, &carry);
if (__builtin_arm_get_fpscr_nzcvqc () & !0x20000000)
__builtin_abort ();
- (*carry) = 0xFFFFFFFF;
+ carry = 0xFFFFFFFF;
__builtin_arm_set_fpscr_nzcvqc (0);
- c2 = vsbcq (a2, b2, carry);
+ c2 = vsbcq (a2, b2, &carry);
if (__builtin_arm_get_fpscr_nzcvqc () & !0x20000000)
__builtin_abort ();
- (*carry) = 0xFFFFFFFF;
+ carry = 0xFFFFFFFF;
__builtin_arm_set_fpscr_nzcvqc (0);
- c1 = vadcq_m (inactive1, a1, b1, carry, p);
+ c1 = vadcq_m (inactive1, a1, b1, &carry, p);
if (__builtin_arm_get_fpscr_nzcvqc () & !0x20000000)
__builtin_abort ();
- (*carry) = 0xFFFFFFFF;
+ carry = 0xFFFFFFFF;
__builtin_arm_set_fpscr_nzcvqc (0);
- c2 = vadcq_m (inactive2, a2, b2, carry, p);
+ c2 = vadcq_m (inactive2, a2, b2, &carry, p);
if (__builtin_arm_get_fpscr_nzcvqc () & !0x20000000)
__builtin_abort ();
- (*carry) = 0xFFFFFFFF;
+ carry = 0xFFFFFFFF;
__builtin_arm_set_fpscr_nzcvqc (0);
- c1 = vsbcq_m (inactive1, a1, b1, carry, p);
+ c1 = vsbcq_m (inactive1, a1, b1, &carry, p);
if (__builtin_arm_get_fpscr_nzcvqc () & !0x20000000)
__builtin_abort ();
- (*carry) = 0xFFFFFFFF;
+ carry = 0xFFFFFFFF;
__builtin_arm_set_fpscr_nzcvqc (0);
- c2 = vsbcq_m (inactive2, a2, b2, carry, p);
+ c2 = vsbcq_m (inactive2, a2, b2, &carry, p);
if (__builtin_arm_get_fpscr_nzcvqc () & !0x20000000)
__builtin_abort ();
--
2.34.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] testsuite: Fix gcc.target/arm/mve/mve_vadcq_vsbcq_fpscr_overwrite.c
2023-09-08 8:43 [PATCH] testsuite: Fix gcc.target/arm/mve/mve_vadcq_vsbcq_fpscr_overwrite.c Christophe Lyon
@ 2023-09-14 9:13 ` Christophe Lyon
2023-10-02 8:23 ` Christophe Lyon
2023-10-24 14:00 ` Richard Earnshaw
1 sibling, 1 reply; 5+ messages in thread
From: Christophe Lyon @ 2023-09-14 9:13 UTC (permalink / raw)
To: gcc-patches, Kyrylo.Tkachov, richard.earnshaw, stam.markianos-wright
[-- Attachment #1: Type: text/plain, Size: 3334 bytes --]
ping?
On Fri, 8 Sept 2023 at 10:43, Christophe Lyon <christophe.lyon@linaro.org>
wrote:
> The test was declaring 'int *carry;' and wrote to '*carry' without
> initializing 'carry' first, leading to an attempt to write at address
> zero, and a crash.
>
> Fix by declaring 'int carry;' and passing '&carrry' instead of 'carry'
> as parameter.
>
> 2023-09-08 Christophe Lyon <christophe.lyon@linaro.org>
>
> gcc/testsuite/
> * gcc.target/arm/mve/mve_vadcq_vsbcq_fpscr_overwrite.c: Fix.
> ---
> .../arm/mve/mve_vadcq_vsbcq_fpscr_overwrite.c | 34 +++++++++----------
> 1 file changed, 17 insertions(+), 17 deletions(-)
>
> diff --git
> a/gcc/testsuite/gcc.target/arm/mve/mve_vadcq_vsbcq_fpscr_overwrite.c
> b/gcc/testsuite/gcc.target/arm/mve/mve_vadcq_vsbcq_fpscr_overwrite.c
> index a8c6cce67c8..931c9d2f30b 100644
> --- a/gcc/testsuite/gcc.target/arm/mve/mve_vadcq_vsbcq_fpscr_overwrite.c
> +++ b/gcc/testsuite/gcc.target/arm/mve/mve_vadcq_vsbcq_fpscr_overwrite.c
> @@ -7,7 +7,7 @@
>
> volatile int32x4_t c1;
> volatile uint32x4_t c2;
> -int *carry;
> +int carry;
>
> int
> main ()
> @@ -21,45 +21,45 @@ main ()
> uint32x4_t inactive2 = vcreateq_u32 (0, 0);
>
> mve_pred16_t p = 0xFFFF;
> - (*carry) = 0xFFFFFFFF;
> + carry = 0xFFFFFFFF;
>
> __builtin_arm_set_fpscr_nzcvqc (0);
> - c1 = vadcq (a1, b1, carry);
> + c1 = vadcq (a1, b1, &carry);
> if (__builtin_arm_get_fpscr_nzcvqc () & !0x20000000)
> __builtin_abort ();
> - (*carry) = 0xFFFFFFFF;
> + carry = 0xFFFFFFFF;
> __builtin_arm_set_fpscr_nzcvqc (0);
> - c2 = vadcq (a2, b2, carry);
> + c2 = vadcq (a2, b2, &carry);
> if (__builtin_arm_get_fpscr_nzcvqc () & !0x20000000)
> __builtin_abort ();
> - (*carry) = 0xFFFFFFFF;
> + carry = 0xFFFFFFFF;
> __builtin_arm_set_fpscr_nzcvqc (0);
> - c1 = vsbcq (a1, b1, carry);
> + c1 = vsbcq (a1, b1, &carry);
> if (__builtin_arm_get_fpscr_nzcvqc () & !0x20000000)
> __builtin_abort ();
> - (*carry) = 0xFFFFFFFF;
> + carry = 0xFFFFFFFF;
> __builtin_arm_set_fpscr_nzcvqc (0);
> - c2 = vsbcq (a2, b2, carry);
> + c2 = vsbcq (a2, b2, &carry);
> if (__builtin_arm_get_fpscr_nzcvqc () & !0x20000000)
> __builtin_abort ();
> - (*carry) = 0xFFFFFFFF;
> + carry = 0xFFFFFFFF;
> __builtin_arm_set_fpscr_nzcvqc (0);
> - c1 = vadcq_m (inactive1, a1, b1, carry, p);
> + c1 = vadcq_m (inactive1, a1, b1, &carry, p);
> if (__builtin_arm_get_fpscr_nzcvqc () & !0x20000000)
> __builtin_abort ();
> - (*carry) = 0xFFFFFFFF;
> + carry = 0xFFFFFFFF;
> __builtin_arm_set_fpscr_nzcvqc (0);
> - c2 = vadcq_m (inactive2, a2, b2, carry, p);
> + c2 = vadcq_m (inactive2, a2, b2, &carry, p);
> if (__builtin_arm_get_fpscr_nzcvqc () & !0x20000000)
> __builtin_abort ();
> - (*carry) = 0xFFFFFFFF;
> + carry = 0xFFFFFFFF;
> __builtin_arm_set_fpscr_nzcvqc (0);
> - c1 = vsbcq_m (inactive1, a1, b1, carry, p);
> + c1 = vsbcq_m (inactive1, a1, b1, &carry, p);
> if (__builtin_arm_get_fpscr_nzcvqc () & !0x20000000)
> __builtin_abort ();
> - (*carry) = 0xFFFFFFFF;
> + carry = 0xFFFFFFFF;
> __builtin_arm_set_fpscr_nzcvqc (0);
> - c2 = vsbcq_m (inactive2, a2, b2, carry, p);
> + c2 = vsbcq_m (inactive2, a2, b2, &carry, p);
> if (__builtin_arm_get_fpscr_nzcvqc () & !0x20000000)
> __builtin_abort ();
>
> --
> 2.34.1
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] testsuite: Fix gcc.target/arm/mve/mve_vadcq_vsbcq_fpscr_overwrite.c
2023-09-14 9:13 ` Christophe Lyon
@ 2023-10-02 8:23 ` Christophe Lyon
2023-10-24 10:44 ` Christophe Lyon
0 siblings, 1 reply; 5+ messages in thread
From: Christophe Lyon @ 2023-10-02 8:23 UTC (permalink / raw)
To: gcc-patches, Kyrylo.Tkachov, richard.earnshaw, stam.markianos-wright
[-- Attachment #1: Type: text/plain, Size: 3560 bytes --]
ping? maybe this counts as obvious?
On Thu, 14 Sept 2023 at 11:13, Christophe Lyon <christophe.lyon@linaro.org>
wrote:
> ping?
>
> On Fri, 8 Sept 2023 at 10:43, Christophe Lyon <christophe.lyon@linaro.org>
> wrote:
>
>> The test was declaring 'int *carry;' and wrote to '*carry' without
>> initializing 'carry' first, leading to an attempt to write at address
>> zero, and a crash.
>>
>> Fix by declaring 'int carry;' and passing '&carrry' instead of 'carry'
>> as parameter.
>>
>> 2023-09-08 Christophe Lyon <christophe.lyon@linaro.org>
>>
>> gcc/testsuite/
>> * gcc.target/arm/mve/mve_vadcq_vsbcq_fpscr_overwrite.c: Fix.
>> ---
>> .../arm/mve/mve_vadcq_vsbcq_fpscr_overwrite.c | 34 +++++++++----------
>> 1 file changed, 17 insertions(+), 17 deletions(-)
>>
>> diff --git
>> a/gcc/testsuite/gcc.target/arm/mve/mve_vadcq_vsbcq_fpscr_overwrite.c
>> b/gcc/testsuite/gcc.target/arm/mve/mve_vadcq_vsbcq_fpscr_overwrite.c
>> index a8c6cce67c8..931c9d2f30b 100644
>> --- a/gcc/testsuite/gcc.target/arm/mve/mve_vadcq_vsbcq_fpscr_overwrite.c
>> +++ b/gcc/testsuite/gcc.target/arm/mve/mve_vadcq_vsbcq_fpscr_overwrite.c
>> @@ -7,7 +7,7 @@
>>
>> volatile int32x4_t c1;
>> volatile uint32x4_t c2;
>> -int *carry;
>> +int carry;
>>
>> int
>> main ()
>> @@ -21,45 +21,45 @@ main ()
>> uint32x4_t inactive2 = vcreateq_u32 (0, 0);
>>
>> mve_pred16_t p = 0xFFFF;
>> - (*carry) = 0xFFFFFFFF;
>> + carry = 0xFFFFFFFF;
>>
>> __builtin_arm_set_fpscr_nzcvqc (0);
>> - c1 = vadcq (a1, b1, carry);
>> + c1 = vadcq (a1, b1, &carry);
>> if (__builtin_arm_get_fpscr_nzcvqc () & !0x20000000)
>> __builtin_abort ();
>> - (*carry) = 0xFFFFFFFF;
>> + carry = 0xFFFFFFFF;
>> __builtin_arm_set_fpscr_nzcvqc (0);
>> - c2 = vadcq (a2, b2, carry);
>> + c2 = vadcq (a2, b2, &carry);
>> if (__builtin_arm_get_fpscr_nzcvqc () & !0x20000000)
>> __builtin_abort ();
>> - (*carry) = 0xFFFFFFFF;
>> + carry = 0xFFFFFFFF;
>> __builtin_arm_set_fpscr_nzcvqc (0);
>> - c1 = vsbcq (a1, b1, carry);
>> + c1 = vsbcq (a1, b1, &carry);
>> if (__builtin_arm_get_fpscr_nzcvqc () & !0x20000000)
>> __builtin_abort ();
>> - (*carry) = 0xFFFFFFFF;
>> + carry = 0xFFFFFFFF;
>> __builtin_arm_set_fpscr_nzcvqc (0);
>> - c2 = vsbcq (a2, b2, carry);
>> + c2 = vsbcq (a2, b2, &carry);
>> if (__builtin_arm_get_fpscr_nzcvqc () & !0x20000000)
>> __builtin_abort ();
>> - (*carry) = 0xFFFFFFFF;
>> + carry = 0xFFFFFFFF;
>> __builtin_arm_set_fpscr_nzcvqc (0);
>> - c1 = vadcq_m (inactive1, a1, b1, carry, p);
>> + c1 = vadcq_m (inactive1, a1, b1, &carry, p);
>> if (__builtin_arm_get_fpscr_nzcvqc () & !0x20000000)
>> __builtin_abort ();
>> - (*carry) = 0xFFFFFFFF;
>> + carry = 0xFFFFFFFF;
>> __builtin_arm_set_fpscr_nzcvqc (0);
>> - c2 = vadcq_m (inactive2, a2, b2, carry, p);
>> + c2 = vadcq_m (inactive2, a2, b2, &carry, p);
>> if (__builtin_arm_get_fpscr_nzcvqc () & !0x20000000)
>> __builtin_abort ();
>> - (*carry) = 0xFFFFFFFF;
>> + carry = 0xFFFFFFFF;
>> __builtin_arm_set_fpscr_nzcvqc (0);
>> - c1 = vsbcq_m (inactive1, a1, b1, carry, p);
>> + c1 = vsbcq_m (inactive1, a1, b1, &carry, p);
>> if (__builtin_arm_get_fpscr_nzcvqc () & !0x20000000)
>> __builtin_abort ();
>> - (*carry) = 0xFFFFFFFF;
>> + carry = 0xFFFFFFFF;
>> __builtin_arm_set_fpscr_nzcvqc (0);
>> - c2 = vsbcq_m (inactive2, a2, b2, carry, p);
>> + c2 = vsbcq_m (inactive2, a2, b2, &carry, p);
>> if (__builtin_arm_get_fpscr_nzcvqc () & !0x20000000)
>> __builtin_abort ();
>>
>> --
>> 2.34.1
>>
>>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] testsuite: Fix gcc.target/arm/mve/mve_vadcq_vsbcq_fpscr_overwrite.c
2023-10-02 8:23 ` Christophe Lyon
@ 2023-10-24 10:44 ` Christophe Lyon
0 siblings, 0 replies; 5+ messages in thread
From: Christophe Lyon @ 2023-10-24 10:44 UTC (permalink / raw)
To: GCC Patches, Kyrylo Tkachov, Richard Earnshaw, Stamatis Markianos-Wright
[-- Attachment #1: Type: text/plain, Size: 3874 bytes --]
Ping?
Le lun. 2 oct. 2023, 10:23, Christophe Lyon <christophe.lyon@linaro.org> a
écrit :
> ping? maybe this counts as obvious?
>
>
> On Thu, 14 Sept 2023 at 11:13, Christophe Lyon <christophe.lyon@linaro.org>
> wrote:
>
>> ping?
>>
>> On Fri, 8 Sept 2023 at 10:43, Christophe Lyon <christophe.lyon@linaro.org>
>> wrote:
>>
>>> The test was declaring 'int *carry;' and wrote to '*carry' without
>>> initializing 'carry' first, leading to an attempt to write at address
>>> zero, and a crash.
>>>
>>> Fix by declaring 'int carry;' and passing '&carrry' instead of 'carry'
>>> as parameter.
>>>
>>> 2023-09-08 Christophe Lyon <christophe.lyon@linaro.org>
>>>
>>> gcc/testsuite/
>>> * gcc.target/arm/mve/mve_vadcq_vsbcq_fpscr_overwrite.c: Fix.
>>> ---
>>> .../arm/mve/mve_vadcq_vsbcq_fpscr_overwrite.c | 34 +++++++++----------
>>> 1 file changed, 17 insertions(+), 17 deletions(-)
>>>
>>> diff --git
>>> a/gcc/testsuite/gcc.target/arm/mve/mve_vadcq_vsbcq_fpscr_overwrite.c
>>> b/gcc/testsuite/gcc.target/arm/mve/mve_vadcq_vsbcq_fpscr_overwrite.c
>>> index a8c6cce67c8..931c9d2f30b 100644
>>> --- a/gcc/testsuite/gcc.target/arm/mve/mve_vadcq_vsbcq_fpscr_overwrite.c
>>> +++ b/gcc/testsuite/gcc.target/arm/mve/mve_vadcq_vsbcq_fpscr_overwrite.c
>>> @@ -7,7 +7,7 @@
>>>
>>> volatile int32x4_t c1;
>>> volatile uint32x4_t c2;
>>> -int *carry;
>>> +int carry;
>>>
>>> int
>>> main ()
>>> @@ -21,45 +21,45 @@ main ()
>>> uint32x4_t inactive2 = vcreateq_u32 (0, 0);
>>>
>>> mve_pred16_t p = 0xFFFF;
>>> - (*carry) = 0xFFFFFFFF;
>>> + carry = 0xFFFFFFFF;
>>>
>>> __builtin_arm_set_fpscr_nzcvqc (0);
>>> - c1 = vadcq (a1, b1, carry);
>>> + c1 = vadcq (a1, b1, &carry);
>>> if (__builtin_arm_get_fpscr_nzcvqc () & !0x20000000)
>>> __builtin_abort ();
>>> - (*carry) = 0xFFFFFFFF;
>>> + carry = 0xFFFFFFFF;
>>> __builtin_arm_set_fpscr_nzcvqc (0);
>>> - c2 = vadcq (a2, b2, carry);
>>> + c2 = vadcq (a2, b2, &carry);
>>> if (__builtin_arm_get_fpscr_nzcvqc () & !0x20000000)
>>> __builtin_abort ();
>>> - (*carry) = 0xFFFFFFFF;
>>> + carry = 0xFFFFFFFF;
>>> __builtin_arm_set_fpscr_nzcvqc (0);
>>> - c1 = vsbcq (a1, b1, carry);
>>> + c1 = vsbcq (a1, b1, &carry);
>>> if (__builtin_arm_get_fpscr_nzcvqc () & !0x20000000)
>>> __builtin_abort ();
>>> - (*carry) = 0xFFFFFFFF;
>>> + carry = 0xFFFFFFFF;
>>> __builtin_arm_set_fpscr_nzcvqc (0);
>>> - c2 = vsbcq (a2, b2, carry);
>>> + c2 = vsbcq (a2, b2, &carry);
>>> if (__builtin_arm_get_fpscr_nzcvqc () & !0x20000000)
>>> __builtin_abort ();
>>> - (*carry) = 0xFFFFFFFF;
>>> + carry = 0xFFFFFFFF;
>>> __builtin_arm_set_fpscr_nzcvqc (0);
>>> - c1 = vadcq_m (inactive1, a1, b1, carry, p);
>>> + c1 = vadcq_m (inactive1, a1, b1, &carry, p);
>>> if (__builtin_arm_get_fpscr_nzcvqc () & !0x20000000)
>>> __builtin_abort ();
>>> - (*carry) = 0xFFFFFFFF;
>>> + carry = 0xFFFFFFFF;
>>> __builtin_arm_set_fpscr_nzcvqc (0);
>>> - c2 = vadcq_m (inactive2, a2, b2, carry, p);
>>> + c2 = vadcq_m (inactive2, a2, b2, &carry, p);
>>> if (__builtin_arm_get_fpscr_nzcvqc () & !0x20000000)
>>> __builtin_abort ();
>>> - (*carry) = 0xFFFFFFFF;
>>> + carry = 0xFFFFFFFF;
>>> __builtin_arm_set_fpscr_nzcvqc (0);
>>> - c1 = vsbcq_m (inactive1, a1, b1, carry, p);
>>> + c1 = vsbcq_m (inactive1, a1, b1, &carry, p);
>>> if (__builtin_arm_get_fpscr_nzcvqc () & !0x20000000)
>>> __builtin_abort ();
>>> - (*carry) = 0xFFFFFFFF;
>>> + carry = 0xFFFFFFFF;
>>> __builtin_arm_set_fpscr_nzcvqc (0);
>>> - c2 = vsbcq_m (inactive2, a2, b2, carry, p);
>>> + c2 = vsbcq_m (inactive2, a2, b2, &carry, p);
>>> if (__builtin_arm_get_fpscr_nzcvqc () & !0x20000000)
>>> __builtin_abort ();
>>>
>>> --
>>> 2.34.1
>>>
>>>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] testsuite: Fix gcc.target/arm/mve/mve_vadcq_vsbcq_fpscr_overwrite.c
2023-09-08 8:43 [PATCH] testsuite: Fix gcc.target/arm/mve/mve_vadcq_vsbcq_fpscr_overwrite.c Christophe Lyon
2023-09-14 9:13 ` Christophe Lyon
@ 2023-10-24 14:00 ` Richard Earnshaw
1 sibling, 0 replies; 5+ messages in thread
From: Richard Earnshaw @ 2023-10-24 14:00 UTC (permalink / raw)
To: Christophe Lyon, gcc-patches, Kyrylo.Tkachov, richard.earnshaw,
stam.markianos-wright
On 08/09/2023 09:43, Christophe Lyon via Gcc-patches wrote:
> The test was declaring 'int *carry;' and wrote to '*carry' without
> initializing 'carry' first, leading to an attempt to write at address
> zero, and a crash.
>
> Fix by declaring 'int carry;' and passing '&carrry' instead of 'carry'
> as parameter.
>
> 2023-09-08 Christophe Lyon <christophe.lyon@linaro.org>
>
> gcc/testsuite/
> * gcc.target/arm/mve/mve_vadcq_vsbcq_fpscr_overwrite.c: Fix.
OK.
R.
> ---
> .../arm/mve/mve_vadcq_vsbcq_fpscr_overwrite.c | 34 +++++++++----------
> 1 file changed, 17 insertions(+), 17 deletions(-)
>
> diff --git a/gcc/testsuite/gcc.target/arm/mve/mve_vadcq_vsbcq_fpscr_overwrite.c b/gcc/testsuite/gcc.target/arm/mve/mve_vadcq_vsbcq_fpscr_overwrite.c
> index a8c6cce67c8..931c9d2f30b 100644
> --- a/gcc/testsuite/gcc.target/arm/mve/mve_vadcq_vsbcq_fpscr_overwrite.c
> +++ b/gcc/testsuite/gcc.target/arm/mve/mve_vadcq_vsbcq_fpscr_overwrite.c
> @@ -7,7 +7,7 @@
>
> volatile int32x4_t c1;
> volatile uint32x4_t c2;
> -int *carry;
> +int carry;
>
> int
> main ()
> @@ -21,45 +21,45 @@ main ()
> uint32x4_t inactive2 = vcreateq_u32 (0, 0);
>
> mve_pred16_t p = 0xFFFF;
> - (*carry) = 0xFFFFFFFF;
> + carry = 0xFFFFFFFF;
>
> __builtin_arm_set_fpscr_nzcvqc (0);
> - c1 = vadcq (a1, b1, carry);
> + c1 = vadcq (a1, b1, &carry);
> if (__builtin_arm_get_fpscr_nzcvqc () & !0x20000000)
> __builtin_abort ();
> - (*carry) = 0xFFFFFFFF;
> + carry = 0xFFFFFFFF;
> __builtin_arm_set_fpscr_nzcvqc (0);
> - c2 = vadcq (a2, b2, carry);
> + c2 = vadcq (a2, b2, &carry);
> if (__builtin_arm_get_fpscr_nzcvqc () & !0x20000000)
> __builtin_abort ();
> - (*carry) = 0xFFFFFFFF;
> + carry = 0xFFFFFFFF;
> __builtin_arm_set_fpscr_nzcvqc (0);
> - c1 = vsbcq (a1, b1, carry);
> + c1 = vsbcq (a1, b1, &carry);
> if (__builtin_arm_get_fpscr_nzcvqc () & !0x20000000)
> __builtin_abort ();
> - (*carry) = 0xFFFFFFFF;
> + carry = 0xFFFFFFFF;
> __builtin_arm_set_fpscr_nzcvqc (0);
> - c2 = vsbcq (a2, b2, carry);
> + c2 = vsbcq (a2, b2, &carry);
> if (__builtin_arm_get_fpscr_nzcvqc () & !0x20000000)
> __builtin_abort ();
> - (*carry) = 0xFFFFFFFF;
> + carry = 0xFFFFFFFF;
> __builtin_arm_set_fpscr_nzcvqc (0);
> - c1 = vadcq_m (inactive1, a1, b1, carry, p);
> + c1 = vadcq_m (inactive1, a1, b1, &carry, p);
> if (__builtin_arm_get_fpscr_nzcvqc () & !0x20000000)
> __builtin_abort ();
> - (*carry) = 0xFFFFFFFF;
> + carry = 0xFFFFFFFF;
> __builtin_arm_set_fpscr_nzcvqc (0);
> - c2 = vadcq_m (inactive2, a2, b2, carry, p);
> + c2 = vadcq_m (inactive2, a2, b2, &carry, p);
> if (__builtin_arm_get_fpscr_nzcvqc () & !0x20000000)
> __builtin_abort ();
> - (*carry) = 0xFFFFFFFF;
> + carry = 0xFFFFFFFF;
> __builtin_arm_set_fpscr_nzcvqc (0);
> - c1 = vsbcq_m (inactive1, a1, b1, carry, p);
> + c1 = vsbcq_m (inactive1, a1, b1, &carry, p);
> if (__builtin_arm_get_fpscr_nzcvqc () & !0x20000000)
> __builtin_abort ();
> - (*carry) = 0xFFFFFFFF;
> + carry = 0xFFFFFFFF;
> __builtin_arm_set_fpscr_nzcvqc (0);
> - c2 = vsbcq_m (inactive2, a2, b2, carry, p);
> + c2 = vsbcq_m (inactive2, a2, b2, &carry, p);
> if (__builtin_arm_get_fpscr_nzcvqc () & !0x20000000)
> __builtin_abort ();
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-10-24 14:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-08 8:43 [PATCH] testsuite: Fix gcc.target/arm/mve/mve_vadcq_vsbcq_fpscr_overwrite.c Christophe Lyon
2023-09-14 9:13 ` Christophe Lyon
2023-10-02 8:23 ` Christophe Lyon
2023-10-24 10:44 ` Christophe Lyon
2023-10-24 14:00 ` Richard Earnshaw
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).