public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH v3] RISC-V: Elimilate warning in class vcreate
@ 2023-09-12  6:20 Li Xu
       [not found] ` <6F0A3219436CFE10+A8D0BFA5-258E-4B8A-8AF2-A076A1966EA6@rivai.ai>
  0 siblings, 1 reply; 2+ messages in thread
From: Li Xu @ 2023-09-12  6:20 UTC (permalink / raw)
  To: gcc-patches; +Cc: kito.cheng, palmer, juzhe.zhong, xuli

From: xuli <xuli1@eswincomputing.com>

The following is the content of class vcreate:
class vcreate : public function_base
{
public:
  gimple *fold (gimple_folder &f) const override
  {
    ....
  }

  rtx expand (function_expander &e) const override
  {
    return NULL_RTX;
  }
};

The warning caused is:
./riscv-gcc/gcc/config/riscv/riscv-vector-builtins-bases.cc:1719:34:
  warning: unused parameter 'e' [-Wunused-parameter]
  rtx expand (function_expander &e) const override
                                 ^

gcc/ChangeLog:

        * config/riscv/riscv-vector-builtins-bases.cc: remove unused parameter e and replace NULL_RTX with gcc_unreachable.
---
 gcc/config/riscv/riscv-vector-builtins-bases.cc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gcc/config/riscv/riscv-vector-builtins-bases.cc b/gcc/config/riscv/riscv-vector-builtins-bases.cc
index be3df2c1ea2..ee218a03017 100644
--- a/gcc/config/riscv/riscv-vector-builtins-bases.cc
+++ b/gcc/config/riscv/riscv-vector-builtins-bases.cc
@@ -1856,9 +1856,9 @@ public:
     return clobber;
   }
 
-  rtx expand (function_expander &e) const override
+  rtx expand (function_expander &) const override
   {
-    return NULL_RTX;
+    gcc_unreachable ();
   }
 };
 
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Re: [PATCH v3] RISC-V: Elimilate warning in class vcreate
       [not found] ` <6F0A3219436CFE10+A8D0BFA5-258E-4B8A-8AF2-A076A1966EA6@rivai.ai>
@ 2023-09-12  6:54   ` Li Xu
  0 siblings, 0 replies; 2+ messages in thread
From: Li Xu @ 2023-09-12  6:54 UTC (permalink / raw)
  To: juzhe.zhong; +Cc: gcc-patches, kito.cheng, palmer

Committed, thanks juzhe.
--------------
Li Xu
>lgtm
>---- Replied Message ----
>FromLi Xu<xuli1@eswincomputing.com>
>Date09/12/2023 14:20
>Togcc-patches@gcc.gnu.org<gcc-patches@gcc.gnu.org>
>Cckito.cheng@gmail.com<kito.cheng@gmail.com>,
>palmer@dabbelt.com<palmer@dabbelt.com>,
>juzhe.zhong@rivai.ai<juzhe.zhong@rivai.ai>,
>xuli<xuli1@eswincomputing.com>
>Subject[PATCH v3] RISC-V: Elimilate warning in class vcreate

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-09-12  6:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-12  6:20 [PATCH v3] RISC-V: Elimilate warning in class vcreate Li Xu
     [not found] ` <6F0A3219436CFE10+A8D0BFA5-258E-4B8A-8AF2-A076A1966EA6@rivai.ai>
2023-09-12  6:54   ` Li Xu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).