From: Arnaud Charlet <charlet@adacore.com>
To: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Cc: gcc-patches@gcc.gnu.org, Arnaud Charlet <charlet@adacore.com>,
Marc Poulhi??s <poulhies@adacore.com>
Subject: Re: [PATCH] ada: Fix Ada bootstrap on Solaris
Date: Mon, 4 Dec 2023 10:35:30 +0000 [thread overview]
Message-ID: <20231204103530.GA33733@adacore.com> (raw)
In-Reply-To: <yddleaas1e1.fsf@CeBiTec.Uni-Bielefeld.DE>
> The recent warning patches broke Ada bootstrap on Solaris:
>
> adaint.c: In function '__gnat_kill':
> adaint.c:3597:3: error: implicit declaration of function 'kill' [-Wimplicit-function-declaration]
> 3597 | kill (pid, sig);
> | ^~~~
>
> expect.c: In function '__gnat_expect_poll':
> expect.c:409:5: error: implicit declaration of function 'memset' [-Wimplicit-function-declaration]
> 409 | FD_ZERO (&rset);
> | ^~~~~~~
> expect.c:55:1: note: include '<string.h>' or provide a declaration of 'memset'
> 54 | #include <sys/wait.h>
> +++ |+#include <string.h>
> 55 | #endif
>
> I'm now including the necessary headers: <signal.h> for kill and
> <string.h> for memset. However, I found the GNAT C sources to be an
> incredible and hard to untangle maze: instead of using autoconf, they
> are generously sprinkled with deeply nested platform macros, so I may
> well have included the headers in an inappropriate place.
>
> Bootstrapped without regressions on i386-pc-solaris2.11,
> sparc-sun-solaris2.11, x86_64-pc-linux-gnu, and
> x86_64-apple-darwin23.1.0.
>
> Ok for trunk?
OK, thanks.
prev parent reply other threads:[~2023-12-04 10:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 10:33 Rainer Orth
2023-12-04 10:35 ` Arnaud Charlet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231204103530.GA33733@adacore.com \
--to=charlet@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=poulhies@adacore.com \
--cc=ro@CeBiTec.Uni-Bielefeld.DE \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).