* [PATCH] Fix disabling of year 2038 support on 32-bit hosts by default
@ 2024-02-06 20:55 Thiago Jung Bauermann
0 siblings, 0 replies; 3+ messages in thread
From: Thiago Jung Bauermann @ 2024-02-06 20:55 UTC (permalink / raw)
To: gcc-patches; +Cc: Luis Machado
Commit e5f2f7d901ee ("Disable year 2038 support on 32-bit hosts by
default") fixed a mismatch between 64-bit time_t in GDB and system headers
and 32-bit time_t in BFD.
However, since commit 862776f26a59 ("Finalized intl-update patches")
gnulib's year 2038 support has been accidentally re-enabled — causing
problems for 32-bit hosts again. The commit split baseargs into
{h,b}baseargs, but this hasn't been done for the code that handles
--disable-year2038.
This patch restores the intended behaviour. With this change, the number
of unexpected core files goes from 18 to 4.
Tested on armv8l-linux-gnueabihf.
Approved-By: Luis Machado <luis.machado@arm.com>
---
Hello,
Yesterday I committed this patch to the binutils-gdb repo. Since the
toplevel configure should be in sync between the 2 repos, could someone
please commit it to the gcc one? I don't have commit access.
configure | 3 ++-
configure.ac | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/configure b/configure
index 874966fb9f09..1da0e67c28fa 100755
--- a/configure
+++ b/configure
@@ -10301,7 +10301,8 @@ hbaseargs="$hbaseargs --disable-option-checking"
tbaseargs="$tbaseargs --disable-option-checking"
if test "$enable_year2038" = no; then
- baseargs="$baseargs --disable-year2038"
+ bbaseargs="$bbaseargs --disable-year2038"
+ hbaseargs="$hbaseargs --disable-year2038"
tbaseargs="$tbaseargs --disable-year2038"
fi
diff --git a/configure.ac b/configure.ac
index 4f34004a0726..fa508a0612a3 100644
--- a/configure.ac
+++ b/configure.ac
@@ -3420,7 +3420,8 @@ hbaseargs="$hbaseargs --disable-option-checking"
tbaseargs="$tbaseargs --disable-option-checking"
if test "$enable_year2038" = no; then
- baseargs="$baseargs --disable-year2038"
+ bbaseargs="$bbaseargs --disable-year2038"
+ hbaseargs="$hbaseargs --disable-year2038"
tbaseargs="$tbaseargs --disable-year2038"
fi
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix disabling of year 2038 support on 32-bit hosts by default
2024-02-05 18:57 ` Andrew Pinski
@ 2024-02-06 20:57 ` Thiago Jung Bauermann
0 siblings, 0 replies; 3+ messages in thread
From: Thiago Jung Bauermann @ 2024-02-06 20:57 UTC (permalink / raw)
To: Andrew Pinski; +Cc: Luis Machado, gdb-patches, binutils, GCC Patches
Hello Andrew,
Andrew Pinski <pinskia@gmail.com> writes:
> On Mon, Feb 5, 2024 at 10:40 AM Thiago Jung Bauermann
> <thiago.bauermann@linaro.org> wrote:
>>
>>
>> Thiago Jung Bauermann <thiago.bauermann@linaro.org> writes:
>>
>> > Hello Luis,
>> >
>> > Luis Machado <luis.machado@arm.com> writes:
>> >>
>> >> Approved-By: Luis Machado <luis.machado@arm.com>
>> >
>> > Thanks! Since this is a patch for the repository top-level, is your
>> > approval sufficient to commit the patch, or should I have approval from
>> > a binutils maintainer as well?
>>
>> Answering my own question: binutils/MAINTAINERS says:
>>
>> GDB global maintainers also have permission to commit and approve
>> patches to the top level files and to those parts of bfd files
>> primarily used by GDB.
>>
>> So pushed as commit 9c0aa4c53104.
>
> Please also submit/commit to the gcc trunk too since the toplevel
> configure should be insync between the 2 repos.
I don't have commit access to the gcc repo so I sent a patch to the
gcc-patches mailing list.
--
Thiago
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix disabling of year 2038 support on 32-bit hosts by default
[not found] ` <878r3ydabl.fsf@linaro.org>
@ 2024-02-05 18:57 ` Andrew Pinski
2024-02-06 20:57 ` Thiago Jung Bauermann
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Pinski @ 2024-02-05 18:57 UTC (permalink / raw)
To: Thiago Jung Bauermann; +Cc: Luis Machado, gdb-patches, binutils, GCC Patches
On Mon, Feb 5, 2024 at 10:40 AM Thiago Jung Bauermann
<thiago.bauermann@linaro.org> wrote:
>
>
> Thiago Jung Bauermann <thiago.bauermann@linaro.org> writes:
>
> > Hello Luis,
> >
> > Luis Machado <luis.machado@arm.com> writes:
> >>
> >> Approved-By: Luis Machado <luis.machado@arm.com>
> >
> > Thanks! Since this is a patch for the repository top-level, is your
> > approval sufficient to commit the patch, or should I have approval from
> > a binutils maintainer as well?
>
> Answering my own question: binutils/MAINTAINERS says:
>
> GDB global maintainers also have permission to commit and approve
> patches to the top level files and to those parts of bfd files
> primarily used by GDB.
>
> So pushed as commit 9c0aa4c53104.
Please also submit/commit to the gcc trunk too since the toplevel
configure should be insync between the 2 repos.
Thanks,
Andrew
>
> --
> Thiago
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-06 20:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-06 20:55 [PATCH] Fix disabling of year 2038 support on 32-bit hosts by default Thiago Jung Bauermann
[not found] <20240203031408.137939-1-thiago.bauermann@linaro.org>
[not found] ` <0dd8e039-d15f-4d79-be71-587b0758304f@arm.com>
[not found] ` <87cytadds5.fsf@linaro.org>
[not found] ` <878r3ydabl.fsf@linaro.org>
2024-02-05 18:57 ` Andrew Pinski
2024-02-06 20:57 ` Thiago Jung Bauermann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).