From: David Malcolm <dmalcolm@redhat.com>
To: Tim Lange <mail@tim-lange.me>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH v2] analyzer: support for symbolic values in the out-of-bounds checker [PR106625]
Date: Wed, 07 Sep 2022 17:13:22 -0400 [thread overview]
Message-ID: <20f04485e335a7d56019d5301d5c3a6b76ef40e9.camel@redhat.com> (raw)
In-Reply-To: <20220907155107.31300-1-mail@tim-lange.me>
On Wed, 2022-09-07 at 17:51 +0200, Tim Lange wrote:
> Hi Dave,
>
> while re-reading that patch, I noticed a small mistake. I accidently
> did
> not move the op == PLUS_EXPR or MULT_EXPR guard in
> symbolic_greater_than
> when implementing the "eliminate operands on both sides" feature,
> which
> lead to the old patch also eliminating operands on both sides if the
> operator decreases the value, which is obviously wrong.
>
> I moved the guard outside and added test coverage for this in
> symbolic-gt-1.c. The patch passed the regrtests with the fix
> included.
>
> I assume it is still okay for trunk?
Yes it is - thanks for the updated patch.
Dave
prev parent reply other threads:[~2022-09-07 21:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-05 21:16 [PATCH][WIP?] " Tim Lange
2022-09-06 2:22 ` David Malcolm
2022-09-07 15:51 ` [PATCH v2] " Tim Lange
2022-09-07 21:13 ` David Malcolm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20f04485e335a7d56019d5301d5c3a6b76ef40e9.camel@redhat.com \
--to=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=mail@tim-lange.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).