From: Eric Botcazou <botcazou@adacore.com>
To: Roger Sayle <roger@nextmovesoftware.com>
Cc: gcc-patches@gcc.gnu.org, 'Jeff Law' <jeffreyalaw@gmail.com>,
'Tamar Christina' <tnfchris@gcc.gnu.org>
Subject: Re: [PATCH] PR middle-end/105874: Use EXPAND_MEMORY to fix ada bootstrap.
Date: Wed, 08 Jun 2022 16:13:20 +0200 [thread overview]
Message-ID: <21519641.EfDdHjke4D@fomalhaut> (raw)
In-Reply-To: <07f101d87b38$8c2b42a0$a481c7e0$@nextmovesoftware.com>
> The fix is to ensure that we call expand_expr with EXPAND_MEMORY
> when processing the VAR_DECL's returned by get_inner_reference.
>
> This patch has been tested on x86_64-pc-linux-gnu with make bootstrap
> and make -k check (with no new failures), but also with
> --enable-languages="ada" where it allows the bootstrap to finish,
> and with no unexpected failures in the acats and gnat testsuites.
> Ok for mainline?
Yes, thanks (modulo the nit in the ChangeLog).
> 2022-06-08 Roger Sayle <roger@nextmovesoftware.com>
>
> gcc/ChangeLog
> PR middle-end/105874
> * gcc/expr.cc (expand_expr_real_1) <normal_inner_ref>: New local
> variable tem_modifier for calculating the expand_modifier enum to
> use for expanding tem. If tem is a VAR_DECL, use EXPAND_MEMORY.
gcc/ prefix to be stripped
--
Eric Botcazou
next prev parent reply other threads:[~2022-06-08 14:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-08 13:06 Roger Sayle
2022-06-08 14:13 ` Eric Botcazou [this message]
2022-06-13 10:42 ` Richard Biener
2022-06-13 11:29 ` Eric Botcazou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21519641.EfDdHjke4D@fomalhaut \
--to=botcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
--cc=roger@nextmovesoftware.com \
--cc=tnfchris@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).