public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH] mips: testsuite: enforce -ffat-lto-objects for pr102024-4.c
@ 2022-04-06 22:38 Xi Ruoyao
  2022-04-11 15:13 ` Richard Sandiford
  0 siblings, 1 reply; 2+ messages in thread
From: Xi Ruoyao @ 2022-04-06 22:38 UTC (permalink / raw)
  To: gcc-patches; +Cc: Richard Sandiford, Jakub Jelinek, YunQiang Su

Another brown paper bag fix for MIPS :(.

This failure was not detected running mips.exp=pr102024-* with a cross
compiler, so I just spotted it now running the test natively.

---

The body of func is optimized away with -flto -fno-fat-lto-objects, so
the psABI inform is not emitted, causing a test failure.

gcc/testsuite/

	* gcc.target/mips/pr102024-4.c (dg-options): Add
	-ffat-lto-objects.
---
 gcc/testsuite/gcc.target/mips/pr102024-4.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/testsuite/gcc.target/mips/pr102024-4.c b/gcc/testsuite/gcc.target/mips/pr102024-4.c
index 2147cc769d0..ea49e890ee5 100644
--- a/gcc/testsuite/gcc.target/mips/pr102024-4.c
+++ b/gcc/testsuite/gcc.target/mips/pr102024-4.c
@@ -1,5 +1,5 @@
 // { dg-do compile }
-// { dg-options "-mabi=64 -mhard-float" }
+// { dg-options "-mabi=64 -mhard-float -ffat-lto-objects" }
 
 struct __attribute__((aligned(16))) test {
   int x[0];
-- 
2.35.1



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] mips: testsuite: enforce -ffat-lto-objects for pr102024-4.c
  2022-04-06 22:38 [PATCH] mips: testsuite: enforce -ffat-lto-objects for pr102024-4.c Xi Ruoyao
@ 2022-04-11 15:13 ` Richard Sandiford
  0 siblings, 0 replies; 2+ messages in thread
From: Richard Sandiford @ 2022-04-11 15:13 UTC (permalink / raw)
  To: Xi Ruoyao; +Cc: gcc-patches, Jakub Jelinek, YunQiang Su

Xi Ruoyao <xry111@mengyan1223.wang> writes:
> Another brown paper bag fix for MIPS :(.
>
> This failure was not detected running mips.exp=pr102024-* with a cross
> compiler, so I just spotted it now running the test natively.
>
> ---
>
> The body of func is optimized away with -flto -fno-fat-lto-objects, so
> the psABI inform is not emitted, causing a test failure.
>
> gcc/testsuite/
>
> 	* gcc.target/mips/pr102024-4.c (dg-options): Add
> 	-ffat-lto-objects.

OK, thanks.

Richard

> ---
>  gcc/testsuite/gcc.target/mips/pr102024-4.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/testsuite/gcc.target/mips/pr102024-4.c b/gcc/testsuite/gcc.target/mips/pr102024-4.c
> index 2147cc769d0..ea49e890ee5 100644
> --- a/gcc/testsuite/gcc.target/mips/pr102024-4.c
> +++ b/gcc/testsuite/gcc.target/mips/pr102024-4.c
> @@ -1,5 +1,5 @@
>  // { dg-do compile }
> -// { dg-options "-mabi=64 -mhard-float" }
> +// { dg-options "-mabi=64 -mhard-float -ffat-lto-objects" }
>  
>  struct __attribute__((aligned(16))) test {
>    int x[0];

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-04-11 15:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-06 22:38 [PATCH] mips: testsuite: enforce -ffat-lto-objects for pr102024-4.c Xi Ruoyao
2022-04-11 15:13 ` Richard Sandiford

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).