* [PATCH] LoongArch: Remove constraint z from movsi_internal
@ 2023-12-15 12:56 Xi Ruoyao
2024-01-16 5:34 ` Ping: " Xi Ruoyao
0 siblings, 1 reply; 5+ messages in thread
From: Xi Ruoyao @ 2023-12-15 12:56 UTC (permalink / raw)
To: gcc-patches; +Cc: chenglulu, i, xuchenghua, Jiahao Xu, Xi Ruoyao
We don't allow SImode in FCC, so constraint z is never really used
here.
gcc/ChangeLog:
* config/loongarch/loongarch.md (movsi_internal): Remove
constraint z.
---
Bootstrapped and regtested on loongarch64-linux-gnu. Ok for trunk?
gcc/config/loongarch/loongarch.md | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/gcc/config/loongarch/loongarch.md b/gcc/config/loongarch/loongarch.md
index a5d0dcd65fe..404a663c1a6 100644
--- a/gcc/config/loongarch/loongarch.md
+++ b/gcc/config/loongarch/loongarch.md
@@ -2108,8 +2108,8 @@ (define_expand "movsi"
})
(define_insn_and_split "*movsi_internal"
- [(set (match_operand:SI 0 "nonimmediate_operand" "=r,r,r,w,*f,f,*r,*m,*r,*z")
- (match_operand:SI 1 "move_operand" "r,Yd,w,rJ,*r*J,m,*f,*f,*z,*r"))]
+ [(set (match_operand:SI 0 "nonimmediate_operand" "=r,r,r,w,*f,f,*r,*m")
+ (match_operand:SI 1 "move_operand" "r,Yd,w,rJ,*r*J,m,*f,*f"))]
"(register_operand (operands[0], SImode)
|| reg_or_0_operand (operands[1], SImode))"
{ return loongarch_output_move (operands[0], operands[1]); }
@@ -2122,7 +2122,7 @@ (define_insn_and_split "*movsi_internal"
DONE;
}
"
- [(set_attr "move_type" "move,const,load,store,mgtf,fpload,mftg,fpstore,mftg,mgtf")
+ [(set_attr "move_type" "move,const,load,store,mgtf,fpload,mftg,fpstore")
(set_attr "mode" "SI")])
;; 16-bit Integer moves
--
2.43.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* Ping: [PATCH] LoongArch: Remove constraint z from movsi_internal
2023-12-15 12:56 [PATCH] LoongArch: Remove constraint z from movsi_internal Xi Ruoyao
@ 2024-01-16 5:34 ` Xi Ruoyao
2024-01-16 6:16 ` chenglulu
0 siblings, 1 reply; 5+ messages in thread
From: Xi Ruoyao @ 2024-01-16 5:34 UTC (permalink / raw)
To: gcc-patches; +Cc: chenglulu, i, xuchenghua, Jiahao Xu
Ping.
On Fri, 2023-12-15 at 20:56 +0800, Xi Ruoyao wrote:
> We don't allow SImode in FCC, so constraint z is never really used
> here.
>
> gcc/ChangeLog:
>
> * config/loongarch/loongarch.md (movsi_internal): Remove
> constraint z.
> ---
>
> Bootstrapped and regtested on loongarch64-linux-gnu. Ok for trunk?
>
> gcc/config/loongarch/loongarch.md | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/gcc/config/loongarch/loongarch.md b/gcc/config/loongarch/loongarch.md
> index a5d0dcd65fe..404a663c1a6 100644
> --- a/gcc/config/loongarch/loongarch.md
> +++ b/gcc/config/loongarch/loongarch.md
> @@ -2108,8 +2108,8 @@ (define_expand "movsi"
> })
>
> (define_insn_and_split "*movsi_internal"
> - [(set (match_operand:SI 0 "nonimmediate_operand" "=r,r,r,w,*f,f,*r,*m,*r,*z")
> - (match_operand:SI 1 "move_operand" "r,Yd,w,rJ,*r*J,m,*f,*f,*z,*r"))]
> + [(set (match_operand:SI 0 "nonimmediate_operand" "=r,r,r,w,*f,f,*r,*m")
> + (match_operand:SI 1 "move_operand" "r,Yd,w,rJ,*r*J,m,*f,*f"))]
> "(register_operand (operands[0], SImode)
> || reg_or_0_operand (operands[1], SImode))"
> { return loongarch_output_move (operands[0], operands[1]); }
> @@ -2122,7 +2122,7 @@ (define_insn_and_split "*movsi_internal"
> DONE;
> }
> "
> - [(set_attr "move_type" "move,const,load,store,mgtf,fpload,mftg,fpstore,mftg,mgtf")
> + [(set_attr "move_type" "move,const,load,store,mgtf,fpload,mftg,fpstore")
> (set_attr "mode" "SI")])
>
> ;; 16-bit Integer moves
--
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Ping: [PATCH] LoongArch: Remove constraint z from movsi_internal
2024-01-16 5:34 ` Ping: " Xi Ruoyao
@ 2024-01-16 6:16 ` chenglulu
2024-01-16 6:20 ` Xi Ruoyao
0 siblings, 1 reply; 5+ messages in thread
From: chenglulu @ 2024-01-16 6:16 UTC (permalink / raw)
To: Xi Ruoyao, gcc-patches; +Cc: i, xuchenghua, Jiahao Xu
在 2024/1/16 下午1:34, Xi Ruoyao 写道:
> Ping.
>
> On Fri, 2023-12-15 at 20:56 +0800, Xi Ruoyao wrote:
>> We don't allow SImode in FCC, so constraint z is never really used
>> here.
>>
>> gcc/ChangeLog:
>>
>> * config/loongarch/loongarch.md (movsi_internal): Remove
>> constraint z.
>> ---
>>
>> Bootstrapped and regtested on loongarch64-linux-gnu. Ok for trunk?
>>
>> gcc/config/loongarch/loongarch.md | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/gcc/config/loongarch/loongarch.md b/gcc/config/loongarch/loongarch.md
>> index a5d0dcd65fe..404a663c1a6 100644
>> --- a/gcc/config/loongarch/loongarch.md
>> +++ b/gcc/config/loongarch/loongarch.md
>> @@ -2108,8 +2108,8 @@ (define_expand "movsi"
>> })
>>
>> (define_insn_and_split "*movsi_internal"
>> - [(set (match_operand:SI 0 "nonimmediate_operand" "=r,r,r,w,*f,f,*r,*m,*r,*z")
>> - (match_operand:SI 1 "move_operand" "r,Yd,w,rJ,*r*J,m,*f,*f,*z,*r"))]
>> + [(set (match_operand:SI 0 "nonimmediate_operand" "=r,r,r,w,*f,f,*r,*m")
>> + (match_operand:SI 1 "move_operand" "r,Yd,w,rJ,*r*J,m,*f,*f"))]
>> "(register_operand (operands[0], SImode)
>> || reg_or_0_operand (operands[1], SImode))"
>> { return loongarch_output_move (operands[0], operands[1]); }
>> @@ -2122,7 +2122,7 @@ (define_insn_and_split "*movsi_internal"
>> DONE;
>> }
>> "
>> - [(set_attr "move_type" "move,const,load,store,mgtf,fpload,mftg,fpstore,mftg,mgtf")
>> + [(set_attr "move_type" "move,const,load,store,mgtf,fpload,mftg,fpstore")
>> (set_attr "mode" "SI")])
>>
Sorry, I have a question. If this place is removed, is movgr2fr in the
loongarch_output_move function no longer needed?
>> ;; 16-bit Integer moves
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Ping: [PATCH] LoongArch: Remove constraint z from movsi_internal
2024-01-16 6:16 ` chenglulu
@ 2024-01-16 6:20 ` Xi Ruoyao
2024-01-16 6:23 ` chenglulu
0 siblings, 1 reply; 5+ messages in thread
From: Xi Ruoyao @ 2024-01-16 6:20 UTC (permalink / raw)
To: chenglulu, gcc-patches; +Cc: i, xuchenghua, Jiahao Xu
On Tue, 2024-01-16 at 14:16 +0800, chenglulu wrote:
>
>
> 在 2024/1/16 下午1:34, Xi Ruoyao 写道:
> > Ping.
> >
> > On Fri, 2023-12-15 at 20:56 +0800, Xi Ruoyao wrote:
> > > We don't allow SImode in FCC, so constraint z is never really used
> > > here.
> > >
> > > gcc/ChangeLog:
> > >
> > > * config/loongarch/loongarch.md (movsi_internal): Remove
> > > constraint z.
> > > ---
> > >
> > > Bootstrapped and regtested on loongarch64-linux-gnu. Ok for trunk?
> > >
> > > gcc/config/loongarch/loongarch.md | 6 +++---
> > > 1 file changed, 3 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/gcc/config/loongarch/loongarch.md b/gcc/config/loongarch/loongarch.md
> > > index a5d0dcd65fe..404a663c1a6 100644
> > > --- a/gcc/config/loongarch/loongarch.md
> > > +++ b/gcc/config/loongarch/loongarch.md
> > > @@ -2108,8 +2108,8 @@ (define_expand "movsi"
> > > })
> > >
> > > (define_insn_and_split "*movsi_internal"
> > > - [(set (match_operand:SI 0 "nonimmediate_operand" "=r,r,r,w,*f,f,*r,*m,*r,*z")
> > > - (match_operand:SI 1 "move_operand" "r,Yd,w,rJ,*r*J,m,*f,*f,*z,*r"))]
> > > + [(set (match_operand:SI 0 "nonimmediate_operand" "=r,r,r,w,*f,f,*r,*m")
> > > + (match_operand:SI 1 "move_operand" "r,Yd,w,rJ,*r*J,m,*f,*f"))]
> > > "(register_operand (operands[0], SImode)
> > > || reg_or_0_operand (operands[1], SImode))"
> > > { return loongarch_output_move (operands[0], operands[1]); }
> > > @@ -2122,7 +2122,7 @@ (define_insn_and_split "*movsi_internal"
> > > DONE;
> > > }
> > > "
> > > - [(set_attr "move_type" "move,const,load,store,mgtf,fpload,mftg,fpstore,mftg,mgtf")
> > > + [(set_attr "move_type" "move,const,load,store,mgtf,fpload,mftg,fpstore")
> > > (set_attr "mode" "SI")])
> > >
> Sorry, I have a question. If this place is removed, is movgr2fr in the
> loongarch_output_move function no longer needed?
It's needed for moving SImode into FPR. "z" is FCC_REGS, not FP_REGS.
I cannot see movgr2cf or movfr2cf in loongarch_output_move.
--
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Ping: [PATCH] LoongArch: Remove constraint z from movsi_internal
2024-01-16 6:20 ` Xi Ruoyao
@ 2024-01-16 6:23 ` chenglulu
0 siblings, 0 replies; 5+ messages in thread
From: chenglulu @ 2024-01-16 6:23 UTC (permalink / raw)
To: Xi Ruoyao, gcc-patches; +Cc: i, xuchenghua, Jiahao Xu
在 2024/1/16 下午2:20, Xi Ruoyao 写道:
> On Tue, 2024-01-16 at 14:16 +0800, chenglulu wrote:
>>
>> 在 2024/1/16 下午1:34, Xi Ruoyao 写道:
>>> Ping.
>>>
>>> On Fri, 2023-12-15 at 20:56 +0800, Xi Ruoyao wrote:
>>>> We don't allow SImode in FCC, so constraint z is never really used
>>>> here.
>>>>
>>>> gcc/ChangeLog:
>>>>
>>>> * config/loongarch/loongarch.md (movsi_internal): Remove
>>>> constraint z.
>>>> ---
>>>>
>>>> Bootstrapped and regtested on loongarch64-linux-gnu. Ok for trunk?
>>>>
>>>> gcc/config/loongarch/loongarch.md | 6 +++---
>>>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>>>
>>>> diff --git a/gcc/config/loongarch/loongarch.md b/gcc/config/loongarch/loongarch.md
>>>> index a5d0dcd65fe..404a663c1a6 100644
>>>> --- a/gcc/config/loongarch/loongarch.md
>>>> +++ b/gcc/config/loongarch/loongarch.md
>>>> @@ -2108,8 +2108,8 @@ (define_expand "movsi"
>>>> })
>>>>
>>>> (define_insn_and_split "*movsi_internal"
>>>> - [(set (match_operand:SI 0 "nonimmediate_operand" "=r,r,r,w,*f,f,*r,*m,*r,*z")
>>>> - (match_operand:SI 1 "move_operand" "r,Yd,w,rJ,*r*J,m,*f,*f,*z,*r"))]
>>>> + [(set (match_operand:SI 0 "nonimmediate_operand" "=r,r,r,w,*f,f,*r,*m")
>>>> + (match_operand:SI 1 "move_operand" "r,Yd,w,rJ,*r*J,m,*f,*f"))]
>>>> "(register_operand (operands[0], SImode)
>>>> || reg_or_0_operand (operands[1], SImode))"
>>>> { return loongarch_output_move (operands[0], operands[1]); }
>>>> @@ -2122,7 +2122,7 @@ (define_insn_and_split "*movsi_internal"
>>>> DONE;
>>>> }
>>>> "
>>>> - [(set_attr "move_type" "move,const,load,store,mgtf,fpload,mftg,fpstore,mftg,mgtf")
>>>> + [(set_attr "move_type" "move,const,load,store,mgtf,fpload,mftg,fpstore")
>>>> (set_attr "mode" "SI")])
>>>>
>> Sorry, I have a question. If this place is removed, is movgr2fr in the
>> loongarch_output_move function no longer needed?
> It's needed for moving SImode into FPR. "z" is FCC_REGS, not FP_REGS.
> I cannot see movgr2cf or movfr2cf in loongarch_output_move.
Well, I saw it wrong, I have no other questions.
Thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-01-16 6:23 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-15 12:56 [PATCH] LoongArch: Remove constraint z from movsi_internal Xi Ruoyao
2024-01-16 5:34 ` Ping: " Xi Ruoyao
2024-01-16 6:16 ` chenglulu
2024-01-16 6:20 ` Xi Ruoyao
2024-01-16 6:23 ` chenglulu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).