From: Joseph Myers <joseph@codesourcery.com>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: Kewen.Lin <linkw@linux.ibm.com>,
GCC Patches <gcc-patches@gcc.gnu.org>,
Michael Meissner <meissner@linux.ibm.com>,
David Edelsohn <dje.gcc@gmail.com>,
Jakub Jelinek <jakub@redhat.com>,
Peter Bergner <bergner@linux.ibm.com>,
Richard Biener <richard.guenther@gmail.com>,
Richard Sandiford <richard.sandiford@arm.com>
Subject: Re: [RFC/PATCH] Remove the workaround for _Float128 precision [PR107299]
Date: Thu, 22 Dec 2022 19:48:28 +0000 [thread overview]
Message-ID: <2ba9c17e-7e5a-cd2d-dc29-a75aff43253d@codesourcery.com> (raw)
In-Reply-To: <20221222181811.GV25951@gate.crashing.org>
On Thu, 22 Dec 2022, Segher Boessenkool wrote:
> Hi!
>
> On Wed, Dec 21, 2022 at 09:40:24PM +0000, Joseph Myers wrote:
> > On Wed, 21 Dec 2022, Segher Boessenkool wrote:
> > > > --- a/gcc/tree.cc
> > > > +++ b/gcc/tree.cc
> > > > @@ -9442,15 +9442,6 @@ build_common_tree_nodes (bool signed_char)
> > > > if (!targetm.floatn_mode (n, extended).exists (&mode))
> > > > continue;
> > > > int precision = GET_MODE_PRECISION (mode);
> > > > - /* Work around the rs6000 KFmode having precision 113 not
> > > > - 128. */
> > >
> > > It has precision 126 now fwiw.
> > >
> > > Joseph: what do you think about this patch? Is the workaround it
> > > removes still useful in any way, do we need to do that some other way if
> > > we remove this?
>
> You didn't address these questions. We don't see negative effects from
> removing this workaround, but it isn't clear (to me) what problems were
> there that caused you to do this workaround. Do you remember maybe? Or
> can we just delete it and try to forget such worries :-)
The purpose was to ensure that _Float128's TYPE_PRECISION was at least as
large as that of long double, in the case where they both have binary128
format. I think at that time, in GCC 7, it was possible for _Float128 to
be KFmode and long double to be TFmode, with those being different modes
with the same format.
In my view, it would be best not to have different modes with the same
format - not simply ensure types with the same format have the same mode,
but avoid multiple modes with the same format existing in the compiler at
all. That is, TFmode should be the same mode as one of KFmode and IFmode
(one name should be defined as a macro for the other name, or something
similar). If you don't have different modes with the same format, many of
the problems go away.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2022-12-22 19:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-21 9:02 Kewen.Lin
2022-12-21 21:24 ` Segher Boessenkool
2022-12-21 21:40 ` Joseph Myers
2022-12-21 22:45 ` Jakub Jelinek
2022-12-22 6:37 ` Kewen.Lin
2022-12-22 18:18 ` Segher Boessenkool
2022-12-22 19:48 ` Joseph Myers [this message]
2022-12-22 22:09 ` Segher Boessenkool
2023-01-03 23:27 ` Michael Meissner
2023-01-07 0:41 ` Michael Meissner
2023-01-10 3:21 ` Michael Meissner
2023-01-10 18:23 ` Jakub Jelinek
2023-01-11 20:26 ` Michael Meissner
2022-12-22 6:07 ` Kewen.Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ba9c17e-7e5a-cd2d-dc29-a75aff43253d@codesourcery.com \
--to=joseph@codesourcery.com \
--cc=bergner@linux.ibm.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=linkw@linux.ibm.com \
--cc=meissner@linux.ibm.com \
--cc=richard.guenther@gmail.com \
--cc=richard.sandiford@arm.com \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).