From: Jakub Jelinek <jakub@redhat.com>
To: Michael Meissner <meissner@linux.ibm.com>,
Joseph Myers <joseph@codesourcery.com>,
Segher Boessenkool <segher@kernel.crashing.org>,
"Kewen.Lin" <linkw@linux.ibm.com>,
GCC Patches <gcc-patches@gcc.gnu.org>,
David Edelsohn <dje.gcc@gmail.com>,
Peter Bergner <bergner@linux.ibm.com>,
Richard Biener <richard.guenther@gmail.com>,
Richard Sandiford <richard.sandiford@arm.com>
Subject: Re: [RFC/PATCH] Remove the workaround for _Float128 precision [PR107299]
Date: Tue, 10 Jan 2023 19:23:23 +0100 [thread overview]
Message-ID: <Y72tG5e1qICR9hkb@tucnak> (raw)
In-Reply-To: <Y7zZ0JAZG7UUBsr4@toto.the-meissners.org>
On Mon, Jan 09, 2023 at 10:21:52PM -0500, Michael Meissner wrote:
> I had the patches to change the precision to 128, and I just ran them. C and
> C++ do not seem to be bothered by changing the precision to 128 (once I got it
> to build, etc.). But Fortran on the other hand does actually use the precision
> to differentiate between IBM extended double and IEEE 128-bit. In particular,
> the following 3 tests fail when long double is IBM extended double:
>
> gfortran.dg/PR100914.f90
> gfortran.dg/c-interop/typecodes-array-float128.f90
> gfortran.dg/c-interop/typecodes-scalar-float128.f90
>
> I tried adding code to use the old precisions for Fortran, but not for C/C++,
> but it didn't seem to work.
>
> So while it might be possible to use a single 128 for the precision, it needs
> more work and attention, particularly on the Fortran side.
Can't be more than a few lines changed in the fortran FE.
Yes, the FE needs to know if it is IBM extended double or IEEE 128-bit so
that it can decide on the mangling - where to use the artificial kind 17 and
where to use 16. But as long as it can figure that out, it doesn't need to
rely on a particular precision.
Jakub
next prev parent reply other threads:[~2023-01-10 18:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-21 9:02 Kewen.Lin
2022-12-21 21:24 ` Segher Boessenkool
2022-12-21 21:40 ` Joseph Myers
2022-12-21 22:45 ` Jakub Jelinek
2022-12-22 6:37 ` Kewen.Lin
2022-12-22 18:18 ` Segher Boessenkool
2022-12-22 19:48 ` Joseph Myers
2022-12-22 22:09 ` Segher Boessenkool
2023-01-03 23:27 ` Michael Meissner
2023-01-07 0:41 ` Michael Meissner
2023-01-10 3:21 ` Michael Meissner
2023-01-10 18:23 ` Jakub Jelinek [this message]
2023-01-11 20:26 ` Michael Meissner
2022-12-22 6:07 ` Kewen.Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y72tG5e1qICR9hkb@tucnak \
--to=jakub@redhat.com \
--cc=bergner@linux.ibm.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=joseph@codesourcery.com \
--cc=linkw@linux.ibm.com \
--cc=meissner@linux.ibm.com \
--cc=richard.guenther@gmail.com \
--cc=richard.sandiford@arm.com \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).