public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: David Malcolm <dmalcolm@redhat.com>
To: Lewis Hyatt <lhyatt@gmail.com>,
	gcc-patches@gcc.gnu.org, Joseph Myers <joseph@codesourcery.com>
Subject: Re: [PATCH] libcpp: Update cpp_wcwidth() to Unicode 14.0.0
Date: Fri, 24 Jun 2022 14:25:37 -0400	[thread overview]
Message-ID: <2bf3f5270abb8c42f035f33615157af8a81d2ca9.camel@redhat.com> (raw)
In-Reply-To: <20220606214957.GA58074@ldh-imac.local>

On Mon, 2022-06-06 at 17:49 -0400, Lewis Hyatt via Gcc-patches wrote:
> Hello-
> 
> The attached patch upgrades the cpp_wcwidth() function (needed for
> computing display columns in diagnostics output) from Unicode 13 to
> Unicode 14. I just mechanically followed the procedure in
> contrib/unicode/README with nothing unexpected coming up. I attached it
> compressed since it's a bit large, and not really human readable
> anyway. Please let me know if it's OK to commit. I did
> bootstrap/regtest
> all languages with no issues on x86-64 Linux. (Although I had to revert
> locally one unrelated commit that seems to break bootstrap for Ada on
> the
> master branch currently.)
> 
> BTW, is this something simple enough I should just commit it without
> bugging
> the list for approval?

The patch seems reasonable to me, but Joseph seems to be the expert on
i18n-related matters.

Joseph, do we have a policy on this?

Thanks
Dave

> 
> Thanks!
> 
> -Lewis
> 
> ======
> 
> Subject: [PATCH] libcpp: Update cpp_wcwidth() to Unicode 14.0.0
> 
> The procedure detailed in contrib/unicode/README was followed with
> nothing
> notable coming up. The glibc scripts did not require any update, so the
> only change was retrieving new versions of the Unicode data files and
> rerunning gen_wcwidth.py.
> 
> contrib/ChangeLog:
> 
>         * unicode/EastAsianWidth.txt: Update to Unicode 14.0.0.
>         * unicode/PropList.txt: Likewise.
>         * unicode/README: Likewise.
>         * unicode/UnicodeData.txt: Likewise.
> 
> libcpp/ChangeLog:
> 
>         * generated_cpp_wcwidth.h: Generated from updated Unicode data
> files.



  reply	other threads:[~2022-06-24 18:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-06 21:49 Lewis Hyatt
2022-06-24 18:25 ` David Malcolm [this message]
2022-06-24 19:26   ` Joseph Myers
2022-06-26 18:16     ` Lewis Hyatt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2bf3f5270abb8c42f035f33615157af8a81d2ca9.camel@redhat.com \
    --to=dmalcolm@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=joseph@codesourcery.com \
    --cc=lhyatt@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).