From: Jeff Law <jlaw@ventanamicro.com>
To: Manolis Tsamis <manolis.tsamis@vrull.eu>,
Palmer Dabbelt <palmer@dabbelt.com>
Cc: Vineet Gupta <vineetg@rivosinc.com>,
gcc-patches@gcc.gnu.org, Kito Cheng <kito.cheng@gmail.com>,
philipp.tomsich@vrull.eu
Subject: Re: [PATCH] Enable shrink wrapping for the RISC-V target.
Date: Tue, 18 Oct 2022 09:57:37 -0600 [thread overview]
Message-ID: <2e2ca1dc-902e-23ca-babf-11a4978530ef@ventanamicro.com> (raw)
In-Reply-To: <CAM3yNXqiM=t5w51ffQ43sBF98oNOM3m0M5fmbTb07z_B-=wi9Q@mail.gmail.com>
Just a couple more comments in-line.
On 10/18/22 09:18, Manolis Tsamis wrote:
>
>>> +/* Implement TARGET_SHRINK_WRAP_GET_SEPARATE_COMPONENTS. */
>>> +
>>> +static sbitmap
>>> +riscv_get_separate_components (void)
>>> +{
>>> + HOST_WIDE_INT offset;
>>> + sbitmap components = sbitmap_alloc (FIRST_PSEUDO_REGISTER);
>>> + bitmap_clear (components);
>>> +
>>> + if (riscv_use_save_libcall (&cfun->machine->frame)
>>> + || cfun->machine->interrupt_handler_p)
>> riscv_use_save_libcall() already checks interrupt_handler_p, so that's
>> redundant. That said, I'm not sure riscv_use_save_libcall() is the
>> right check here as unless I'm missing something we don't have all those
>> other constraints when shrink-wrapping.
>>
> riscv_use_save_libcall returns false when interrupt_handler_p is true, so the
> check for interrupt_handler_p in the branch is not redundant in this case.
>
> I encountered some issues when shrink wrapping and libcall was used in the same
> function. Thinking that libcall replaces the prologue/epilogue I didn't see a
> reason to have both at the same time and hence I opted to disable
> shrink wrapping in that case. From my understanding this should be harmless?
I would have expected things to work fine with libcalls, perhaps with
the exception of the save/restore libcalls. So that needs deeper
investigation.
>>
>> It seems kind of clunky to have two copies of all these loops (and we'll
>> need a third to make this work with the V stuff), but we've got that
>> issue elsewhere in the port so I don't think you need to fix it here
>> (though the V stuff will be there for the v2, so you'll need the third
>> copy of each loop).
>>
> Indeed, I was following the other ports here. Do you think it would be
> better to refactor this when the code for the V extension is added?
> By taking into account what code will be needed for V, a proper refactored
> function could be made to handle all cases.
I think refactoring when V gets added would be fine. While we could
probably refactor it correctly now (it isn't terribly complex code after
all), but we're more likely to get it right with the least amount of
work if we do it when V is submitted.
>> Either way, this deserves a test case. I think it should be possible to
>> write one by introducing some register pressure around a
>> shrink-wrappable block that needs a long stack offset and making sure
>> in-flight registers don't get trashed.
>>
> I tried to think of some way to introduce a test like that but couldn't and
> I don't see how it would be done. Shrink wrapping only affects saved registers
> so there are always available temporaries that are not affected by
> shrink wrapping.
> (Register pressure should be irrelevant in this case if I understand correctly).
> Also the implementation checks for SMALL_OPERAND (offset) shrink wrapping
> should be unaffected from long stack offsets. If you see some way to write
> a test for that based on what I explained please explain how I could do that.
I think the register pressure was just to ensure that some saves were
needed to trigger an attempt to shrink wrap something. You'd also need
something to eat stack space (local array which gets referenced as an
asm operand, but where the asm doesn't generate any code perhaps)?
Whether or not that works depends on stack layout though which I don't
know well enough for riscv.
Generally looks pretty good though.
Jeff
next prev parent reply other threads:[~2022-10-18 15:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-06 10:39 mtsamis
2022-10-02 20:32 ` Palmer Dabbelt
2022-10-18 15:18 ` Manolis Tsamis
2022-10-18 15:57 ` Jeff Law [this message]
2022-10-18 17:35 ` Palmer Dabbelt
2022-10-19 17:15 ` Jeff Law
2022-10-20 7:42 ` Manolis Tsamis
2022-11-02 14:12 ` Manolis Tsamis
2022-11-02 15:02 ` Jeff Law
2022-10-20 7:35 ` Manolis Tsamis
2022-11-02 13:54 ` Manolis Tsamis
2022-11-02 15:06 ` Jeff Law
2022-11-03 0:26 ` Palmer Dabbelt
2022-11-03 22:23 ` Jeff Law
2022-11-07 22:07 ` Palmer Dabbelt
2022-11-13 1:32 ` Jeff Law
2022-11-16 10:26 ` Manolis Tsamis
2022-11-17 2:09 ` Jeff Law
2022-11-17 10:54 ` Manolis Tsamis
2022-11-17 11:59 ` Philipp Tomsich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e2ca1dc-902e-23ca-babf-11a4978530ef@ventanamicro.com \
--to=jlaw@ventanamicro.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=kito.cheng@gmail.com \
--cc=manolis.tsamis@vrull.eu \
--cc=palmer@dabbelt.com \
--cc=philipp.tomsich@vrull.eu \
--cc=vineetg@rivosinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).