* c++: Use better module partition naming
@ 2022-06-15 15:06 Nathan Sidwell
0 siblings, 0 replies; only message in thread
From: Nathan Sidwell @ 2022-06-15 15:06 UTC (permalink / raw)
To: GCC Patches
[-- Attachment #1: Type: text/plain, Size: 222 bytes --]
It turns out that 'implementation partition' is not a term used in the
std, and is confusing to users. Let's use the better term 'internal
partition'. While there, adjust header unit naming.
nathan
--
Nathan Sidwell
[-- Attachment #2: 0001-c-Use-better-module-partition-naming.patch --]
[-- Type: text/x-patch, Size: 1361 bytes --]
From 052d89537a4c09e1e1437042e2d1ea215656325f Mon Sep 17 00:00:00 2001
From: Nathan Sidwell <nathan@acm.org>
Date: Fri, 10 Jun 2022 11:57:38 -0700
Subject: [PATCH] c++: Use better module partition naming
It turns out that 'implementation partition' is not a term used in the
std, and is confusing to users. Let's use the better term 'internal
partition'. While there, adjust header unit naming.
gcc/cp/
* module.cc (module_state::write_readme): Use less confusing
importable unit names.
---
gcc/cp/module.cc | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/gcc/cp/module.cc b/gcc/cp/module.cc
index 5566c49490f..b3fbd467ecb 100644
--- a/gcc/cp/module.cc
+++ b/gcc/cp/module.cc
@@ -13962,11 +13962,11 @@ module_state::write_readme (elf_out *to, cpp_reader *reader, const char *dialect
readme.begin (false);
- readme.printf ("GNU C++ %smodule%s%s",
- is_header () ? "header " : is_partition () ? "" : "primary ",
- is_header () ? ""
- : is_interface () ? " interface" : " implementation",
- is_partition () ? " partition" : "");
+ readme.printf ("GNU C++ %s",
+ is_header () ? "header unit"
+ : !is_partition () ? "primary interface"
+ : is_interface () ? "interface partition"
+ : "internal partition");
/* Compiler's version. */
readme.printf ("compiler: %s", version_string);
--
2.30.2
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-06-15 15:07 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-15 15:06 c++: Use better module partition naming Nathan Sidwell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).