* [PATCH] RISC-V: Add :: for static function calling to avoid confusing
@ 2023-01-18 3:16 juzhe.zhong
2023-01-22 19:30 ` Jeff Law
0 siblings, 1 reply; 2+ messages in thread
From: juzhe.zhong @ 2023-01-18 3:16 UTC (permalink / raw)
To: gcc-patches; +Cc: kito.cheng, palmer, Ju-Zhe Zhong
From: Ju-Zhe Zhong <juzhe.zhong@rivai.ai>
Since we have same function in class and static function calling get_avl.
Adding :: to avoid codes confusing.
gcc/ChangeLog:
* config/riscv/riscv-vsetvl.cc (pass_vsetvl::get_backward_fusion_type): Add ::.
---
gcc/config/riscv/riscv-vsetvl.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gcc/config/riscv/riscv-vsetvl.cc b/gcc/config/riscv/riscv-vsetvl.cc
index e11751f00af..b33c198bbd6 100644
--- a/gcc/config/riscv/riscv-vsetvl.cc
+++ b/gcc/config/riscv/riscv-vsetvl.cc
@@ -2073,7 +2073,7 @@ pass_vsetvl::get_backward_fusion_type (const bb_info *bb,
reg = get_vl (insn->rtl ());
else
/* Check AVL operand for vsetvl zero,avl. */
- reg = get_avl (insn->rtl ());
+ reg = ::get_avl (insn->rtl ());
}
}
--
2.36.3
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] RISC-V: Add :: for static function calling to avoid confusing
2023-01-18 3:16 [PATCH] RISC-V: Add :: for static function calling to avoid confusing juzhe.zhong
@ 2023-01-22 19:30 ` Jeff Law
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Law @ 2023-01-22 19:30 UTC (permalink / raw)
To: juzhe.zhong, gcc-patches; +Cc: kito.cheng, palmer
On 1/17/23 20:16, juzhe.zhong@rivai.ai wrote:
> From: Ju-Zhe Zhong <juzhe.zhong@rivai.ai>
>
> Since we have same function in class and static function calling get_avl.
> Adding :: to avoid codes confusing.
>
> gcc/ChangeLog:
>
> * config/riscv/riscv-vsetvl.cc (pass_vsetvl::get_backward_fusion_type): Add ::.
Is there any reasonable way to avoid having the same name? ISTM that's
the root of the problem and adding "::" is just papering over the real
issue.
Jeff
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-22 19:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-18 3:16 [PATCH] RISC-V: Add :: for static function calling to avoid confusing juzhe.zhong
2023-01-22 19:30 ` Jeff Law
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).