* Re:[PATCH 1/1] RISC-V: Make R_RISCV_SUB6 conforms to riscv abi standard
@ 2022-11-11 13:11 shihua
0 siblings, 0 replies; only message in thread
From: shihua @ 2022-11-11 13:11 UTC (permalink / raw)
To: zengxiao; +Cc: gcc-patches
[-- Attachment #1: Type: text/plain, Size: 1411 bytes --]
LGTM,and I think it would be better to have a test example.
> From: zengxiao <zengxiao@eswincomputing.com>
>
> This patch makes R_RISCV_SUB6 conforms to riscv abi standard.
> R_RISCV_SUB6 only the lower 6 bits of the code are valid.
> The proposed specification which can be found in 8.5. Relocations of,
> https://github.com/riscv-non-isa/riscv-elf-psabi-doc/releases/download/v1.0-rc4/riscv-abi.pdf
>
> bfd/ChangeLog:
>
> * elfxx-riscv.c (riscv_elf_add_sub_reloc): Take the lower
> 6 bits as the significant bit
>
> reviewed-by: gaofei@eswincomputing.com
> jinyanjiang@eswincomputing.com
>
> Signed-off-by: zengxiao <zengxiao@eswincomputing.com>
> ---
> bfd/elfxx-riscv.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/bfd/elfxx-riscv.c b/bfd/elfxx-riscv.c
> index f0c91cc97f7..0fbfedd17fe 100644
> --- a/bfd/elfxx-riscv.c
> +++ b/bfd/elfxx-riscv.c
> @@ -994,6 +994,13 @@ riscv_elf_add_sub_reloc (bfd *abfd,
> relocation = old_value + relocation;
> break;
> case R_RISCV_SUB6:
> + {
> + bfd_vma six_bit_valid_value = old_value & howto->dst_mask;
> + six_bit_valid_value -= relocation;
> + relocation = (six_bit_valid_value & howto->dst_mask) |
> + (old_value & ~howto->dst_mask);
> + }
> + break;
> case R_RISCV_SUB8:
> case R_RISCV_SUB16:
> case R_RISCV_SUB32:
> --
> 2.34.1
logo
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-11-11 13:11 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-11 13:11 Re:[PATCH 1/1] RISC-V: Make R_RISCV_SUB6 conforms to riscv abi standard shihua
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).