From: Eric Botcazou <botcazou@adacore.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Jason Merrill <jason@redhat.com>,
Richard Biener <rguenther@suse.de>,
Jeff Law <jeffreyalaw@gmail.com>,
Richard Sandiford <richard.sandiford@arm.com>,
gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] machmode: Introduce GET_MODE_NEXT_MODE with previous GET_MODE_WIDER_MODE meaning, add new GET_MODE_WIDER_MODE
Date: Wed, 12 Oct 2022 12:37:39 +0200 [thread overview]
Message-ID: <3193881.aeNJFYEL58@fomalhaut> (raw)
In-Reply-To: <Y0Z5lozuTufmyMpL@tucnak>
> Though I admit I didn't go carefully through all 24 GET_MODE_WIDER_MODE
> uses, 54 FOR_EACH_MODE_IN_CLASS uses, 3 FOR_EACH_MODE uses, 24
> FOR_EACH_MODE_FROM, 6 FOR_EACH_MODE_UNTIL and 15 FOR_EACH_WIDER_MODE uses.
> It is more important to go through the GET_MODE_WIDER_MODE and
> FOR_EACH_WIDER_MODE uses because the patch changes behavior for those,
> the rest keep their previous meaning and so can be changed incrementally
> if the other meaning is desirable to them (I've of course changed the 3
> spots I had to change in the previous BFmode patch and whatever triggered
> during the bootstraps).
>
> Thoughts on this?
Can't we declare that one is wider than the other, for example BFmode since it
has got a larger range? Though I guess this would mean special-casing them in
genmodes.cc as they are presumably strictly identical except for the format.
--
Eric Botcazou
next prev parent reply other threads:[~2022-10-12 10:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 15:55 [RFC PATCH] c++, i386, arm, aarch64, libgcc: std::bfloat16_t and __bf16 arithmetic support Jakub Jelinek
2022-09-30 13:49 ` Jason Merrill
2022-09-30 14:08 ` Jakub Jelinek
2022-09-30 18:21 ` Joseph Myers
2022-09-30 18:38 ` Jakub Jelinek
2022-09-30 19:27 ` Jonathan Wakely
2022-10-04 9:06 ` [PATCH] middle-end, c++, i386, " Jakub Jelinek
2022-10-04 15:54 ` Joseph Myers
2022-10-04 21:50 ` Jason Merrill
2022-10-05 13:47 ` Jakub Jelinek
2022-10-05 20:02 ` Jason Merrill
2022-10-12 8:23 ` [PATCH] machmode: Introduce GET_MODE_NEXT_MODE with previous GET_MODE_WIDER_MODE meaning, add new GET_MODE_WIDER_MODE Jakub Jelinek
2022-10-12 10:15 ` Richard Sandiford
2022-10-12 11:07 ` [PATCH] machmode, v2: " Jakub Jelinek
2022-10-12 11:49 ` Richard Sandiford
2022-10-12 10:37 ` Eric Botcazou [this message]
2022-10-12 10:57 ` [PATCH] machmode: " Jakub Jelinek
2022-10-13 16:50 ` [PATCH] middle-end, c++, i386, libgcc, v2: std::bfloat16_t and __bf16 arithmetic support Jakub Jelinek
2022-10-13 19:37 ` Jason Merrill
2022-10-13 21:11 ` Uros Bizjak
2022-10-13 21:35 ` Jakub Jelinek
2022-10-13 21:46 ` Uros Bizjak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3193881.aeNJFYEL58@fomalhaut \
--to=botcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=jason@redhat.com \
--cc=jeffreyalaw@gmail.com \
--cc=rguenther@suse.de \
--cc=richard.sandiford@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).