public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Michael Collison <collison@rivosinc.com>
To: gcc-patches@gcc.gnu.org
Subject: [PATCH] vect: Check that vector factor is a compile-time constant
Date: Tue, 21 Feb 2023 18:02:32 -0500	[thread overview]
Message-ID: <3356a2e0-b402-de07-9374-6e5b5c59a2f2@rivosinc.com> (raw)

While working on autovectorizing for the RISCV port I encountered an 
issue where vect_do_peeling assumes that the vectorization factor is a 
compile-time constant. The vectorization is not a compile-time constant 
on RISCV.

Tested on RISCV and x86_64-linux-gnu. Okay?

Michael

gcc/

     * tree-vect-loop-manip.cc (vect_do_peeling): Verify
     that vectorization factor is a compile-time constant.

---
  gcc/tree-vect-loop-manip.cc | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/tree-vect-loop-manip.cc b/gcc/tree-vect-loop-manip.cc
index 6aa3d2ed0bf..1ad1961c788 100644
--- a/gcc/tree-vect-loop-manip.cc
+++ b/gcc/tree-vect-loop-manip.cc
@@ -2930,7 +2930,7 @@ vect_do_peeling (loop_vec_info loop_vinfo, tree 
niters, tree nitersm1,
        niters = vect_build_loop_niters (loop_vinfo, &new_var_p);
        /* It's guaranteed that vector loop bound before vectorization is at
       least VF, so set range information for newly generated var. */
-      if (new_var_p)
+      if (new_var_p && vf.is_constant ())
      {
        value_range vr (type,
                wi::to_wide (build_int_cst (type, vf)),
-- 
2.34.1


             reply	other threads:[~2023-02-21 23:02 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-21 23:02 Michael Collison [this message]
2023-02-22  8:20 ` Richard Biener
2023-02-22 16:42   ` Michael Collison
2023-02-23  9:08     ` Richard Biener
2023-02-27 14:51   ` Richard Sandiford
2023-03-01 21:00     ` Michael Collison
2023-03-02  7:56       ` Richard Biener
2023-02-22 15:27 juzhe.zhong
2023-02-22 17:54 ` Michael Collison
2023-02-23  4:01   ` Jeff Law
2023-02-23  4:50     ` Michael Collison
2023-02-24  3:34       ` Jeff Law
2023-02-24  4:04         ` Kito Cheng
2023-03-14 17:48           ` Jeff Law
2023-03-17 16:57             ` Palmer Dabbelt
2023-03-17 16:57               ` Palmer Dabbelt
2023-03-23 23:18               ` Jeff Law
2023-03-24  2:28                 ` Palmer Dabbelt
2023-03-25 22:45                   ` Jeff Law

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3356a2e0-b402-de07-9374-6e5b5c59a2f2@rivosinc.com \
    --to=collison@rivosinc.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).