* Re: [PATCH 1/4] libsanitizer: merge from upstream (c425db2eb558c263)
@ 2023-11-17 11:15 FX Coudert
2023-11-17 11:31 ` FX Coudert
0 siblings, 1 reply; 9+ messages in thread
From: FX Coudert @ 2023-11-17 11:15 UTC (permalink / raw)
To: GCC Patches; +Cc: Jakub Jelinek, Iain Sandoe
Heads-up: this broke bootstrap on darwin:
> +typedef void (^dispatch_mach_handler_t)(dispatch_mach_reason reason,
> + dispatch_mach_msg_t message,
> + mach_error_t error);
Blocks are an Apple/clang extension, not (yet) supported by GCC.
FX
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/4] libsanitizer: merge from upstream (c425db2eb558c263)
2023-11-17 11:15 [PATCH 1/4] libsanitizer: merge from upstream (c425db2eb558c263) FX Coudert
@ 2023-11-17 11:31 ` FX Coudert
2023-11-17 11:41 ` Jakub Jelinek
0 siblings, 1 reply; 9+ messages in thread
From: FX Coudert @ 2023-11-17 11:31 UTC (permalink / raw)
To: GCC Patches; +Cc: Jakub Jelinek, Iain Sandoe
I have reported the issue to llvm at https://github.com/llvm/llvm-project/issues/72639
There is a trivial one-line patch to fix it, which I hope they will accept. Not sure what our policy is here, in the meantime.
FX
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/4] libsanitizer: merge from upstream (c425db2eb558c263)
2023-11-17 11:31 ` FX Coudert
@ 2023-11-17 11:41 ` Jakub Jelinek
2023-11-17 11:57 ` FX Coudert
0 siblings, 1 reply; 9+ messages in thread
From: Jakub Jelinek @ 2023-11-17 11:41 UTC (permalink / raw)
To: FX Coudert; +Cc: GCC Patches, Iain Sandoe
On Fri, Nov 17, 2023 at 12:31:40PM +0100, FX Coudert wrote:
> I have reported the issue to llvm at https://github.com/llvm/llvm-project/issues/72639
> There is a trivial one-line patch to fix it, which I hope they will accept. Not sure what our policy is here, in the meantime.
If they accept it say within a day, wait for it + cherry-pick to GCC,
otherwise apply to GCC as a local patch in anticipation they accept it.
If it is all that fixes Darwin support, great.
Jakub
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/4] libsanitizer: merge from upstream (c425db2eb558c263)
2023-11-17 11:41 ` Jakub Jelinek
@ 2023-11-17 11:57 ` FX Coudert
2023-11-21 11:55 ` Iain Sandoe
0 siblings, 1 reply; 9+ messages in thread
From: FX Coudert @ 2023-11-17 11:57 UTC (permalink / raw)
To: Jakub Jelinek; +Cc: GCC Patches, Iain Sandoe
> If they accept it say within a day, wait for it + cherry-pick to GCC,
> otherwise apply to GCC as a local patch in anticipation they accept it.
> If it is all that fixes Darwin support, great.
With that patch, I can finish bootstrap, and regtesting is undergoing but I’m seeing no issue so far.
FX
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/4] libsanitizer: merge from upstream (c425db2eb558c263)
2023-11-17 11:57 ` FX Coudert
@ 2023-11-21 11:55 ` Iain Sandoe
2023-11-21 13:15 ` FX
0 siblings, 1 reply; 9+ messages in thread
From: Iain Sandoe @ 2023-11-21 11:55 UTC (permalink / raw)
To: FX Coudert; +Cc: Jakub Jelinek, GCC Patches
Hi FX
> On 17 Nov 2023, at 11:57, FX Coudert <fxcoudert@gmail.com> wrote:
>
>> If they accept it say within a day, wait for it + cherry-pick to GCC,
>> otherwise apply to GCC as a local patch in anticipation they accept it.
>> If it is all that fixes Darwin support, great.
>
> With that patch, I can finish bootstrap, and regtesting is undergoing but I’m seeing no issue so far.
I see that the fix was applied locally (and my bootstraps on various Darwin versions worked OK),
but I’m not clear if you submitted a PR upstream (or just the bug report). If the fix is to remain
local-only, it should be added to the list in LOCAL_PATCHES.
thanks for handling this,
Iain
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/4] libsanitizer: merge from upstream (c425db2eb558c263)
2023-11-21 11:55 ` Iain Sandoe
@ 2023-11-21 13:15 ` FX
0 siblings, 0 replies; 9+ messages in thread
From: FX @ 2023-11-21 13:15 UTC (permalink / raw)
To: Iain Sandoe; +Cc: Jakub Jelinek, GCC Patches
[-- Attachment #1: Type: text/plain, Size: 360 bytes --]
> I see that the fix was applied locally (and my bootstraps on various Darwin versions worked OK),
> but I’m not clear if you submitted a PR upstream (or just the bug report). If the fix is to remain
> local-only, it should be added to the list in LOCAL_PATCHES.
Patch was submitted upstream: https://github.com/llvm/llvm-project/pull/72642
FX
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/4] libsanitizer: merge from upstream (c425db2eb558c263)
2023-11-15 10:56 Jakub Jelinek
2023-11-15 11:01 ` Sam James
@ 2023-11-15 11:40 ` Richard Biener
1 sibling, 0 replies; 9+ messages in thread
From: Richard Biener @ 2023-11-15 11:40 UTC (permalink / raw)
To: Jakub Jelinek; +Cc: gcc-patches, Iain Sandoe, Jeff Law
On Wed, 15 Nov 2023, Jakub Jelinek wrote:
> Hi!
>
> The following patch is result of libsanitizer/merge.sh
> from c425db2eb558c263 (yesterday evening).
>
> Bootstrapped/regtested on x86_64-linux and i686-linux (together with
> the follow-up 3 patches I'm about to post).
>
> Iain, could you please check Darwin?
>
> And anyone else their favourite platform?
>
> BTW, seems upstream has added riscv64 support for I think lsan/tsan,
> so if anyone is willing to try it there, it would be a matter of
> copying e.g. the s390*-*-linux* libsanitizer/configure.tgt entry
> to riscv64-*-linux* with the obvious s/s390x/riscv64/ change in it.
OK for the series.
> Thanks.
>
> Jakub
>
--
Richard Biener <rguenther@suse.de>
SUSE Software Solutions Germany GmbH,
Frankenstrasse 146, 90461 Nuernberg, Germany;
GF: Ivo Totev, Andrew McDonald, Werner Knoblich; (HRB 36809, AG Nuernberg)
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/4] libsanitizer: merge from upstream (c425db2eb558c263)
2023-11-15 10:56 Jakub Jelinek
@ 2023-11-15 11:01 ` Sam James
2023-11-15 11:40 ` Richard Biener
1 sibling, 0 replies; 9+ messages in thread
From: Sam James @ 2023-11-15 11:01 UTC (permalink / raw)
To: Jakub Jelinek; +Cc: Richard Biener, Iain Sandoe, Jeff Law, gcc-patches
Jakub Jelinek <jakub@redhat.com> writes:
> Hi!
>
> The following patch is result of libsanitizer/merge.sh
> from c425db2eb558c263 (yesterday evening).
>
> Bootstrapped/regtested on x86_64-linux and i686-linux (together with
> the follow-up 3 patches I'm about to post).
>
> Iain, could you please check Darwin?
>
> And anyone else their favourite platform?
>
> BTW, seems upstream has added riscv64 support for I think lsan/tsan,
> so if anyone is willing to try it there, it would be a matter of
> copying e.g. the s390*-*-linux* libsanitizer/configure.tgt entry
> to riscv64-*-linux* with the obvious s/s390x/riscv64/ change in it.
Thank you for doing it.
This will fix PR109882.
>
> Thanks.
>
> Jakub
>
> [2. application/gzip; gcc14-libsanitizer-merge.patch.gz]...
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/4] libsanitizer: merge from upstream (c425db2eb558c263)
@ 2023-11-15 10:56 Jakub Jelinek
2023-11-15 11:01 ` Sam James
2023-11-15 11:40 ` Richard Biener
0 siblings, 2 replies; 9+ messages in thread
From: Jakub Jelinek @ 2023-11-15 10:56 UTC (permalink / raw)
To: Richard Biener; +Cc: gcc-patches, Iain Sandoe, Jeff Law
[-- Attachment #1: Type: text/plain, Size: 583 bytes --]
Hi!
The following patch is result of libsanitizer/merge.sh
from c425db2eb558c263 (yesterday evening).
Bootstrapped/regtested on x86_64-linux and i686-linux (together with
the follow-up 3 patches I'm about to post).
Iain, could you please check Darwin?
And anyone else their favourite platform?
BTW, seems upstream has added riscv64 support for I think lsan/tsan,
so if anyone is willing to try it there, it would be a matter of
copying e.g. the s390*-*-linux* libsanitizer/configure.tgt entry
to riscv64-*-linux* with the obvious s/s390x/riscv64/ change in it.
Thanks.
Jakub
[-- Attachment #2: gcc14-libsanitizer-merge.patch.gz --]
[-- Type: application/gzip, Size: 140278 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-11-21 13:15 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-17 11:15 [PATCH 1/4] libsanitizer: merge from upstream (c425db2eb558c263) FX Coudert
2023-11-17 11:31 ` FX Coudert
2023-11-17 11:41 ` Jakub Jelinek
2023-11-17 11:57 ` FX Coudert
2023-11-21 11:55 ` Iain Sandoe
2023-11-21 13:15 ` FX
-- strict thread matches above, loose matches on Subject: below --
2023-11-15 10:56 Jakub Jelinek
2023-11-15 11:01 ` Sam James
2023-11-15 11:40 ` Richard Biener
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).