From: Peter Bergner <bergner@linux.ibm.com>
To: Ajit Agarwal <aagarwa1@linux.ibm.com>,
gcc-patches <gcc-patches@gcc.gnu.org>
Cc: Segher Boessenkool <segher@kernel.crashing.org>,
Jeff Law <jeffreyalaw@gmail.com>,
Richard Biener <richard.guenther@gmail.com>
Subject: Re: [PATCH] rtl-optimization: ppc backend generates unnecessary signed extension.
Date: Thu, 23 Mar 2023 07:38:40 -0500 [thread overview]
Message-ID: <365cfb50-4313-d44e-6ffc-77473b20c670@linux.ibm.com> (raw)
In-Reply-To: <4c0b6b4f-bbc1-8dd0-a91c-ffed028b4873@linux.ibm.com>
On 3/23/23 5:38 AM, Ajit Agarwal wrote:
> This patch removed unnecessary signed extension elimination in ree pass.
> Bootstrapped and regtested on powerpc64-linux-gnu.
>
>
> Thanks & Regards
> Ajit
>
> rtl-optimization: ppc backend generates unnecessary signed extension.
>
> Eliminate unnecessary redundant signed extension.
>
> 2023-03-23 Ajit Kumar Agarwal <aagarwa1@linux.ibm.com>
>
> gcc/ChangeLog:
>
> * ree.cc: Modification for AND opcode support to eliminate
> unnecessary signed extension.
> * testsuite/g++.target/powerpc/sext-elim.C: New tests.
Not a review of the patch, but we talked offline about other bugzillas
regarding unnecessary sign and zero extensions. Doing a quick scan, I
see the following bugs. Please have a look at 1) whether these are
still a problem with unpatched trunk, and if they are, 2) whether your
patch fixes them or could fix them. Thanks.
https://gcc.gnu.org/PR41742
https://gcc.gnu.org/PR65010
https://gcc.gnu.org/PR82940
https://gcc.gnu.org/PR107949
Peter
next prev parent reply other threads:[~2023-03-23 12:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 10:38 Ajit Agarwal
2023-03-23 12:38 ` Peter Bergner [this message]
2023-03-23 15:32 ` Ajit Agarwal
2023-03-23 15:32 ` Ajit Agarwal
2023-03-23 16:29 ` Peter Bergner
2023-03-23 16:32 ` Jeff Law
2023-03-23 16:53 ` Peter Bergner
2023-03-23 23:12 ` Jeff Law
2023-03-24 21:34 ` Peter Bergner
2023-03-25 18:09 ` Jeff Law
2023-03-31 0:01 ` Hans-Peter Nilsson
2023-03-31 14:01 ` Jeff Law
2023-03-23 13:47 ` Jeff Law
2023-03-23 15:36 ` Ajit Agarwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=365cfb50-4313-d44e-6ffc-77473b20c670@linux.ibm.com \
--to=bergner@linux.ibm.com \
--cc=aagarwa1@linux.ibm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
--cc=richard.guenther@gmail.com \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).