From: Eric Botcazou <botcazou@adacore.com>
To: Richard Biener <richard.guenther@gmail.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Fix wrong code generated by unroll-and-jam pass
Date: Thu, 06 Oct 2022 13:09:03 +0200 [thread overview]
Message-ID: <3695765.kQq0lBPeGt@fomalhaut> (raw)
In-Reply-To: <CAFiYyc2W669wSdfo=3Top_uFH1=x_FA1=_ieqWoN=uCodNv-2A@mail.gmail.com>
> I'm wondering if testing DR_IS_WRITE (dra) is enough here and whether
> the logic also applies to RAW and WAR. So should it be either
> (DR_IS_WRITE (dra) || DR_IS_WRITE (drb)) or DR_IS_WRITE (dra) &&
> DR_IS_WRITE (drb) instead?
It's a self-dependence, i.e. dra == drb in the block. Or do you mean for
other dependence pairs in general? For them, I think that the code does the
proper filtering in adjust_unroll_factor, but I may be wrong of course.
--
Eric Botcazou
next prev parent reply other threads:[~2022-10-06 11:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-05 15:36 Eric Botcazou
2022-10-06 8:21 ` Richard Biener
2022-10-06 11:09 ` Eric Botcazou [this message]
2022-10-06 12:21 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3695765.kQq0lBPeGt@fomalhaut \
--to=botcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).