* [PATCH] Testsuite, i386: Mark test as requiring dfp
@ 2023-10-30 14:19 FX Coudert
2023-11-05 20:33 ` FX Coudert
0 siblings, 1 reply; 5+ messages in thread
From: FX Coudert @ 2023-10-30 14:19 UTC (permalink / raw)
To: GCC Patches; +Cc: haochen.jiang
[-- Attachment #1: Type: text/plain, Size: 199 bytes --]
Hi,
The test is currently failing on x86_64-apple-darwin with "decimal floating-point not supported for this target”.
Marking the test as requiring dfp fixes the issue.
OK to push?
FX
[-- Attachment #2: 0001-Testsuite-i386-Mark-test-as-requiring-dfp.patch --]
[-- Type: application/octet-stream, Size: 1042 bytes --]
From b1f4a1800405ecfd021a5c4023fbde0ff3266301 Mon Sep 17 00:00:00 2001
From: Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
Date: Mon, 30 Oct 2023 15:14:42 +0100
Subject: [PATCH] Testsuite, i386: Mark test as requiring dfp
Test is currently failing on x86_64-apple-darwin with
"decimal floating-point not supported for this target".
gcc/testsuite/ChangeLog:
* gcc.target/i386/pr111753.c: Require dfp.
---
gcc/testsuite/gcc.target/i386/pr111753.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gcc/testsuite/gcc.target/i386/pr111753.c b/gcc/testsuite/gcc.target/i386/pr111753.c
index 16ceca6ddc6..c2e04d199ab 100644
--- a/gcc/testsuite/gcc.target/i386/pr111753.c
+++ b/gcc/testsuite/gcc.target/i386/pr111753.c
@@ -1,4 +1,4 @@
-/* { dg-do compile { target { ! ia32 } } } */
+/* { dg-do compile { target { dfp && { ! ia32 } } } } */
/* { dg-options "-O2 -mavx512bw -fno-tree-ter -Wno-div-by-zero" } */
typedef int __attribute__((__vector_size__ (8))) v64u8;
--
2.39.3 (Apple Git-145)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Testsuite, i386: Mark test as requiring dfp
2023-10-30 14:19 [PATCH] Testsuite, i386: Mark test as requiring dfp FX Coudert
@ 2023-11-05 20:33 ` FX Coudert
2023-11-05 20:36 ` Iain Sandoe
2023-11-05 20:59 ` Mike Stump
0 siblings, 2 replies; 5+ messages in thread
From: FX Coudert @ 2023-11-05 20:33 UTC (permalink / raw)
To: GCC Patches; +Cc: haochen.jiang
[-- Attachment #1: Type: text/plain, Size: 329 bytes --]
kind ping for this easy patch
> Le 30 oct. 2023 à 15:19, FX Coudert <fxcoudert@gmail.com> a écrit :
>
> Hi,
>
> The test is currently failing on x86_64-apple-darwin with "decimal floating-point not supported for this target”.
> Marking the test as requiring dfp fixes the issue.
>
> OK to push?
>
> FX
>
[-- Attachment #2: 0001-Testsuite-i386-Mark-test-as-requiring-dfp.patch --]
[-- Type: application/octet-stream, Size: 1042 bytes --]
From b1f4a1800405ecfd021a5c4023fbde0ff3266301 Mon Sep 17 00:00:00 2001
From: Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
Date: Mon, 30 Oct 2023 15:14:42 +0100
Subject: [PATCH] Testsuite, i386: Mark test as requiring dfp
Test is currently failing on x86_64-apple-darwin with
"decimal floating-point not supported for this target".
gcc/testsuite/ChangeLog:
* gcc.target/i386/pr111753.c: Require dfp.
---
gcc/testsuite/gcc.target/i386/pr111753.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gcc/testsuite/gcc.target/i386/pr111753.c b/gcc/testsuite/gcc.target/i386/pr111753.c
index 16ceca6ddc6..c2e04d199ab 100644
--- a/gcc/testsuite/gcc.target/i386/pr111753.c
+++ b/gcc/testsuite/gcc.target/i386/pr111753.c
@@ -1,4 +1,4 @@
-/* { dg-do compile { target { ! ia32 } } } */
+/* { dg-do compile { target { dfp && { ! ia32 } } } } */
/* { dg-options "-O2 -mavx512bw -fno-tree-ter -Wno-div-by-zero" } */
typedef int __attribute__((__vector_size__ (8))) v64u8;
--
2.39.3 (Apple Git-145)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Testsuite, i386: Mark test as requiring dfp
2023-11-05 20:33 ` FX Coudert
@ 2023-11-05 20:36 ` Iain Sandoe
2023-11-05 20:59 ` Mike Stump
1 sibling, 0 replies; 5+ messages in thread
From: Iain Sandoe @ 2023-11-05 20:36 UTC (permalink / raw)
To: FX Coudert; +Cc: GCC Patches, haochen.jiang
Hi FX
> On 5 Nov 2023, at 10:33, FX Coudert <fxcoudert@gmail.com> wrote:
>
> kind ping for this easy patch
IMO adding feature tests for features required by a test falls into the “obvious”
category,
Iain
>
>
>> Le 30 oct. 2023 à 15:19, FX Coudert <fxcoudert@gmail.com> a écrit :
>>
>> Hi,
>>
>> The test is currently failing on x86_64-apple-darwin with "decimal floating-point not supported for this target”.
>> Marking the test as requiring dfp fixes the issue.
>>
>> OK to push?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Testsuite, i386: Mark test as requiring dfp
2023-11-05 20:33 ` FX Coudert
2023-11-05 20:36 ` Iain Sandoe
@ 2023-11-05 20:59 ` Mike Stump
1 sibling, 0 replies; 5+ messages in thread
From: Mike Stump @ 2023-11-05 20:59 UTC (permalink / raw)
To: FX Coudert; +Cc: GCC Patches, haochen.jiang
On Nov 5, 2023, at 12:33 PM, FX Coudert <fxcoudert@gmail.com> wrote:
>
> kind ping for this easy patch
>
>
>> Le 30 oct. 2023 à 15:19, FX Coudert <fxcoudert@gmail.com> a écrit :
>>
>> Hi,
>>
>> The test is currently failing on x86_64-apple-darwin with "decimal floating-point not supported for this target”.
>> Marking the test as requiring dfp fixes the issue.
>>
>> OK to push?
Ok.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] Testsuite, i386: mark test as requiring dfp
@ 2023-12-11 8:36 FX Coudert
0 siblings, 0 replies; 5+ messages in thread
From: FX Coudert @ 2023-12-11 8:36 UTC (permalink / raw)
To: GCC Patches
[-- Attachment #1: Type: text/plain, Size: 125 bytes --]
Test currently fails on darwin with:
error: decimal floating-point not supported for this target
Pushed as obvious fix.
FX
[-- Attachment #2: 0001-Testsuite-i386-mark-test-as-requiring-dfp.patch --]
[-- Type: application/octet-stream, Size: 946 bytes --]
From 0af729c69fa977dd2901f698f1ffbaa34a0ebbcf Mon Sep 17 00:00:00 2001
From: Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
Date: Mon, 11 Dec 2023 09:33:47 +0100
Subject: [PATCH] Testsuite, i386: mark test as requiring dfp
Test currently fails on darwin with:
error: decimal floating-point not supported for this target
gcc/testsuite/ChangeLog:
* gcc.target/i386/pr112445.c: Require dfp.
---
gcc/testsuite/gcc.target/i386/pr112445.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/gcc/testsuite/gcc.target/i386/pr112445.c b/gcc/testsuite/gcc.target/i386/pr112445.c
index 91ed4212290..1434ab483ff 100644
--- a/gcc/testsuite/gcc.target/i386/pr112445.c
+++ b/gcc/testsuite/gcc.target/i386/pr112445.c
@@ -1,4 +1,5 @@
/* { dg-do compile { target int128 } } */
+/* { dg-require-effective-target dfp } */
/* { dg-options "-O -march=cascadelake -fwrapv" } */
typedef _Decimal64 d64;
--
2.39.3 (Apple Git-145)
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-12-11 8:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-30 14:19 [PATCH] Testsuite, i386: Mark test as requiring dfp FX Coudert
2023-11-05 20:33 ` FX Coudert
2023-11-05 20:36 ` Iain Sandoe
2023-11-05 20:59 ` Mike Stump
2023-12-11 8:36 [PATCH] Testsuite, i386: mark " FX Coudert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).