From: Alexander Monakov <amonakov@ispras.ru>
To: Hongyu Wang <wwwhhhyyy333@gmail.com>
Cc: Jonathan Wakely <jwakely@redhat.com>,
Hongyu Wang <hongyu.wang@intel.com>,
gcc-patches@gcc.gnu.org, hongtao.liu@intel.com,
ubizjak@gmail.com
Subject: Re: [PATCH] doc: Reword the description of -mrelax-cmpxchg-loop [PR 107676]
Date: Wed, 16 Nov 2022 10:51:42 +0300 (MSK) [thread overview]
Message-ID: <36b75ee4-5f97-16ab-8d9d-a060e996b5da@ispras.ru> (raw)
In-Reply-To: <CA+OydW=gyAZN8C42nMxxK7V0U8xRtDxADehsYSLSNhVxoC3fLQ@mail.gmail.com>
On Wed, 16 Nov 2022, Hongyu Wang wrote:
> > When emitting a compare-and-swap loop for @ref{__sync Builtins}
> > and @ref{__atomic Builtins} lacking a native instruction, optimize
> > for the highly contended case by issuing an atomic load before the
> > @code{CMPXCHG} instruction, and using the @code{PAUSE} instruction
> > to save CPU power when restarting the loop.
>
> Thanks for the correction, it looks quite clear now! Here is the
> updated patch, ok for trunk?
Please use 'git commit --author' to indicate authorship of the patch
(or simply let me push it once approved).
Jonathan, please let us know if the above wording looks fine to you?
Mainly I'm asking if '... and using' or '... and use' is easier to read.
Alexander
next prev parent reply other threads:[~2022-11-16 7:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 3:35 Hongyu Wang
2022-11-15 10:53 ` Jonathan Wakely
2022-11-15 13:28 ` Alexander Monakov
2022-11-15 13:44 ` Jonathan Wakely
2022-11-15 13:59 ` Alexander Monakov
2022-11-16 5:15 ` Hongyu Wang
2022-11-16 7:51 ` Alexander Monakov [this message]
2022-11-16 8:29 ` Hongyu Wang
2022-11-16 10:51 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36b75ee4-5f97-16ab-8d9d-a060e996b5da@ispras.ru \
--to=amonakov@ispras.ru \
--cc=gcc-patches@gcc.gnu.org \
--cc=hongtao.liu@intel.com \
--cc=hongyu.wang@intel.com \
--cc=jwakely@redhat.com \
--cc=ubizjak@gmail.com \
--cc=wwwhhhyyy333@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).