public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH] testsuite: skip gcc.target/i386/pr106910-1.c test when using newlib
@ 2023-11-06 10:57 Marc Poulhiès
  2023-12-01 16:24 ` Marc Poulhiès
  2023-12-01 17:17 ` Mike Stump
  0 siblings, 2 replies; 3+ messages in thread
From: Marc Poulhiès @ 2023-11-06 10:57 UTC (permalink / raw)
  To: gcc-patches; +Cc: Marc Poulhiès

Using newlib produces a different codegen because the support for c99
differs (see libc_has_function hook).

gcc/testsuite/ChangeLog:

	* gcc.target/i386/pr106910-1.c: Disable for newlib.
---
Tested on x86_64-linux and x86_64-elf.

OK for master?

 gcc/testsuite/gcc.target/i386/pr106910-1.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gcc/testsuite/gcc.target/i386/pr106910-1.c b/gcc/testsuite/gcc.target/i386/pr106910-1.c
index c7685a32183..00c93f444b6 100644
--- a/gcc/testsuite/gcc.target/i386/pr106910-1.c
+++ b/gcc/testsuite/gcc.target/i386/pr106910-1.c
@@ -1,4 +1,6 @@
+
 /* { dg-do compile { target { ! ia32 } } } */
+/* { dg-skip-if "newlib libc math causes different codegen" { newlib } } */
 /* { dg-options "-msse4.1 -O2 -Ofast" } */
 /* { dg-final { scan-assembler-times "roundps" 9 } } */
 /* { dg-final { scan-assembler-times "cvtps2dq" 1 } } */
-- 
2.42.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] testsuite: skip gcc.target/i386/pr106910-1.c test when using newlib
  2023-11-06 10:57 [PATCH] testsuite: skip gcc.target/i386/pr106910-1.c test when using newlib Marc Poulhiès
@ 2023-12-01 16:24 ` Marc Poulhiès
  2023-12-01 17:17 ` Mike Stump
  1 sibling, 0 replies; 3+ messages in thread
From: Marc Poulhiès @ 2023-12-01 16:24 UTC (permalink / raw)
  To: Marc Poulhiès; +Cc: gcc-patches


Marc Poulhiès <poulhies@adacore.com> writes:

> Using newlib produces a different codegen because the support for c99
> differs (see libc_has_function hook).
>
> gcc/testsuite/ChangeLog:
>
> 	* gcc.target/i386/pr106910-1.c: Disable for newlib.
> ---
> Tested on x86_64-linux and x86_64-elf.
>
> OK for master?
>
>  gcc/testsuite/gcc.target/i386/pr106910-1.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/gcc/testsuite/gcc.target/i386/pr106910-1.c b/gcc/testsuite/gcc.target/i386/pr106910-1.c
> index c7685a32183..00c93f444b6 100644
> --- a/gcc/testsuite/gcc.target/i386/pr106910-1.c
> +++ b/gcc/testsuite/gcc.target/i386/pr106910-1.c
> @@ -1,4 +1,6 @@
> +
>  /* { dg-do compile { target { ! ia32 } } } */
> +/* { dg-skip-if "newlib libc math causes different codegen" { newlib } } */
>  /* { dg-options "-msse4.1 -O2 -Ofast" } */
>  /* { dg-final { scan-assembler-times "roundps" 9 } } */
>  /* { dg-final { scan-assembler-times "cvtps2dq" 1 } } */

Ping.

Thanks,
Marc

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] testsuite: skip gcc.target/i386/pr106910-1.c test when using newlib
  2023-11-06 10:57 [PATCH] testsuite: skip gcc.target/i386/pr106910-1.c test when using newlib Marc Poulhiès
  2023-12-01 16:24 ` Marc Poulhiès
@ 2023-12-01 17:17 ` Mike Stump
  1 sibling, 0 replies; 3+ messages in thread
From: Mike Stump @ 2023-12-01 17:17 UTC (permalink / raw)
  To: Marc Poulhiès; +Cc: gcc-patches

On Nov 6, 2023, at 2:57 AM, Marc Poulhiès <poulhies@adacore.com> wrote:
> 
> Using newlib produces a different codegen because the support for c99
> differs (see libc_has_function hook).
> 
> gcc/testsuite/ChangeLog:
> 
> 	* gcc.target/i386/pr106910-1.c: Disable for newlib.
> ---
> Tested on x86_64-linux and x86_64-elf.
> 
> OK for master?

Ok, but nix the first blank line?

> gcc/testsuite/gcc.target/i386/pr106910-1.c | 2 ++
> 1 file changed, 2 insertions(+)
> 
> diff --git a/gcc/testsuite/gcc.target/i386/pr106910-1.c b/gcc/testsuite/gcc.target/i386/pr106910-1.c
> index c7685a32183..00c93f444b6 100644
> --- a/gcc/testsuite/gcc.target/i386/pr106910-1.c
> +++ b/gcc/testsuite/gcc.target/i386/pr106910-1.c
> @@ -1,4 +1,6 @@
> +

This one.

> /* { dg-do compile { target { ! ia32 } } } */
> +/* { dg-skip-if "newlib libc math causes different codegen" { newlib } } */
> /* { dg-options "-msse4.1 -O2 -Ofast" } */
> /* { dg-final { scan-assembler-times "roundps" 9 } } */
> /* { dg-final { scan-assembler-times "cvtps2dq" 1 } } */

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-12-01 17:17 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-06 10:57 [PATCH] testsuite: skip gcc.target/i386/pr106910-1.c test when using newlib Marc Poulhiès
2023-12-01 16:24 ` Marc Poulhiès
2023-12-01 17:17 ` Mike Stump

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).