* Re: [11 PATCH] libiberty, Darwin: Fix a build warning. [PR112823]
@ 2023-12-02 9:13 FX Coudert
0 siblings, 0 replies; 4+ messages in thread
From: FX Coudert @ 2023-12-02 9:13 UTC (permalink / raw)
To: GCC Patches; +Cc: Iain Sandoe, sam
> Thanks. I can't push it myself - could you do that for me?
Pushed.
FX
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [11 PATCH] libiberty, Darwin: Fix a build warning. [PR112823]
2023-12-02 7:20 ` Iain Sandoe
@ 2023-12-02 7:31 ` Sam James
0 siblings, 0 replies; 4+ messages in thread
From: Sam James @ 2023-12-02 7:31 UTC (permalink / raw)
To: Iain Sandoe; +Cc: Sam James, GCC Patches, fw
Iain Sandoe <iain@sandoe.co.uk> writes:
> HI Sam,
Hi Iain,
>
> I think this qualifies as obvious (it’s on my list, but I did not get to it yet,
> so go ahead).
Thanks. I can't push it myself - could you do that for me?
thanks again,
sam
>
> Iain
>
>> On 2 Dec 2023, at 05:30, Sam James <sam@gentoo.org> wrote:
>>
>> From: Iain Sandoe <iain@sandoe.co.uk>
>>
>> r12-3005-g220c410162ebece4f missed a cast for the set_32 call.
>> Fixed thus.
>>
>> Signed-off-by: Iain Sandoe <iain@sandoe.co.uk>
>> Signed-off-by: Sam James <sam@gentoo.org>
>>
>> libiberty/ChangeLog:
>> PR other/112823
>> * simple-object-mach-o.c (simple_object_mach_o_write_segment):
>> Cast the first argument to set_32 as needed.
>>
>> (cherry picked from commit 38757aa88735ab2e511bc428e2407a5a5e9fa0be)
>> ---
>> libiberty/simple-object-mach-o.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/libiberty/simple-object-mach-o.c b/libiberty/simple-object-mach-o.c
>> index 72b69d19c216..a8869e7c6395 100644
>> --- a/libiberty/simple-object-mach-o.c
>> +++ b/libiberty/simple-object-mach-o.c
>> @@ -1228,7 +1228,7 @@ simple_object_mach_o_write_segment (simple_object_write *sobj, int descriptor,
>> /* Swap the indices, if required. */
>>
>> for (i = 0; i < (nsects_in * 4); ++i)
>> - set_32 (&index[i], index[i]);
>> + set_32 ((unsigned char *) &index[i], index[i]);
>>
>> sechdr_offset += sechdrsize;
>>
>> --
>> 2.43.0
>>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [11 PATCH] libiberty, Darwin: Fix a build warning. [PR112823]
2023-12-02 5:30 Sam James
@ 2023-12-02 7:20 ` Iain Sandoe
2023-12-02 7:31 ` Sam James
0 siblings, 1 reply; 4+ messages in thread
From: Iain Sandoe @ 2023-12-02 7:20 UTC (permalink / raw)
To: Sam James; +Cc: GCC Patches, fw
HI Sam,
I think this qualifies as obvious (it’s on my list, but I did not get to it yet,
so go ahead).
Iain
> On 2 Dec 2023, at 05:30, Sam James <sam@gentoo.org> wrote:
>
> From: Iain Sandoe <iain@sandoe.co.uk>
>
> r12-3005-g220c410162ebece4f missed a cast for the set_32 call.
> Fixed thus.
>
> Signed-off-by: Iain Sandoe <iain@sandoe.co.uk>
> Signed-off-by: Sam James <sam@gentoo.org>
>
> libiberty/ChangeLog:
> PR other/112823
> * simple-object-mach-o.c (simple_object_mach_o_write_segment):
> Cast the first argument to set_32 as needed.
>
> (cherry picked from commit 38757aa88735ab2e511bc428e2407a5a5e9fa0be)
> ---
> libiberty/simple-object-mach-o.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libiberty/simple-object-mach-o.c b/libiberty/simple-object-mach-o.c
> index 72b69d19c216..a8869e7c6395 100644
> --- a/libiberty/simple-object-mach-o.c
> +++ b/libiberty/simple-object-mach-o.c
> @@ -1228,7 +1228,7 @@ simple_object_mach_o_write_segment (simple_object_write *sobj, int descriptor,
> /* Swap the indices, if required. */
>
> for (i = 0; i < (nsects_in * 4); ++i)
> - set_32 (&index[i], index[i]);
> + set_32 ((unsigned char *) &index[i], index[i]);
>
> sechdr_offset += sechdrsize;
>
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [11 PATCH] libiberty, Darwin: Fix a build warning. [PR112823]
@ 2023-12-02 5:30 Sam James
2023-12-02 7:20 ` Iain Sandoe
0 siblings, 1 reply; 4+ messages in thread
From: Sam James @ 2023-12-02 5:30 UTC (permalink / raw)
To: gcc-patches; +Cc: fw, Iain Sandoe, Sam James
From: Iain Sandoe <iain@sandoe.co.uk>
r12-3005-g220c410162ebece4f missed a cast for the set_32 call.
Fixed thus.
Signed-off-by: Iain Sandoe <iain@sandoe.co.uk>
Signed-off-by: Sam James <sam@gentoo.org>
libiberty/ChangeLog:
PR other/112823
* simple-object-mach-o.c (simple_object_mach_o_write_segment):
Cast the first argument to set_32 as needed.
(cherry picked from commit 38757aa88735ab2e511bc428e2407a5a5e9fa0be)
---
libiberty/simple-object-mach-o.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libiberty/simple-object-mach-o.c b/libiberty/simple-object-mach-o.c
index 72b69d19c216..a8869e7c6395 100644
--- a/libiberty/simple-object-mach-o.c
+++ b/libiberty/simple-object-mach-o.c
@@ -1228,7 +1228,7 @@ simple_object_mach_o_write_segment (simple_object_write *sobj, int descriptor,
/* Swap the indices, if required. */
for (i = 0; i < (nsects_in * 4); ++i)
- set_32 (&index[i], index[i]);
+ set_32 ((unsigned char *) &index[i], index[i]);
sechdr_offset += sechdrsize;
--
2.43.0
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-12-02 9:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-02 9:13 [11 PATCH] libiberty, Darwin: Fix a build warning. [PR112823] FX Coudert
-- strict thread matches above, loose matches on Subject: below --
2023-12-02 5:30 Sam James
2023-12-02 7:20 ` Iain Sandoe
2023-12-02 7:31 ` Sam James
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).