From: Richard Earnshaw <Richard.Earnshaw@foss.arm.com>
To: Srinath Parvathaneni <srinath.parvathaneni@arm.com>,
gcc-patches@gcc.gnu.org
Cc: nd@arm.com, richard.earnshaw@arm.com, kyrylo.tkachov@arm.com
Subject: Re: [PATCH][GCC] arm: Optimize arm-mlib.h header inclusion (pr108505).
Date: Wed, 8 Feb 2023 09:45:47 +0000 [thread overview]
Message-ID: <3a08db7e-be26-e3e1-6b1f-c008ab040dda@foss.arm.com> (raw)
In-Reply-To: <e6ca16d1-28d9-463e-bbed-ce6dfad7a887@AZ-NEU-EX04.Arm.com>
On 27/01/2023 17:44, Srinath Parvathaneni via Gcc-patches wrote:
> Hello,
>
> I have committed a fix [1] into gcc trunk for a build issue mentioned in pr108505 and
> latter received few upstream comments proposing more robust fix for this issue.
>
> In this patch I'm addressing those comments and sending this as a followup patch.
>
> Regression tested on arm-none-eabi target and found no regressions.
>
> Ok for master?
>
OK. But please correct the syntax for the PR in the subject. It should
be "[PR...]" not "(PR...)".
R.
> [1] https://gcc.gnu.org/pipermail/gcc-patches/2023-January/610513.html
>
> Regards,
> Srinath.
>
> gcc/ChangeLog:
>
> 2023-01-27 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
>
> PR target/108505
> * config.gcc (tm_mlib_file): Define new variable.
>
>
> ############### Attachment also inlined for ease of reply ###############
>
>
> diff --git a/gcc/config.gcc b/gcc/config.gcc
> index 89f56047cfe3126bc6c8e90c8b4840dea13538f9..2aab92bbfd8b4088259ebf9b565af8e8bbef1122 100644
> --- a/gcc/config.gcc
> +++ b/gcc/config.gcc
> @@ -4355,6 +4355,7 @@ case "${target}" in
> case ${arm_multilib} in
> aprofile|rmprofile)
> tmake_profile_file="arm/t-multilib"
> + tm_mlib_file="arm/arm-mlib.h"
> ;;
> @*)
> ml=`echo "X$arm_multilib" | sed '1s,^X@,,'`
> @@ -4393,7 +4394,7 @@ case "${target}" in
> # through to the multilib selector
> with_float="soft"
> tmake_file="${tmake_file} ${tmake_profile_file}"
> - tm_file="$tm_file arm/arm-mlib.h"
> + tm_file="$tm_file $tm_mlib_file"
> TM_MULTILIB_CONFIG="$with_multilib_list"
> fi
> fi
>
>
>
prev parent reply other threads:[~2023-02-08 9:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-27 17:44 Srinath Parvathaneni
2023-02-02 12:16 ` Srinath Parvathaneni
2023-02-08 9:45 ` Richard Earnshaw [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a08db7e-be26-e3e1-6b1f-c008ab040dda@foss.arm.com \
--to=richard.earnshaw@foss.arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=kyrylo.tkachov@arm.com \
--cc=nd@arm.com \
--cc=richard.earnshaw@arm.com \
--cc=srinath.parvathaneni@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).