Re: [PATCHv2, gfortran] Escalate failure when Hollerith constant to real conversion fails [PR103628]

["Kewen.Lin" <linkw@linux.ibm.com>]

Hi Haochen,

on 2023/3/3 20:54, Tobias Burnus wrote:
> Hi Haochen,
> 
> On 03.03.23 10:56, HAO CHEN GUI via Gcc-patches wrote:
>> Sure, I will merge it into the patch and do the regression test.
> Thanks :-)
>> Additionally, Kewen suggested:
>>>> Since this test case is powerpc only, I think it can be moved to gcc/testsuite/gcc.target/powerpc/ppc-fortran/ppc-fortran.expgcc.target/powerpc/ppc-fortran.
>>> Which sounds reasonable.
>> Test cases under gcc.target are tested by check-gcc-c. It greps "warning"
>> and "error" (C style, lower case) from the output while check-gcc-fortran
>> greps "Warning" and "Error" (upper case). As the test case needs to check
>> the "Warning" and "Error" messages. I have to put it in gfortran.dg
>> directory. What's your opinion?
> 
> Thanks for digging and giving a reason.

+1!

I just posted one patch[1] to make ppc-fortran.exp support the need of your
patch here, I verified it can work for this revision, could you double check
with your updated revision?

[1] https://gcc.gnu.org/pipermail/gcc-patches/2023-March/613442.html

> 
> Looks as if at some point, adapting
> gcc/testsuite/gcc.target/powerpc/ppc-fortran/ppc-fortran.exp to handle
> this as well could make sense.
> 
> But placing it - as you did - under gcc/testsuite/gfortran.dg is fine
> and surely the simpler solution. Thus, leave it as it.

Yeah, either way works for me.

Thanks again!

BR,
Kewen