public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "Kewen.Lin" <linkw@linux.ibm.com>
To: HAO CHEN GUI <guihaoc@linux.ibm.com>
Cc: Segher Boessenkool <segher@kernel.crashing.org>,
	David <dje.gcc@gmail.com>, Peter Bergner <bergner@linux.ibm.com>,
	Tobias Burnus <tobias@codesourcery.com>,
	gcc-patches <gcc-patches@gcc.gnu.org>,
	fortran <fortran@gcc.gnu.org>
Subject: Re: [PATCHv2, gfortran] Escalate failure when Hollerith constant to real conversion fails [PR103628]
Date: Mon, 6 Mar 2023 17:35:13 +0800	[thread overview]
Message-ID: <3d8d0357-846b-a549-7f6f-f19e1d531378@linux.ibm.com> (raw)
In-Reply-To: <35a11e42-c5d7-3e56-3197-646dabddee23@codesourcery.com>

Hi Haochen,

on 2023/3/3 20:54, Tobias Burnus wrote:
> Hi Haochen,
> 
> On 03.03.23 10:56, HAO CHEN GUI via Gcc-patches wrote:
>> Sure, I will merge it into the patch and do the regression test.
> Thanks :-)
>> Additionally, Kewen suggested:
>>>> Since this test case is powerpc only, I think it can be moved to gcc/testsuite/gcc.target/powerpc/ppc-fortran/ppc-fortran.expgcc.target/powerpc/ppc-fortran.
>>> Which sounds reasonable.
>> Test cases under gcc.target are tested by check-gcc-c. It greps "warning"
>> and "error" (C style, lower case) from the output while check-gcc-fortran
>> greps "Warning" and "Error" (upper case). As the test case needs to check
>> the "Warning" and "Error" messages. I have to put it in gfortran.dg
>> directory. What's your opinion?
> 
> Thanks for digging and giving a reason.

+1!

I just posted one patch[1] to make ppc-fortran.exp support the need of your
patch here, I verified it can work for this revision, could you double check
with your updated revision?

[1] https://gcc.gnu.org/pipermail/gcc-patches/2023-March/613442.html

> 
> Looks as if at some point, adapting
> gcc/testsuite/gcc.target/powerpc/ppc-fortran/ppc-fortran.exp to handle
> this as well could make sense.
> 
> But placing it - as you did - under gcc/testsuite/gfortran.dg is fine
> and surely the simpler solution. Thus, leave it as it.

Yeah, either way works for me.

Thanks again!

BR,
Kewen

      reply	other threads:[~2023-03-06  9:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-03  9:12 HAO CHEN GUI
2023-03-03  9:16 ` HAO CHEN GUI
2023-03-03  9:29 ` Tobias Burnus
2023-03-03  9:56   ` HAO CHEN GUI
2023-03-03 12:54     ` Tobias Burnus
2023-03-06  9:35       ` Kewen.Lin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3d8d0357-846b-a549-7f6f-f19e1d531378@linux.ibm.com \
    --to=linkw@linux.ibm.com \
    --cc=bergner@linux.ibm.com \
    --cc=dje.gcc@gmail.com \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=guihaoc@linux.ibm.com \
    --cc=segher@kernel.crashing.org \
    --cc=tobias@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).