Re: [PATCHv2, gfortran] Escalate failure when Hollerith constant to real conversion fails [PR103628]

[Tobias Burnus <tobias@codesourcery.com>]

Hi Haochen,

On 03.03.23 10:56, HAO CHEN GUI via Gcc-patches wrote:
> Sure, I will merge it into the patch and do the regression test.
Thanks :-)
> Additionally, Kewen suggested:
>>> Since this test case is powerpc only, I think it can be moved to gcc/testsuite/gcc.target/powerpc/ppc-fortran/ppc-fortran.expgcc.target/powerpc/ppc-fortran.
>> Which sounds reasonable.
> Test cases under gcc.target are tested by check-gcc-c. It greps "warning"
> and "error" (C style, lower case) from the output while check-gcc-fortran
> greps "Warning" and "Error" (upper case). As the test case needs to check
> the "Warning" and "Error" messages. I have to put it in gfortran.dg
> directory. What's your opinion?

Thanks for digging and giving a reason.

Looks as if at some point, adapting
gcc/testsuite/gcc.target/powerpc/ppc-fortran/ppc-fortran.exp to handle
this as well could make sense.

But placing it - as you did - under gcc/testsuite/gfortran.dg is fine
and surely the simpler solution. Thus, leave it as it.

Thanks,

Tobias


>
> Gui Haochen
> Thanks
-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955