From: Richard Earnshaw <Richard.Earnshaw@foss.arm.com>
To: Andrea Corallo <andrea.corallo@arm.com>,
Andrea Corallo via Gcc-patches <gcc-patches@gcc.gnu.org>
Cc: Richard Earnshaw <Richard.Earnshaw@arm.com>, nd <nd@arm.com>
Subject: Re: [PATCH 1/12] arm: Make mbranch-protection opts parsing common to AArch32/64
Date: Fri, 1 Jul 2022 11:49:50 +0100 [thread overview]
Message-ID: <3e2f8ff9-ddfc-a829-fa32-b7699412415d@foss.arm.com> (raw)
In-Reply-To: <gkrilqtwp6m.fsf@arm.com>
On 28/04/2022 10:08, Andrea Corallo via Gcc-patches wrote:
> Hi all,
>
> This change refactors all the mbranch-protection option parsing code and
> types to make it common to both AArch32 and AArch64 backends.
>
> This change also pulls in some supporting types from AArch64 to make
> it common (aarch_parse_opt_result).
>
> The significant changes in this patch are the movement of all branch
> protection parsing routines from aarch64.c to aarch-common.c and
> supporting data types and static data structures.
>
> This patch also pre-declares variables and types required in the
> aarch32 back-end for moved variables for function sign scope and key
> to prepare for the impending series of patches that support parsing
> the feature mbranch-protection in the aarch32 back-end.
>
> This patch implements the changes requested and was pre-approved here
> <https://gcc.gnu.org/pipermail/gcc-patches/2021-December/586139.html>.
>
> gcc/ChangeLog:
>
> * common/config/aarch64/aarch64-common.cc: Include aarch-common.h.
> (all_architectures): Fix comment.
> (aarch64_parse_extension): Rename return type, enum value names.
> * config/aarch64/aarch64-c.cc (aarch64_update_cpp_builtins): Rename
> factored out aarch_ra_sign_scope and aarch_ra_sign_key variables.
> Also rename corresponding enum values.
> * config/aarch64/aarch64-opts.h (aarch64_function_type): Factor
> out aarch64_function_type and move it to common code as
> aarch_function_type in aarch-common.h.
> * config/aarch64/aarch64-protos.h: Include common types header,
> move out types aarch64_parse_opt_result and aarch64_key_type to
> aarch-common.h
> * config/aarch64/aarch64.cc: Move mbranch-protection parsing types
> and functions out into aarch-common.h and aarch-common.cc. Fix up
> all the name changes resulting from the move.
> * config/aarch64/aarch64.md: Fix up aarch64_ra_sign_key type name change
> and enum value.
> * config/aarch64/aarch64.opt: Include aarch-common.h to import
> type move. Fix up name changes from factoring out common code and
> data.
> * config/arm/aarch-common-protos.h: Export factored out routines to both
> backends.
> * config/arm/aarch-common.cc: Include newly factored out types. Move all
> mbranch-protection code and data structures from aarch64.cc.
> * config/arm/aarch-common.h: New header that declares types shared
> between aarch32 and aarch64 backends.
> * config/arm/arm-protos.h: Declare types and variables that are
> made common to aarch64 and aarch32 backends - aarch_ra_sign_key,
> aarch_ra_sign_scope and aarch_enable_bti.
>
> Co-Authored-By: Tejas Belagod <tbelagod@arm.com>
>
OK, but please wait for the rest of this series to be approved before
applying.
R.
next prev parent reply other threads:[~2022-07-01 10:49 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-28 8:39 [PATCH 0/12] arm: Enables return address verification and branch target identification on Cortex-M Andrea Corallo
2022-04-28 9:08 ` [PATCH 1/12] arm: Make mbranch-protection opts parsing common to AArch32/64 Andrea Corallo
2022-07-01 10:49 ` Richard Earnshaw [this message]
2022-04-28 9:37 ` [PATCH 2/12] arm: Add Armv8.1-M Mainline target feature +pacbti Andrea Corallo
2022-07-01 10:51 ` Richard Earnshaw
2022-04-28 9:38 ` [PATCH 3/12] arm: Add option -mbranch-protection Andrea Corallo
2022-07-01 10:59 ` Richard Earnshaw
2022-07-04 9:27 ` [PATCH 3/12 V2] " Andrea Corallo
2022-07-04 10:55 ` Richard Earnshaw
2022-04-28 9:40 ` [PATCH 4/12] arm: Add testsuite library support for PACBTI target Andrea Corallo
2022-07-01 13:03 ` Richard Earnshaw
2022-07-01 14:17 ` Richard Earnshaw
2022-07-04 14:47 ` Andrea Corallo
2022-07-05 10:05 ` Richard Earnshaw
2022-04-28 9:42 ` [PATCH 5/12] arm: Implement target feature macros for PACBTI Andrea Corallo
2022-07-01 14:26 ` Richard Earnshaw
2022-07-12 15:45 ` [PATCH 5/12 V2] " Andrea Corallo
2022-07-21 11:01 ` Richard Earnshaw
2022-07-22 10:35 ` [PATCH 5/12 V3] " Andrea Corallo
2022-07-22 14:34 ` [PATCH 5/12 V4] " Andrea Corallo
2022-04-28 9:44 ` [PATCH 6/12] arm: Add pointer authentication for stack-unwinding runtime Andrea Corallo
2022-07-01 14:41 ` Richard Earnshaw
2022-11-09 11:17 ` [PATCH 6/12 V2] " Andrea Corallo
2022-04-28 9:45 ` [PATCH 7/12] arm: Emit build attributes for PACBTI target feature Andrea Corallo
2022-07-01 14:49 ` Richard Earnshaw
2022-07-13 8:58 ` [PATCH 7/12 V2] " Andrea Corallo
2022-07-21 11:03 ` Richard Earnshaw
2022-07-22 14:57 ` Andrea Corallo
2022-04-28 9:46 ` [PATCH 8/12] arm: Introduce multilibs " Andrea Corallo
2022-06-01 12:32 ` [PATCH 8/12 V2] " Andrea Corallo
2022-07-01 14:54 ` Richard Earnshaw
2022-07-01 14:57 ` Richard Earnshaw
2022-07-21 9:04 ` [PATCH 8/12 V3] " Andrea Corallo
2022-07-21 11:09 ` Richard Earnshaw
2022-04-28 9:48 ` [PATCH 9/12] arm: Make libgcc bti compatible Andrea Corallo
2022-07-01 15:03 ` Richard Earnshaw
2022-07-21 9:17 ` [PATCH 9/12 V2] " Andrea Corallo
2022-07-21 11:41 ` Richard Earnshaw
2022-07-22 15:09 ` Andrea Corallo
2022-07-25 10:41 ` Richard Earnshaw
2022-12-12 14:54 ` Andrea Corallo
2022-04-28 9:50 ` [PATCH 10/12] arm: Implement cortex-M return signing address codegen Andrea Corallo
2022-06-28 9:17 ` [PATCH 10/12 V2] " Andrea Corallo
2022-07-01 15:43 ` Richard Earnshaw
2022-08-08 9:33 ` Andrea Corallo
2022-10-20 14:53 ` Kyrylo Tkachov
2022-04-28 9:51 ` [PATCH 11/12] aarch64: Make bti pass generic so it can be used by the arm backend Andrea Corallo
2022-05-06 8:23 ` Richard Sandiford
2022-07-01 15:53 ` Richard Earnshaw
2022-04-28 9:53 ` [PATCH 12/12] arm: implement bti injection Andrea Corallo
2022-06-28 9:21 ` [PATCH 12/12 V2] " Andrea Corallo
2022-07-01 16:04 ` Richard Earnshaw
2022-06-01 12:34 ` [PATCH 0/12] arm: Enables return address verification and branch target identification on Cortex-M Andrea Corallo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e2f8ff9-ddfc-a829-fa32-b7699412415d@foss.arm.com \
--to=richard.earnshaw@foss.arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=andrea.corallo@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).