* [wwwdocs] gcc-14/changes.html (AMD GCN): Mention gfx1036 support
@ 2024-04-15 10:03 Tobias Burnus
2024-04-15 10:06 ` Andrew Stubbs
2024-04-15 12:00 ` Richard Biener
0 siblings, 2 replies; 5+ messages in thread
From: Tobias Burnus @ 2024-04-15 10:03 UTC (permalink / raw)
To: gcc-patches, Andrew Stubbs; +Cc: Gerald Pfeifer
[-- Attachment #1: Type: text/plain, Size: 640 bytes --]
I experimented with some variants to make clearer that each of RDNA2 and
RNDA3 applies to two card types, but at the end I settled on the
fewest-word version.
Comments, remarks, suggestions? (To this change or in general?)
Current version: https://gcc.gnu.org/gcc-14/changes.html#amdgcn
Compiler flags, listing the the gfx* cards:
https://gcc.gnu.org/onlinedocs/gcc/AMD-GCN-Options.html
Tobias
PS: On the compiler side, I am looking forward to a .def file which
reduces the number of files to change when adding a new gfx* card, given
that we have doubled the number of entries. [Well, 1 missing but I know
of one WIP addition.]
[-- Attachment #2: wwwdocs-gfx1036.diff --]
[-- Type: text/x-patch, Size: 806 bytes --]
gcc-14/changes.html (AMD GCN): Mention gfx1036 support
diff --git a/htdocs/gcc-14/changes.html b/htdocs/gcc-14/changes.html
index 8ac08e9a..b4c602a5 100644
--- a/htdocs/gcc-14/changes.html
+++ b/htdocs/gcc-14/changes.html
@@ -623,8 +623,9 @@ a work-in-progress.</p>
<h3 id="amdgcn">AMD Radeon (GCN)</h3>
<ul>
- <li>Initial support for the AMD Radeon <code>gfx1030</code> (RDNA2),
- <code>gfx1100</code> and <code>gfx1103</code> (RDNA3) devices has been
+ <li>Initial support for the AMD Radeon <code>gfx1030</code>,
+ <code>gfx1036</code> (RDNA2), <code>gfx1100</code> and
+ <code>gfx1103</code> (RDNA3) devices has been
added. LLVM 15+ (assembler and linker) is <a
href="https://gcc.gnu.org/install/specific.html#amdgcn-x-amdhsa">required
to support <code>GFX11</code></a>.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [wwwdocs] gcc-14/changes.html (AMD GCN): Mention gfx1036 support
2024-04-15 10:03 [wwwdocs] gcc-14/changes.html (AMD GCN): Mention gfx1036 support Tobias Burnus
@ 2024-04-15 10:06 ` Andrew Stubbs
2024-04-15 12:00 ` Richard Biener
1 sibling, 0 replies; 5+ messages in thread
From: Andrew Stubbs @ 2024-04-15 10:06 UTC (permalink / raw)
To: Tobias Burnus, gcc-patches; +Cc: Gerald Pfeifer
On 15/04/2024 11:03, Tobias Burnus wrote:
> I experimented with some variants to make clearer that each of RDNA2 and
> RNDA3 applies to two card types, but at the end I settled on the
> fewest-word version.
>
> Comments, remarks, suggestions? (To this change or in general?)
>
> Current version: https://gcc.gnu.org/gcc-14/changes.html#amdgcn
>
> Compiler flags, listing the the gfx* cards:
> https://gcc.gnu.org/onlinedocs/gcc/AMD-GCN-Options.html
>
> Tobias
>
> PS: On the compiler side, I am looking forward to a .def file which
> reduces the number of files to change when adding a new gfx* card, given
> that we have doubled the number of entries. [Well, 1 missing but I know
> of one WIP addition.]
LGTM
Andrew
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [wwwdocs] gcc-14/changes.html (AMD GCN): Mention gfx1036 support
2024-04-15 10:03 [wwwdocs] gcc-14/changes.html (AMD GCN): Mention gfx1036 support Tobias Burnus
2024-04-15 10:06 ` Andrew Stubbs
@ 2024-04-15 12:00 ` Richard Biener
2024-04-15 12:27 ` Andrew Stubbs
2024-04-15 17:59 ` Tobias Burnus
1 sibling, 2 replies; 5+ messages in thread
From: Richard Biener @ 2024-04-15 12:00 UTC (permalink / raw)
To: Tobias Burnus; +Cc: gcc-patches, Andrew Stubbs, Gerald Pfeifer
On Mon, Apr 15, 2024 at 12:04 PM Tobias Burnus <tburnus@baylibre.com> wrote:
>
> I experimented with some variants to make clearer that each of RDNA2 and
> RNDA3 applies to two card types, but at the end I settled on the
> fewest-word version.
>
> Comments, remarks, suggestions? (To this change or in general?)
>
> Current version: https://gcc.gnu.org/gcc-14/changes.html#amdgcn
>
> Compiler flags, listing the the gfx* cards:
> https://gcc.gnu.org/onlinedocs/gcc/AMD-GCN-Options.html
>
> Tobias
>
> PS: On the compiler side, I am looking forward to a .def file which
> reduces the number of files to change when adding a new gfx* card, given
> that we have doubled the number of entries. [Well, 1 missing but I know
> of one WIP addition.]
I do wonder whether hot-patching the ELF header from the libgomp plugin
with the actual micro-subarch would be possible to make the driver happy.
We do query the device ISA when initializing the device so we should
be able to massage the ELF header of the object in GOMP_OFFLOAD_load_image
at least within some constraints (ideally we'd mark the ELF object as to
be matched with a device in some group).
Richard.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [wwwdocs] gcc-14/changes.html (AMD GCN): Mention gfx1036 support
2024-04-15 12:00 ` Richard Biener
@ 2024-04-15 12:27 ` Andrew Stubbs
2024-04-15 17:59 ` Tobias Burnus
1 sibling, 0 replies; 5+ messages in thread
From: Andrew Stubbs @ 2024-04-15 12:27 UTC (permalink / raw)
To: Richard Biener, Tobias Burnus; +Cc: gcc-patches, Gerald Pfeifer
On 15/04/2024 13:00, Richard Biener wrote:
> On Mon, Apr 15, 2024 at 12:04 PM Tobias Burnus <tburnus@baylibre.com> wrote:
>>
>> I experimented with some variants to make clearer that each of RDNA2 and
>> RNDA3 applies to two card types, but at the end I settled on the
>> fewest-word version.
>>
>> Comments, remarks, suggestions? (To this change or in general?)
>>
>> Current version: https://gcc.gnu.org/gcc-14/changes.html#amdgcn
>>
>> Compiler flags, listing the the gfx* cards:
>> https://gcc.gnu.org/onlinedocs/gcc/AMD-GCN-Options.html
>>
>> Tobias
>>
>> PS: On the compiler side, I am looking forward to a .def file which
>> reduces the number of files to change when adding a new gfx* card, given
>> that we have doubled the number of entries. [Well, 1 missing but I know
>> of one WIP addition.]
>
> I do wonder whether hot-patching the ELF header from the libgomp plugin
> with the actual micro-subarch would be possible to make the driver happy.
> We do query the device ISA when initializing the device so we should
> be able to massage the ELF header of the object in GOMP_OFFLOAD_load_image
> at least within some constraints (ideally we'd mark the ELF object as to
> be matched with a device in some group).
This might work in some limited cases, especially if you limit the
codegen to some subset of the ISA, but in general the metadata on the
kernel entry-points is device-specific. For example, the gfx908 and
gfx90a have different granularity on the VGPR count settings. It would
probably be possible to generate some matching sets.
However, there's probably no need to do that ourselves because the LLVM
tools now have new generic ELF flags "gfx9-generic", "gfx10-1-generic",
"gfx10-3-generic", and "gfx11-generic" which supposedly do what you
want. I've not experimented with them. I don't know if libraries can
have the generic variant and still link with the specific variant (the
only libraries with kernel entry-points are the libgcc init_array and
fini_array). If not it becomes yet another multilib.
I'm very sure there's no one binary that will run anywhere for real
usecases.
Andrew
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [wwwdocs] gcc-14/changes.html (AMD GCN): Mention gfx1036 support
2024-04-15 12:00 ` Richard Biener
2024-04-15 12:27 ` Andrew Stubbs
@ 2024-04-15 17:59 ` Tobias Burnus
1 sibling, 0 replies; 5+ messages in thread
From: Tobias Burnus @ 2024-04-15 17:59 UTC (permalink / raw)
To: Richard Biener; +Cc: gcc-patches, Andrew Stubbs, Gerald Pfeifer
[-- Attachment #1: Type: text/plain, Size: 340 bytes --]
Richard Biener wrote:
> I do wonder whether hot-patching the ELF header from the libgomp plugin
> with the actual micro-subarch would be possible to make the driver happy.
For completeness, there is also the possibility to play with an
environment variable as in HSA_OVERRIDE_GFX_VERSION=9.0.0 or
HSA_OVERRIDE_GFX_VERSION=11.0.0
Tobias
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-04-15 17:59 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-15 10:03 [wwwdocs] gcc-14/changes.html (AMD GCN): Mention gfx1036 support Tobias Burnus
2024-04-15 10:06 ` Andrew Stubbs
2024-04-15 12:00 ` Richard Biener
2024-04-15 12:27 ` Andrew Stubbs
2024-04-15 17:59 ` Tobias Burnus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).