From: Jeff Law <jeffreyalaw@gmail.com>
To: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] cselib: Skip BImode while keeping track of subvalue relations [PR107088]
Date: Wed, 5 Oct 2022 20:48:13 -0600 [thread overview]
Message-ID: <43be68a9-3069-26eb-8b1a-4f9215e02f8d@gmail.com> (raw)
In-Reply-To: <20221004112849.27678-1-stefansf@linux.ibm.com>
On 10/4/22 05:28, Stefan Schulze Frielinghaus via Gcc-patches wrote:
> For BImode get_narrowest_mode evaluates to QImode but BImode < QImode.
> Thus FOR_EACH_MODE_UNTIL never reaches BImode and iterates until OImode
> for which no wider mode exists so we end up with VOIDmode and fail.
> Fixed by adding a size guard so we effectively skip BImode.
>
> Bootstrap and regtest are currently running on x64. Assuming they pass
> ok for mainline?
>
> gcc/ChangeLog:
>
> PR rtl-optimization/107088
> * cselib.cc (new_cselib_val): Skip BImode while keeping track of
> subvalue relations.
OK. And FWIW, this fixes the various failures I saw in my tester due to
the cselib patches.
jeff
next prev parent reply other threads:[~2022-10-06 2:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-04 11:28 Stefan Schulze Frielinghaus
2022-10-06 2:48 ` Jeff Law [this message]
2022-10-06 7:06 ` Stefan Schulze Frielinghaus
2022-10-07 14:15 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43be68a9-3069-26eb-8b1a-4f9215e02f8d@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).