From: Jeff Law <jeffreyalaw@gmail.com>
To: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Remove uninit_analysis::use_cannot_happen
Date: Fri, 26 Aug 2022 10:37:48 -0600 [thread overview]
Message-ID: <457b0e7d-2883-0313-b9d6-9b4371d28562@gmail.com> (raw)
In-Reply-To: <20220826065511.1057F13421@imap2.suse-dmz.suse.de>
On 8/26/2022 12:55 AM, Richard Biener via Gcc-patches wrote:
> As written earlier uninit_analysis::use_cannot_happen is duplicate
> functionality implemented in a complement way, not adhering to
> the idea of disproving a may-uninit use and eventually (I have not
> yet found a testcase it helps to avoid false positives) avoiding
> false positives because of this or different ways it imposes limits
> on the predicate computations.
>
> This patch removes it.
>
> I've bootstrapped and tested this before, but re-bootstrap/test
> on x86_64-unknown-linux-gnu is running now.
>
> * gimple-predicate-analysis.h
> (uninit_analysis::use_cannot_happen): Remove.
> * gimple-predicate-analysis.cc (can_be_invalidated_p): Remove.
> (uninit_analysis::use_cannot_happen): Likewise.
> (uninit_analysis::is_use_guarded): Do not call
> use_cannot_happen.
ACK. IIRC Aldy added this several years back to deal with a uninit
regression PR. If it's not triggering anymore, I'm not going to lose
any sleep over losing it.
jeff
prev parent reply other threads:[~2022-08-26 16:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-26 6:55 Richard Biener
2022-08-26 16:37 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=457b0e7d-2883-0313-b9d6-9b4371d28562@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).