From: Jeff Law <jeffreyalaw@gmail.com>
To: apinski@marvell.com, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 2/2] Improve error message for excess elements in array initializer from {"a"}
Date: Sun, 30 Apr 2023 10:24:17 -0600 [thread overview]
Message-ID: <459b385d-3799-7482-a7ce-6c36952709f1@gmail.com> (raw)
In-Reply-To: <1669828695-18532-2-git-send-email-apinski@marvell.com>
On 11/30/22 10:18, apinski--- via Gcc-patches wrote:
> From: Andrew Pinski <apinski@marvell.com>
>
> So char arrays are not the only type that be initialized from {"a"}.
> We can have wchar_t (L"") and char16_t (u"") types too. So let's
> print out the type of the array instead of just saying char.
>
> Note in the testsuite I used regex . to match '[' and ']' as
> I could not figure out how many '\' I needed.
>
> OK? Bootstrapped and tested on x86_64-linux-gnu with no regressions.
>
> gcc/c/ChangeLog:
>
> * c-typeck.cc (process_init_element): Print out array type
> for excessive elements.
>
> gcc/testsuite/ChangeLog:
>
> * gcc.dg/init-bad-1.c: Update error message.
> * gcc.dg/init-bad-2.c: Likewise.
> * gcc.dg/init-bad-3.c: Likewise.
> * gcc.dg/init-excess-3.c: Likewise.
> * gcc.dg/pr61096-1.c: Likewise.
OK
jeff
next prev parent reply other threads:[~2023-04-30 16:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-30 17:18 [PATCH 1/2] Fix C/107926: Wrong error message when initializing char array apinski
2022-11-30 17:18 ` [PATCH 2/2] Improve error message for excess elements in array initializer from {"a"} apinski
2022-11-30 23:05 ` Segher Boessenkool
2022-11-30 23:17 ` Andreas Schwab
2022-11-30 23:31 ` Segher Boessenkool
2023-04-30 16:24 ` Jeff Law [this message]
2022-11-30 17:29 ` [PATCH 1/2] Fix C/107926: Wrong error message when initializing char array Jakub Jelinek
2023-04-30 16:23 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=459b385d-3799-7482-a7ce-6c36952709f1@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=apinski@marvell.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).