From: Jakub Jelinek <jakub@redhat.com>
To: apinski@marvell.com
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 1/2] Fix C/107926: Wrong error message when initializing char array
Date: Wed, 30 Nov 2022 18:29:58 +0100 [thread overview]
Message-ID: <Y4eTFvHu/PGDw2/Z@tucnak> (raw)
In-Reply-To: <1669828695-18532-1-git-send-email-apinski@marvell.com>
On Wed, Nov 30, 2022 at 09:18:14AM -0800, apinski--- via Gcc-patches wrote:
> gcc/c/ChangeLog:
>
> PR c/107926
> * c-typeck.cc (process_init_element):
> Move the ceck for string cst until
> after the error message.
Just a ChangeLog nit, not a patch review for which I defer to C FE
maintainers/reviewers.
s/ceck/check/, plus don't start the description uselessly on a next line
when half of it would fit on the first line after ):.
* c-typeck.cc (process_init_element): Move the check for string cst
until after the error message.
Jakub
next prev parent reply other threads:[~2022-11-30 17:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-30 17:18 apinski
2022-11-30 17:18 ` [PATCH 2/2] Improve error message for excess elements in array initializer from {"a"} apinski
2022-11-30 23:05 ` Segher Boessenkool
2022-11-30 23:17 ` Andreas Schwab
2022-11-30 23:31 ` Segher Boessenkool
2023-04-30 16:24 ` Jeff Law
2022-11-30 17:29 ` Jakub Jelinek [this message]
2023-04-30 16:23 ` [PATCH 1/2] Fix C/107926: Wrong error message when initializing char array Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4eTFvHu/PGDw2/Z@tucnak \
--to=jakub@redhat.com \
--cc=apinski@marvell.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).