* [PATCH] configure: Only create serdep.tmp if needed
@ 2023-01-15 5:58 Peter Foley
2023-01-17 1:12 ` [PATCH v2] " Peter Foley
0 siblings, 1 reply; 4+ messages in thread
From: Peter Foley @ 2023-01-15 5:58 UTC (permalink / raw)
To: gcc-patches; +Cc: Peter Foley
There's no reason to create this file if none of the serial configure
options are passed.
ChangeLog:
* configure: Regenerate.
* configure.ac: Only create serdep.tmp if needed
Signed-off-by: Peter Foley <pefoley2@pefoley.com>
---
configure | 2 ++
configure.ac | 2 ++
2 files changed, 4 insertions(+)
diff --git a/configure b/configure
index 85883099410..47caaeb23fe 100755
--- a/configure
+++ b/configure
@@ -9918,7 +9918,9 @@ esac
# These force 'configure's to be done one at a time, to avoid problems
# with contention over a shared config.cache.
rm -f serdep.tmp
+if "x${enable_serial_build_configure}" = xyes || "x${enable_serial_host_configure}" = xyes || "x${enable_serial_target_configure}" = xyes ; then
echo '# serdep.tmp' > serdep.tmp
+fi
olditem=
test "x${enable_serial_build_configure}" = xyes &&
for item in ${build_configdirs} ; do
diff --git a/configure.ac b/configure.ac
index 2b612dce6e9..847df0c99b5 100644
--- a/configure.ac
+++ b/configure.ac
@@ -3071,7 +3071,9 @@ esac
# These force 'configure's to be done one at a time, to avoid problems
# with contention over a shared config.cache.
rm -f serdep.tmp
+if [ "x${enable_serial_build_configure}" = xyes || "x${enable_serial_host_configure}" = xyes || "x${enable_serial_target_configure}" = xyes ]; then
echo '# serdep.tmp' > serdep.tmp
+fi
olditem=
test "x${enable_serial_build_configure}" = xyes &&
for item in ${build_configdirs} ; do
--
2.39.0
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH v2] configure: Only create serdep.tmp if needed
2023-01-15 5:58 [PATCH] configure: Only create serdep.tmp if needed Peter Foley
@ 2023-01-17 1:12 ` Peter Foley
2023-01-17 1:14 ` Jeff Law
2023-04-21 19:16 ` Jeff Law
0 siblings, 2 replies; 4+ messages in thread
From: Peter Foley @ 2023-01-17 1:12 UTC (permalink / raw)
To: gcc-patches; +Cc: Peter Foley
There's no reason to create this file if none of the serial configure
options are passed.
v2: Use test instead of [ to avoid running afoul of autoconf quoting.
ChangeLog:
* configure: Regenerate.
* configure.ac: Only create serdep.tmp if needed
Signed-off-by: Peter Foley <pefoley2@pefoley.com>
---
configure | 2 ++
configure.ac | 2 ++
2 files changed, 4 insertions(+)
diff --git a/configure b/configure
index 85883099410..0494e2fa2bf 100755
--- a/configure
+++ b/configure
@@ -9918,7 +9918,9 @@ esac
# These force 'configure's to be done one at a time, to avoid problems
# with contention over a shared config.cache.
rm -f serdep.tmp
+if test "x${enable_serial_build_configure}" = xyes || test "x${enable_serial_host_configure}" = xyes || test "x${enable_serial_target_configure}" = xyes; then
echo '# serdep.tmp' > serdep.tmp
+fi
olditem=
test "x${enable_serial_build_configure}" = xyes &&
for item in ${build_configdirs} ; do
diff --git a/configure.ac b/configure.ac
index 2b612dce6e9..f5cce5830bc 100644
--- a/configure.ac
+++ b/configure.ac
@@ -3071,7 +3071,9 @@ esac
# These force 'configure's to be done one at a time, to avoid problems
# with contention over a shared config.cache.
rm -f serdep.tmp
+if test "x${enable_serial_build_configure}" = xyes || test "x${enable_serial_host_configure}" = xyes || test "x${enable_serial_target_configure}" = xyes; then
echo '# serdep.tmp' > serdep.tmp
+fi
olditem=
test "x${enable_serial_build_configure}" = xyes &&
for item in ${build_configdirs} ; do
--
2.39.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] configure: Only create serdep.tmp if needed
2023-01-17 1:12 ` [PATCH v2] " Peter Foley
@ 2023-01-17 1:14 ` Jeff Law
2023-04-21 19:16 ` Jeff Law
1 sibling, 0 replies; 4+ messages in thread
From: Jeff Law @ 2023-01-17 1:14 UTC (permalink / raw)
To: Peter Foley, gcc-patches
On 1/16/23 18:12, Peter Foley wrote:
> There's no reason to create this file if none of the serial configure
> options are passed.
>
> v2: Use test instead of [ to avoid running afoul of autoconf quoting.
>
> ChangeLog:
>
> * configure: Regenerate.
> * configure.ac: Only create serdep.tmp if needed
Note I think this should be deferred to gcc-14 given that gcc-13 is in
regression bugfixes only stage right now.
jeff
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] configure: Only create serdep.tmp if needed
2023-01-17 1:12 ` [PATCH v2] " Peter Foley
2023-01-17 1:14 ` Jeff Law
@ 2023-04-21 19:16 ` Jeff Law
1 sibling, 0 replies; 4+ messages in thread
From: Jeff Law @ 2023-04-21 19:16 UTC (permalink / raw)
To: Peter Foley, gcc-patches
On 1/16/23 18:12, Peter Foley wrote:
> There's no reason to create this file if none of the serial configure
> options are passed.
>
> v2: Use test instead of [ to avoid running afoul of autoconf quoting.
>
> ChangeLog:
>
> * configure: Regenerate.
> * configure.ac: Only create serdep.tmp if needed
Thanks. I bootstrapped and regression tested x86 without issues and
pushed this patch to the trunk.
jeff
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-04-21 19:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-15 5:58 [PATCH] configure: Only create serdep.tmp if needed Peter Foley
2023-01-17 1:12 ` [PATCH v2] " Peter Foley
2023-01-17 1:14 ` Jeff Law
2023-04-21 19:16 ` Jeff Law
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).