From: Jeff Law <jeffreyalaw@gmail.com>
To: Michael Collison <collison@rivosinc.com>,
Prathamesh Kulkarni <prathamesh.kulkarni@linaro.org>
Cc: gcc-patches@gcc.gnu.org, Richard Biener <richard.guenther@gmail.com>
Subject: Re: [PATCH v2] match.pd: rewrite select to branchless expression
Date: Thu, 17 Nov 2022 07:34:32 -0700 [thread overview]
Message-ID: <467686b8-ea88-2ffc-e969-d8a2ed6398df@gmail.com> (raw)
In-Reply-To: <e105a302-1725-7752-7e3e-7bb03ae9c227@rivosinc.com>
On 11/11/22 06:00, Michael Collison wrote:
> Hi Prathamesh,
>
> It is my understanding that INTEGRAL_TYPE_P applies to the other
> integer types you mentioned (chart, short, long). In fact the test
> function that motivated this match has a mixture of char and short and
> does not restrict matching.
What I think Prathamesh is asking is whether or not we want to have
tests with different types. It's less about correctness I think and
more about ensuring that the testsuite covers those tests in case they
regress in the future.
jeff
next prev parent reply other threads:[~2022-11-17 14:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-11 2:28 Michael Collison
2022-11-11 7:44 ` Prathamesh Kulkarni
2022-11-11 13:00 ` Michael Collison
2022-11-17 14:34 ` Jeff Law [this message]
2022-11-18 12:57 ` Richard Biener
2022-12-01 18:57 ` Michael Collison
2022-12-02 8:22 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=467686b8-ea88-2ffc-e969-d8a2ed6398df@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=collison@rivosinc.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=prathamesh.kulkarni@linaro.org \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).