Re: [PATCH] [OpenMP] GC unused SIMD clones

[Sandra Loosemore <sandra.loosemore@siemens.com>]

On 1/2/23 03:20, Tobias Burnus wrote:
> On 25.11.22 03:13, Sandra Loosemore wrote:
>> This patch is a followup to my not-yet-reviewed patch
>> [PATCH v4] OpenMP: Generate SIMD clones for functions with "declare
>> target"
> 
> That patch got reviewed and went into mainline on Nov 15, 2022 as
> https://gcc.gnu.org/r13-4309-g309e2d95e3b930c6f15c8a5346b913158404c76d>> 
> 
>> In comments on a previous iteration of that patch, I was asked to do
>> something to delete unused SIMD clones to avoid code bloat; this is it.
>>
>> I've implemented something like a simple mark-and-sweep algorithm.
>> Clones that are used are marked at the point where the call is
>> generated in the vectorizer.  The loop that iterates over functions to
>> apply the passes after IPA is modified to defer processing of unmarked
>> clones, and anything left over is deleted.
> 
> 
> Jakub referred to Honza for the review, who wrote yesterday off list (to
> me and Sandra):
> 
>> I am really sorry for taking so long time.  It was busy month for me
>> and I was not very keen about the idea, since we had such logic
>> implemented many years ago but removed it to be able to determine
>> functions to be output early and optimize code layout.
>>
>> I see that this is not possible with current organization where
>> vectorization is run late, so I guess it does make sense to do what you
>> are doing.
>>
>> Patch is OK,
>> Honza
> 
> Thanks for the review! (And to Sandra: thanks for the patch.)
> 
> I leave it to Sandra to commit her patch and only want to update the
> gcc-patches@ email. However. I think we can expect a commit tomorrow.
> (Today is a holiday at her place - as new year's day fell on a Sunday.)

Yes, the patch is committed now, and also backported to og12.  Thanks, 
Honza, for the review, and Tobias, for your assistance.  I'm really glad 
to get this project done, finally.  :-)

-Sandra