From: Robin Dapp <rdapp.gcc@gmail.com>
To: "juzhe.zhong" <juzhe.zhong@rivai.ai>
Cc: rdapp.gcc@gmail.com,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
"kito.cheng@gmail.com" <kito.cheng@gmail.com>,
"palmer@dabbelt.com" <palmer@dabbelt.com>,
"jeffreyalaw@gmail.com" <jeffreyalaw@gmail.com>
Subject: Re: [PATCH] RISC-V: Using merge approach to optimize repeating sequence in vec_init
Date: Fri, 12 May 2023 15:33:24 +0200 [thread overview]
Message-ID: <47e5da8a-c64c-c9c3-907d-e0c813e93b25@gmail.com> (raw)
In-Reply-To: <B92EC3D1521CF794+0530C6BE-51C8-48D7-AE25-31289DC1384F@rivai.ai>
> emit_merge_op can not be wrapped into binop since mask position is
> different in pattern.
>
> I prefer merge op in different wrapper.
Yes, I didn't mean literally the same but that things already
become a bit confusing with all the different variants and bool
arguments or code duplication with slight differences. Something
like foo (true, false, true) is a bit of a code smell. Nothing
to address immediately, I just need to keep an eye on it. Shouldn't
prevent the patch from going in.
prev parent reply other threads:[~2023-05-12 13:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-12 10:44 juzhe.zhong
2023-05-12 13:08 ` Robin Dapp
[not found] ` <B92EC3D1521CF794+0530C6BE-51C8-48D7-AE25-31289DC1384F@rivai.ai>
2023-05-12 13:33 ` Robin Dapp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47e5da8a-c64c-c9c3-907d-e0c813e93b25@gmail.com \
--to=rdapp.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
--cc=juzhe.zhong@rivai.ai \
--cc=kito.cheng@gmail.com \
--cc=palmer@dabbelt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).