From: Jason Merrill <jason@redhat.com>
To: Ben Boeckel <ben.boeckel@kitware.com>
Cc: Ben Boeckel <me@benboeckel.net>,
gcc-patches@gcc.gnu.org, nathan@acm.org, fortran@gcc.gnu.org,
gcc@gcc.gnu.org, brad.king@kitware.com
Subject: Re: [PATCH RESEND 1/1] p1689r5: initial support
Date: Thu, 20 Oct 2022 11:39:25 -0400 [thread overview]
Message-ID: <49eb01df-8da3-c5fb-f2c2-864c6c7dc227@redhat.com> (raw)
In-Reply-To: <Y06Zj4Lmeh2JduGS@megas.dev.benboeckel.internal>
On 10/18/22 08:18, Ben Boeckel wrote:
> On Tue, Oct 11, 2022 at 07:42:43 -0400, Ben Boeckel wrote:
>> On Mon, Oct 10, 2022 at 17:04:09 -0400, Jason Merrill wrote:
>>> Can we share utf8 parsing code with decode_utf8_char in pretty-print.cc?
>>
>> I can look at factoring that out. I'll have to decode its logic to see
>> how much overlap there is.
>
> There is some mismatch. First, that is in `gcc` and this is in `libcpp`.
Oops, I was thinking this was in gcc as well. In libcpp there's
_cpp_valid_utf8 (which calls one_utf8_to_cppchar).
Jason
next prev parent reply other threads:[~2022-10-20 15:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-04 15:11 [PATCH RESEND 0/1] RFC: P1689R5 support Ben Boeckel
2022-10-04 15:12 ` [PATCH RESEND 1/1] p1689r5: initial support Ben Boeckel
2022-10-04 19:12 ` Harald Anlauf
2022-10-11 11:30 ` Ben Boeckel
2022-10-10 21:04 ` Jason Merrill
2022-10-11 11:42 ` Ben Boeckel
2022-10-18 12:18 ` Ben Boeckel
2022-10-20 15:39 ` Jason Merrill [this message]
2022-10-20 17:31 ` Ben Boeckel
2022-10-20 18:22 ` Jason Merrill
2022-10-10 20:21 ` [PATCH RESEND 0/1] RFC: P1689R5 support Jason Merrill
2022-10-13 17:08 ` David Malcolm
2022-10-18 12:22 ` Ben Boeckel
2022-10-19 7:21 ` Martin Liška
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49eb01df-8da3-c5fb-f2c2-864c6c7dc227@redhat.com \
--to=jason@redhat.com \
--cc=ben.boeckel@kitware.com \
--cc=brad.king@kitware.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=gcc@gcc.gnu.org \
--cc=me@benboeckel.net \
--cc=nathan@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).